Skip to content

Commit 3b68276

Browse files
author
Codex Security Bot
committed
security: remove unsafe html rendering in notice and metadata views
1 parent f8ab88f commit 3b68276

File tree

2 files changed

+4
-16
lines changed

2 files changed

+4
-16
lines changed

cmdb-ui/src/modules/cmdb/views/ci/modules/MetadataDrawer.vue

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,13 @@
5656
{ label: $t('no'), value: false },
5757
]
5858
"
59-
type="html"
6059
>
6160
<template #default="{ row }">
6261
<span v-if="column.field !== 'name' && column.field !== 'alias' && column.field !== 'value_type'">
6362
<a-icon :style="{ color: '#1fb51f' }" type="check" v-if="row[column.field]" />
6463
</span>
65-
<span v-else-if="column.field === 'value_type'" v-html="valueTypeMap[row.value_type]"> </span>
66-
<span v-else v-html="row[column.field]"> </span>
64+
<span v-else-if="column.field === 'value_type'">{{ valueTypeMap[row.value_type] }}</span>
65+
<span v-else>{{ row[column.field] }}</span>
6766
</template>
6867
</vxe-column>
6968
</vxe-table>
@@ -196,26 +195,15 @@ export default {
196195
.trim()
197196
.toLowerCase()
198197
if (filterName) {
199-
const filterRE = new RegExp(filterName, 'gi')
200198
const searchProps = ['name', 'alias', 'value_type']
201-
const rest = this.tableData.filter((item) =>
199+
this.list = this.tableData.filter((item) =>
202200
searchProps.some(
203201
(key) =>
204202
XEUtils.toValueString(item[key])
205203
.toLowerCase()
206204
.indexOf(filterName) > -1
207205
)
208206
)
209-
this.list = rest.map((row) => {
210-
const item = Object.assign({}, row)
211-
searchProps.forEach((key) => {
212-
item[key] = XEUtils.toValueString(item[key]).replace(
213-
filterRE,
214-
(match) => `<span style='background: yellow'>${match}</span>`
215-
)
216-
})
217-
return item
218-
})
219207
} else {
220208
this.list = this.tableData
221209
}

cmdb-ui/src/views/noticeCenter/index.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
<vxe-column type="checkbox" width="60px"></vxe-column>
8686
<vxe-column field="content" title="标题内容">
8787
<template #default="{row}">
88-
<span v-html="row.content"></span>
88+
<span>{{ row.content }}</span>
8989
</template>
9090
</vxe-column>
9191
<vxe-column field="created_at" title="提交时间" width="150px">

0 commit comments

Comments
 (0)