Improve cli and gui separation

Author: MaximPlusov

README.md

@@ -113,7 +113,7 @@ Call Maven install:
 
 You can test your build by running the greenfield GUI application from the `gui` sub-module.
 
-    java -jar greenfield-apps/target/gui-${project.version}.jar
+    java -jar gui/target/gui-${project.version}.jar
 
 Where `${project.version}` is the current Maven project version. This should bring up the veraPDF GUI main window if the build was successful.
 

apps/src/main/java/org/verapdf/apps/AppsConstants.java

@@ -2,6 +2,7 @@
 
 public class AppsConstants {
 
+    // File extensions
     public static final String PDF = "pdf"; //$NON-NLS-1$
     public static final String ZIP = "zip"; //$NON-NLS-1$
 

apps/src/main/java/org/verapdf/apps/SoftwareUpdaterImpl.java

@@ -52,7 +52,7 @@
 
 public class SoftwareUpdaterImpl implements SoftwareUpdater {
 	private static final Logger logger = Logger.getLogger(SoftwareUpdaterImpl.class.getCanonicalName());
-	private static final String latestGF = "https://search.maven.org/solrsearch/select?q=g:org.verapdf.apps+AND+a:greenfield-apps&core=gav&rows=1&wt=xml";
+	private static final String latestGF = "https://search.maven.org/solrsearch/select?q=g:org.verapdf.apps+AND+a:gui&core=gav&rows=1&wt=xml";
 	private final String currentVersion = Applications.getAppDetails().getVersion();
 
 	/**

cli/pom.xml

@@ -111,12 +111,6 @@
             <version>${project.version}</version>
         </dependency>
 
-        <dependency>
-            <groupId>org.verapdf</groupId>
-            <artifactId>core</artifactId>
-            <version>${verapdf.library.version}</version>
-        </dependency>
-
         <dependency>
             <groupId>com.beust</groupId>
             <artifactId>jcommander</artifactId>

gui/src/main/java/org/verapdf/gui/CheckerPanel.java

@@ -21,6 +21,7 @@
 package org.verapdf.gui;
 
 import org.verapdf.apps.Applications;
+import org.verapdf.apps.AppsConstants;
 import org.verapdf.apps.utils.ApplicationUtils;
 import org.verapdf.core.utils.FileUtils;
 import org.verapdf.gui.utils.*;
@@ -115,7 +116,7 @@ class CheckerPanel extends JPanel {
 
 		this.initGui();
 
-		this.pdfChooser = getChooser(true, GUIConstants.PDF, GUIConstants.ZIP);
+		this.pdfChooser = getChooser(true, AppsConstants.PDF, AppsConstants.ZIP);
 		this.pdfChooser.setMultiSelectionEnabled(true);
 		this.pdfChooser.setFileSelectionMode(JFileChooser.FILES_AND_DIRECTORIES);
 		this.xmlChooser = getChooser(false, GUIConstants.XML);
@@ -266,7 +267,7 @@ private void setupChosenPDFField(final GridBagLayout gbl, final GridBagConstrain
 		this.add(this.chosenPDF);
 
 		PanelDropTargetListener dtdPDFListener = new PanelDropTargetListener(-1,
-				GUIConstants.PDF, GUIConstants.ZIP);
+				AppsConstants.PDF, AppsConstants.ZIP);
 		targetPDF = new DropTarget(this.chosenPDF, DnDConstants.ACTION_COPY_OR_MOVE,
 				dtdPDFListener, true, null);
 	}
@@ -284,7 +285,7 @@ private void setupChoosePDFButton(final GridBagLayout gbl, final GridBagConstrai
 		choosePDF.addActionListener(new ActionListener() {
 			@Override
 			public void actionPerformed(final ActionEvent e) {
-				CheckerPanel.this.chooseFile(CheckerPanel.this.pdfChooser, new String[] { GUIConstants.PDF });
+				CheckerPanel.this.chooseFile(CheckerPanel.this.pdfChooser, new String[] { AppsConstants.PDF });
 			}
 		});
 	}
@@ -782,7 +783,7 @@ public void insertFilesInfo(List<File> selectedFiles, String[] extensions){
 			this.viewHTML.setEnabled(false);
 
 			switch (extensions[0]) {
-				case GUIConstants.PDF:
+				case AppsConstants.PDF:
 					this.pdfsToProcess = ApplicationUtils.filterPdfFiles(selectedFiles, true, true);
 					this.chosenPDF.setText(getSelectedPathsMessage(selectedFiles));
 					break;
@@ -889,7 +890,7 @@ VeraAppConfig appConfigFromState() {
 		ProcessType selectedItem = (ProcessType) this.processTypes.getSelectedItem();
 		if (isFixMetadata() && config.getApplicationConfig().getFixesFolder().isEmpty() && this.pdfsToProcess != null) {
 			for (File pdf : pdfsToProcess) {
-				if (FileUtils.hasExtNoCase(pdf.getName(), GUIConstants.ZIP)) {
+				if (FileUtils.hasExtNoCase(pdf.getName(), AppsConstants.ZIP)) {
 					logger.log(Level.WARNING, "Fixing metadata are not supported for zip processing, if save folder isn't defined");
 					this.fixMetadata.setSelected(false);
 					break;

gui/src/main/java/org/verapdf/gui/utils/GUIConstants.java

@@ -46,8 +46,6 @@ public final class GUIConstants {
 	public static final String DOCS_POLICY_LINK_URL = DOCS_LINK_URL + "/policy";
 
 	// File extensions
-	public static final String PDF = "pdf"; //$NON-NLS-1$
-	public static final String ZIP = "zip"; //$NON-NLS-1$
 	public static final String XML = "xml"; //$NON-NLS-1$
 	public static final String HTML = "html"; //$NON-NLS-1$
 	public static final String SCH = "sch"; //$NON-NLS-1$