Merge pull request #103 from cadonuno/kms-on-update

Adding support for CMKs on application updates and fixing missing description parameter on create/update_app()

Author: tjarrettveracode

veracode_api_py/api.py

@@ -111,22 +111,25 @@ def get_app(self, guid: UUID = None, legacy_id=None):
     def get_app_by_name(self, appname):
         return Applications().get_by_name(appname)
 
-    def create_app(self, app_name, business_criticality, business_unit: UUID = None, teams=[], 
+    def create_app(self, app_name, business_criticality, description: str=None, business_unit: UUID = None, teams=[], 
                    policy_guid = None, custom_fields=[],bus_owner_name = None, bus_owner_email = None,
                    git_repo_url = None, custom_kms_alias = None):
-        return Applications().create(app_name=app_name, business_criticality=business_criticality, 
+        return Applications().create(app_name=app_name, description=description, 
+                                     business_criticality=business_criticality, 
                                      business_unit=business_unit, teams=teams, policy_guid=policy_guid,
                                      custom_fields=custom_fields, bus_owner_name=bus_owner_name, 
                                      bus_owner_email=bus_owner_email, git_repo_url=git_repo_url,
                                      custom_kms_alias=custom_kms_alias)
 
-    def update_app(self, guid: UUID, app_name, business_criticality, business_unit: UUID = None, teams=[], 
+    def update_app(self, guid: UUID, app_name, business_criticality, description: str=None, business_unit: UUID = None, teams=[], 
                    policy_guid = None, custom_fields=[], bus_owner_name=None, bus_owner_email=None,
-                   git_repo_url = None):
-        return Applications().update(guid=guid, app_name=app_name, business_criticality=business_criticality, 
+                   git_repo_url = None, custom_kms_alias=None):
+        return Applications().update(guid=guid, app_name=app_name, description=description, 
+                                     business_criticality=business_criticality, 
                                      business_unit=business_unit, teams=teams, policy_guid=policy_guid,
                                      custom_fields=custom_fields, bus_owner_name=bus_owner_name, 
-                                     bus_owner_email=bus_owner_email, git_repo_url=git_repo_url)    
+                                     bus_owner_email=bus_owner_email, git_repo_url=git_repo_url,
+                                     custom_kms_alias=custom_kms_alias)    
 
     def delete_app(self, guid: UUID):
         return Applications().delete(guid)

veracode_api_py/applications.py

@@ -42,12 +42,12 @@ def create(self,app_name:str ,business_criticality, description: str=None, busin
 
     def update(self,guid: UUID,app_name:str, business_criticality, description: str=None, business_unit: UUID=None, 
                teams=[], policy_guid:UUID=None, custom_fields=[],
-               bus_owner_name=None,bus_owner_email=None, git_repo_url=None):
+               bus_owner_name=None,bus_owner_email=None, git_repo_url=None, custom_kms_alias: str=None):
         return self._create_or_update("UPDATE",app_name=app_name,business_criticality=business_criticality,
                                       description=description,business_unit=business_unit,teams=teams,guid=guid, 
                                       policy_guid=policy_guid, custom_fields=custom_fields, 
                                       bus_owner_name=bus_owner_name,bus_owner_email=bus_owner_email,
-                                      git_repo_url=git_repo_url)
+                                      git_repo_url=git_repo_url, custom_kms_alias=custom_kms_alias)
 
     def delete(self,guid: UUID):
         uri = 'appsec/v1/applications/{}'.format(guid)
@@ -100,8 +100,7 @@ def _create_or_update(self,method,app_name: str, business_criticality, descripti
             gru = { 'git_repo_url': git_repo_url}
             app_def.update(gru)
 
-        if (custom_kms_alias != None) & (method=='CREATE'):
-            # custom_kms_alias currently only supported at creation
+        if (custom_kms_alias != None):
             app_def.update({"custom_kms_alias": custom_kms_alias})
 
         payload = json.dumps({"profile": app_def})