Fix Purchased Ticket title’s not including disabled or non-live status elements

engram-design · engram-design · commit 5fbb8fbf6b4d · 2026-01-23T23:58:58.000+11:00
diff --git a/src/elements/PurchasedTicket.php b/src/elements/PurchasedTicket.php
@@ -227,13 +227,8 @@ protected static function defineActions(string $source = null): array
 
     public function init(): void
     {
-        // Title is dynamic
-        if ($eventType = $this->getEvent()?->getType()) {
-            try {
-                // Title is dynamic
-                $this->title = Craft::$app->getView()->renderObjectTemplate($eventType->purchasedTicketTitleFormat, $this);
-            } catch (Throwable $e) {
-            }
+        if ($title = $this->getDynamicTitle()) {
+            $this->title = $title;
         }
 
         parent::init();
@@ -293,14 +288,26 @@ public function getFieldLayout(): ?FieldLayout
         return null;
     }
 
+    public function getDynamicTitle(): ?string
+    {
+        if ($eventType = $this->getEvent()?->getType()) {
+            try {
+                return Craft::$app->getView()->renderObjectTemplate($eventType->purchasedTicketTitleFormat, $this);
+            } catch (Throwable $e) {
+            }
+        }
+
+        return null;
+    }
+
     public function getEvent(): ?Event
     {
         if ($this->_event) {
             return $this->_event;
         }
 
         if ($this->eventId) {
-            return $this->_event = Event::find()->id($this->eventId)->one();
+            return $this->_event = Events::$plugin->getEvents()->getEventById($this->eventId);
         }
 
         return null;
@@ -318,7 +325,7 @@ public function getSession(): ?Session
         }
 
         if ($this->sessionId) {
-            return $this->_session = Session::find()->id($this->sessionId)->one();
+            return $this->_session = Events::$plugin->getSessions()->getSessionById($this->sessionId);
         }
 
         return null;
@@ -336,7 +343,7 @@ public function getTicket(): ?Ticket
         }
 
         if ($this->ticketId) {
-            return $this->_ticket = Ticket::find()->id($this->ticketId)->one();
+            return $this->_ticket = Events::$plugin->getTickets()->getTicketById($this->ticketId);
         }
 
         return null;
@@ -354,7 +361,7 @@ public function getTicketType(): ?TicketType
         }
 
         if ($this->ticketTypeId) {
-            return $this->_ticketType = TicketType::find()->id($this->ticketTypeId)->one();
+            return $this->_ticketType = Events::$plugin->getTicketTypes()->getTicketTypeById($this->ticketTypeId);
         }
 
         return null;
diff --git a/src/elements/Ticket.php b/src/elements/Ticket.php
@@ -212,18 +212,15 @@ public function getDescription(): string
 
     public function getEvent(): ?Event
     {
-        if (!$this->_event) {
-            if ($this->eventId) {
-                // Only while in the CP, we often want to get disabled elements
-                $status = Craft::$app->getRequest()->getIsCpRequest() ? null : self::STATUS_ENABLED;
-
-                $this->_event = Event::find()->id($this->eventId)->status($status)->one();
-            } else {
-                return null;
-            }
+        if ($this->_event) {
+            return $this->_event;
+        }
+
+        if ($this->eventId) {
+            return $this->_event = Events::$plugin->getEvents()->getEventById($this->eventId);
         }
 
-        return $this->_event;
+        return null;
     }
 
     public function setEvent(Event $event): void
@@ -234,18 +231,15 @@ public function setEvent(Event $event): void
 
     public function getSession(): ?Session
     {
-        if (!$this->_session) {
-            if ($this->sessionId) {
-                // Only while in the CP, we often want to get disabled elements
-                $status = Craft::$app->getRequest()->getIsCpRequest() ? null : self::STATUS_ENABLED;
+        if ($this->_session) {
+            return $this->_session;
+        }
 
-                $this->_session = Session::find()->id($this->sessionId)->status($status)->one();
-            } else {
-                return null;
-            }
+        if ($this->sessionId) {
+            return $this->_session = Events::$plugin->getSessions()->getSessionById($this->sessionId);
         }
 
-        return $this->_session;
+        return null;
     }
 
     public function setSession(Session $session): void
@@ -256,18 +250,15 @@ public function setSession(Session $session): void
 
     public function getType(): ?TicketType
     {
-        if (!$this->_type) {
-            if ($this->typeId) {
-                // Only while in the CP, we often want to get disabled elements
-                $status = Craft::$app->getRequest()->getIsCpRequest() ? null : self::STATUS_ENABLED;
+        if ($this->_type) {
+            return $this->_type;
+        }
 
-                $this->_type = TicketType::find()->id($this->typeId)->status($status)->one();
-            } else {
-                return null;
-            }
+        if ($this->typeId) {
+            return $this->_type = Events::$plugin->getTicketTypes()->getTicketTypeById($this->typeId);
         }
 
-        return $this->_type;
+        return null;
     }
 
     public function setType(TicketType $type): void
diff --git a/src/services/Events.php b/src/services/Events.php
@@ -17,7 +17,7 @@ class Events extends Component
 
     public function getEventById(int $id, int $siteId = null): ?Event
     {
-        return Craft::$app->getElements()->getElementById($id, Event::class, $siteId);
+        return Event::find()->id($id)->site($siteId)->status(null)->one();
     }
 
     public function afterSaveSiteHandler(SiteEvent $event): void
diff --git a/src/services/Sessions.php b/src/services/Sessions.php
@@ -83,9 +83,9 @@ public function getAllSessionsByEventId(int $eventId, int $siteId = null, bool $
         return $sessionQuery->all();
     }
 
-    public function getSessionById(int $sessionId, int $siteId = null): ?Session
+    public function getSessionById(int $id, int $siteId = null): ?Session
     {
-        return Craft::$app->getElements()->getElementById($sessionId, Session::class, $siteId);
+        return Session::find()->id($id)->site($siteId)->status(null)->one();
     }
 
     public function getSessionGqlContentArguments(): array
diff --git a/src/services/TicketTypes.php b/src/services/TicketTypes.php
@@ -38,9 +38,9 @@ public function getAllTicketTypesByEventId(int $eventId, int $siteId = null, boo
         return $ticketTypeQuery->all();
     }
 
-    public function getTicketTypeById(int $ticketTypeId, int $siteId = null): ?TicketType
+    public function getTicketTypeById(int $id, int $siteId = null): ?TicketType
     {
-        return Craft::$app->getElements()->getElementById($ticketTypeId, TicketType::class, $siteId);
+        return TicketType::find()->id($id)->site($siteId)->status(null)->one();
     }
 
     public function getTicketTypeGqlContentArguments(): array
diff --git a/src/services/Tickets.php b/src/services/Tickets.php
@@ -25,9 +25,9 @@ class Tickets extends Component
     // Public Methods
     // =========================================================================
 
-    public function getTicketById(int $ticketId, int $siteId = null): ?Ticket
+    public function getTicketById(int $id, int $siteId = null): ?Ticket
     {
-        return Craft::$app->getElements()->getElementById($ticketId, Ticket::class, $siteId);
+        return Ticket::find()->id($id)->site($siteId)->status(null)->one();
     }
 
     public function onBeforeSendEmail(MailEvent $event): void

Original file line number	Diff line number	Diff line change
`@@ -227,13 +227,8 @@ protected static function defineActions(string $source = null): array`
`227`	`227`
`228`	`228`	`public function init(): void`
`229`	`229`	`{`
`230`		`- // Title is dynamic`
`231`		`- if ($eventType = $this->getEvent()?->getType()) {`
`232`		`- try {`
`233`		`- // Title is dynamic`
`234`		`- $this->title = Craft::$app->getView()->renderObjectTemplate($eventType->purchasedTicketTitleFormat, $this);`
`235`		`- } catch (Throwable $e) {`
`236`		`- }`
	`230`	`+ if ($title = $this->getDynamicTitle()) {`
	`231`	`+ $this->title = $title;`
`237`	`232`	`}`
`238`	`233`
`239`	`234`	`parent::init();`
`@@ -293,14 +288,26 @@ public function getFieldLayout(): ?FieldLayout`
`293`	`288`	`return null;`
`294`	`289`	`}`
`295`	`290`
	`291`	`+ public function getDynamicTitle(): ?string`
	`292`	`+ {`
	`293`	`+ if ($eventType = $this->getEvent()?->getType()) {`
	`294`	`+ try {`
	`295`	`+ return Craft::$app->getView()->renderObjectTemplate($eventType->purchasedTicketTitleFormat, $this);`
	`296`	`+ } catch (Throwable $e) {`
	`297`	`+ }`
	`298`	`+ }`
	`299`	`+`
	`300`	`+ return null;`
	`301`	`+ }`
	`302`	`+`
`296`	`303`	`public function getEvent(): ?Event`
`297`	`304`	`{`
`298`	`305`	`if ($this->_event) {`
`299`	`306`	`return $this->_event;`
`300`	`307`	`}`
`301`	`308`
`302`	`309`	`if ($this->eventId) {`
`303`		`- return $this->_event = Event::find()->id($this->eventId)->one();`
	`310`	`+ return $this->_event = Events::$plugin->getEvents()->getEventById($this->eventId);`
`304`	`311`	`}`
`305`	`312`
`306`	`313`	`return null;`
`@@ -318,7 +325,7 @@ public function getSession(): ?Session`
`318`	`325`	`}`
`319`	`326`
`320`	`327`	`if ($this->sessionId) {`
`321`		`- return $this->_session = Session::find()->id($this->sessionId)->one();`
	`328`	`+ return $this->_session = Events::$plugin->getSessions()->getSessionById($this->sessionId);`
`322`	`329`	`}`
`323`	`330`
`324`	`331`	`return null;`
`@@ -336,7 +343,7 @@ public function getTicket(): ?Ticket`
`336`	`343`	`}`
`337`	`344`
`338`	`345`	`if ($this->ticketId) {`
`339`		`- return $this->_ticket = Ticket::find()->id($this->ticketId)->one();`
	`346`	`+ return $this->_ticket = Events::$plugin->getTickets()->getTicketById($this->ticketId);`
`340`	`347`	`}`
`341`	`348`
`342`	`349`	`return null;`
`@@ -354,7 +361,7 @@ public function getTicketType(): ?TicketType`
`354`	`361`	`}`
`355`	`362`
`356`	`363`	`if ($this->ticketTypeId) {`
`357`		`- return $this->_ticketType = TicketType::find()->id($this->ticketTypeId)->one();`
	`364`	`+ return $this->_ticketType = Events::$plugin->getTicketTypes()->getTicketTypeById($this->ticketTypeId);`
`358`	`365`	`}`
`359`	`366`
`360`	`367`	`return null;`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ class Events extends Component`
`17`	`17`
`18`	`18`	`public function getEventById(int $id, int $siteId = null): ?Event`
`19`	`19`	`{`
`20`		`- return Craft::$app->getElements()->getElementById($id, Event::class, $siteId);`
	`20`	`+ return Event::find()->id($id)->site($siteId)->status(null)->one();`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`public function afterSaveSiteHandler(SiteEvent $event): void`
Original file line number	Diff line number	Diff line change
`@@ -83,9 +83,9 @@ public function getAllSessionsByEventId(int $eventId, int $siteId = null, bool $`
`83`	`83`	`return $sessionQuery->all();`
`84`	`84`	`}`
`85`	`85`
`86`		`- public function getSessionById(int $sessionId, int $siteId = null): ?Session`
	`86`	`+ public function getSessionById(int $id, int $siteId = null): ?Session`
`87`	`87`	`{`
`88`		`- return Craft::$app->getElements()->getElementById($sessionId, Session::class, $siteId);`
	`88`	`+ return Session::find()->id($id)->site($siteId)->status(null)->one();`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`public function getSessionGqlContentArguments(): array`
Original file line number	Diff line number	Diff line change
`@@ -38,9 +38,9 @@ public function getAllTicketTypesByEventId(int $eventId, int $siteId = null, boo`
`38`	`38`	`return $ticketTypeQuery->all();`
`39`	`39`	`}`
`40`	`40`
`41`		`- public function getTicketTypeById(int $ticketTypeId, int $siteId = null): ?TicketType`
	`41`	`+ public function getTicketTypeById(int $id, int $siteId = null): ?TicketType`
`42`	`42`	`{`
`43`		`- return Craft::$app->getElements()->getElementById($ticketTypeId, TicketType::class, $siteId);`
	`43`	`+ return TicketType::find()->id($id)->site($siteId)->status(null)->one();`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`public function getTicketTypeGqlContentArguments(): array`
Original file line number	Diff line number	Diff line change
`@@ -25,9 +25,9 @@ class Tickets extends Component`
`25`	`25`	`// Public Methods`
`26`	`26`	`// =========================================================================`
`27`	`27`
`28`		`- public function getTicketById(int $ticketId, int $siteId = null): ?Ticket`
	`28`	`+ public function getTicketById(int $id, int $siteId = null): ?Ticket`
`29`	`29`	`{`
`30`		`- return Craft::$app->getElements()->getElementById($ticketId, Ticket::class, $siteId);`
	`30`	`+ return Ticket::find()->id($id)->site($siteId)->status(null)->one();`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`public function onBeforeSendEmail(MailEvent $event): void`