Unique directories

Author: cramforce

src/tool.vercel.integration.test.ts

@@ -1,28 +1,28 @@
+// Excluded from pnpm test. Use pnpm test:vercel to run these tests.
 import { Sandbox } from "@vercel/sandbox";
 import type { ToolExecutionOptions } from "ai";
-import {
-  afterAll,
-  afterEach,
-  assert,
-  beforeAll,
-  describe,
-  expect,
-  it,
-} from "vitest";
+import { afterAll, assert, beforeAll, describe, expect, it } from "vitest";
 import { createBashTool } from "./tool.js";
 import type { CommandResult } from "./types.js";
 
 // AI SDK tool execute requires (args, options) - we provide test options
 const opts: ToolExecutionOptions = { toolCallId: "test", messages: [] };
 
+/** Generate a unique test directory to avoid race conditions between tests */
+function uniqueDir(): string {
+  return `/vercel/sandbox/test-${Date.now()}-${Math.random()
+    .toString(36)
+    .slice(2, 8)}`;
+}
+
 /**
  * Integration tests that verify createBashTool works correctly
  * with the real @vercel/sandbox environment.
  *
  * These tests require Vercel OIDC authentication.
  * Run with: pnpm test:vercel
  *
- * Note: createBashTool automatically uses /vercel/sandbox as the default
+ * Note: createBashTool automatically uses /vercel/sandbox/workspace as the default
  * destination when a @vercel/sandbox instance is provided.
  */
 describe("createBashTool @vercel/sandbox integration", () => {
@@ -41,19 +41,9 @@ describe("createBashTool @vercel/sandbox integration", () => {
   beforeAll(async () => {
     console.log("Creating sandbox");
     vercelSandbox = await Sandbox.create();
+    console.log("Sandbox created");
   }, 60000);
 
-  afterEach(async () => {
-    if (vercelSandbox) {
-      const result = await vercelSandbox.runCommand("rm", [
-        "-rf",
-        "/vercel/sandbox/workspace",
-      ]);
-      expect(await result.stderr()).toBe("");
-      expect(result.exitCode).toBe(0);
-    }
-  });
-
   afterAll(async () => {
     if (vercelSandbox) {
       await vercelSandbox.stop();
@@ -62,15 +52,17 @@ describe("createBashTool @vercel/sandbox integration", () => {
 
   describe("ls command", () => {
     it("ls -la lists files with details", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "ls -la" },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.exitCode).toBe(0);
@@ -80,15 +72,17 @@ describe("createBashTool @vercel/sandbox integration", () => {
     }, 30000);
 
     it("ls lists directory contents", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "ls src" },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.exitCode).toBe(0);
@@ -98,15 +92,17 @@ describe("createBashTool @vercel/sandbox integration", () => {
 
   describe("find command", () => {
     it("find . -name '*.ts' finds TypeScript files", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "find . -name '*.ts'" },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.exitCode).toBe(0);
@@ -117,15 +113,17 @@ describe("createBashTool @vercel/sandbox integration", () => {
     }, 30000);
 
     it("find . -name '*.json' finds JSON files", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "find . -name '*.json'" },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.exitCode).toBe(0);
@@ -135,15 +133,17 @@ describe("createBashTool @vercel/sandbox integration", () => {
 
   describe("grep command", () => {
     it("grep -r 'pattern' . searches file contents", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "grep -r 'export' ." },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.stderr).toBe("");
@@ -154,62 +154,69 @@ describe("createBashTool @vercel/sandbox integration", () => {
     }, 30000);
 
     it("grep finds specific patterns", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "grep -r 'hello' ." },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.exitCode).toBe(0);
       expect(result.stdout.trim()).toBe(
-        './src/index.ts:export const hello = "world";',
+        './src/index.ts:export const hello = "world";'
       );
     }, 30000);
   });
 
   describe("cat command", () => {
     it("cat <file> views file contents", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "cat src/index.ts" },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.exitCode).toBe(0);
       expect(result.stdout).toBe('export const hello = "world";');
     }, 30000);
 
     it("cat package.json shows JSON content", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "cat package.json" },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.exitCode).toBe(0);
       expect(result.stdout).toBe(
-        '{"name": "test-project", "version": "1.0.0"}',
+        '{"name": "test-project", "version": "1.0.0"}'
       );
     }, 30000);
   });
 
   describe("working directory", () => {
-    it("pwd shows correct working directory", async () => {
+    it("uses /vercel/sandbox/workspace as default destination", async () => {
+      // This test verifies the default destination behavior - no custom destination
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
         files: testFiles,
@@ -218,43 +225,45 @@ describe("createBashTool @vercel/sandbox integration", () => {
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "pwd" },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.exitCode).toBe(0);
       expect(result.stdout.trim()).toBe("/vercel/sandbox/workspace");
     }, 30000);
 
     it("pwd shows custom destination within sandbox", async () => {
-      const customDest = "/vercel/sandbox/project";
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
-        destination: customDest,
       });
 
       assert(tools.bash.execute, "bash.execute should be defined");
       const result = (await tools.bash.execute(
         { command: "pwd" },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.exitCode).toBe(0);
-      expect(result.stdout.trim()).toBe(customDest);
+      expect(result.stdout.trim()).toBe(dest);
     }, 30000);
   });
 
   describe("readFile tool", () => {
     it("reads file content correctly", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
       assert(tools.readFile.execute, "readFile.execute should be defined");
       const result = (await tools.readFile.execute(
-        { path: "/vercel/sandbox/workspace/src/index.ts" },
-        opts,
+        { path: `${dest}/src/index.ts` },
+        opts
       )) as { content: string };
 
       expect(result.content).toBe('export const hello = "world";');
@@ -263,8 +272,10 @@ describe("createBashTool @vercel/sandbox integration", () => {
 
   describe("writeFile tool", () => {
     it("writes file and can be read back", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: testFiles,
       });
 
@@ -276,12 +287,12 @@ describe("createBashTool @vercel/sandbox integration", () => {
           path: "newfile.txt",
           content: "Hello, World!",
         },
-        opts,
+        opts
       );
 
       const result = (await tools.bash.execute(
         { command: "cat newfile.txt" },
-        opts,
+        opts
       )) as CommandResult;
 
       expect(result.stdout).toBe("Hello, World!");
@@ -292,8 +303,10 @@ describe("createBashTool @vercel/sandbox integration", () => {
 
   describe("promptOptions", () => {
     it("uses custom toolPrompt when provided", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: { "data.json": "{}" },
         promptOptions: {
           toolPrompt: "Custom tools: myTool",
@@ -305,8 +318,10 @@ describe("createBashTool @vercel/sandbox integration", () => {
     }, 30000);
 
     it("disables tool hints with empty string toolPrompt", async () => {
+      const dest = uniqueDir();
       const { tools } = await createBashTool({
         sandbox: vercelSandbox,
+        destination: dest,
         files: { "data.json": "{}" },
         promptOptions: {
           toolPrompt: "",