diff --git a/packages/cookies/src/response-cookies.ts b/packages/cookies/src/response-cookies.ts index 3bf7c3e7..5c548f48 100644 --- a/packages/cookies/src/response-cookies.ts +++ b/packages/cookies/src/response-cookies.ts @@ -110,10 +110,6 @@ function replace(bag: Map, headers: Headers) { } function normalizeCookie(cookie: ResponseCookie = { name: '', value: '' }) { - if (typeof cookie.expires === 'number') { - cookie.expires = new Date(cookie.expires) - } - if (cookie.maxAge) { cookie.expires = new Date(Date.now() + cookie.maxAge * 1000) } diff --git a/packages/cookies/src/types.ts b/packages/cookies/src/types.ts index fcd4d461..065164ff 100644 --- a/packages/cookies/src/types.ts +++ b/packages/cookies/src/types.ts @@ -13,8 +13,8 @@ export interface CookieListItem name: string /** A string containing the value of the cookie. */ value: string - /** A number of milliseconds or Date interface containing the expires of the cookie. */ - expires?: number | CookieSerializeOptions['expires'] + /** A Date interface containing the expires of the cookie. */ + expires?: CookieSerializeOptions['expires'] } /** diff --git a/packages/cookies/test/response-cookies.test.ts b/packages/cookies/test/response-cookies.test.ts index 3e111939..42ebe840 100644 --- a/packages/cookies/test/response-cookies.test.ts +++ b/packages/cookies/test/response-cookies.test.ts @@ -12,7 +12,6 @@ test('reflect .set into `set-cookie`', async () => { .set('foo', 'bar', { path: '/test' }) .set('fooz', 'barz', { path: '/test2' }) .set('fooHttpOnly', 'barHttpOnly', { httpOnly: true }) - .set('fooExpires', 'barExpires', { expires: 0 }) .set('fooExpiresDate', 'barExpiresDate', { expires: new Date(0) }) .set('fooMaxAge', '', { maxAge: 0 }) .set('fooSameSite', 'barSameSite', { @@ -24,7 +23,6 @@ test('reflect .set into `set-cookie`', async () => { expect(cookies.get('foo')?.value).toBe('bar') expect(cookies.get('fooz')?.value).toBe('barz') expect(cookies.get('fooHttpOnly')?.value).toBe('barHttpOnly') - expect(cookies.get('fooExpires')?.value).toBe('barExpires') expect(cookies.get('fooExpiresDate')?.value).toBe('barExpiresDate') expect(cookies.get('fooMaxAge')?.value).toBe('') expect(cookies.get('fooSameSite')?.value).toBe('barSameSite') @@ -46,12 +44,6 @@ test('reflect .set into `set-cookie`', async () => { path: '/', httpOnly: true, }) - expect(cookies.get('fooExpires')).toEqual({ - name: 'fooExpires', - value: 'barExpires', - path: '/', - expires: new Date(0), - }) expect(cookies.get('fooExpiresDate')).toEqual({ name: 'fooExpiresDate', value: 'barExpiresDate', @@ -77,7 +69,6 @@ test('reflect .set into `set-cookie`', async () => { 'foo=bar; Path=/test', 'fooz=barz; Path=/test2', 'fooHttpOnly=barHttpOnly; Path=/; HttpOnly', - 'fooExpires=barExpires; Path=/; Expires=Thu, 01 Jan 1970 00:00:00 GMT', 'fooExpiresDate=barExpiresDate; Path=/; Expires=Thu, 01 Jan 1970 00:00:00 GMT', 'fooMaxAge=; Path=/; Max-Age=0', 'fooSameSite=barSameSite; Path=/; Secure; SameSite=none; Partitioned',