From 1a463d8e96535bfa1127d96a94ca8207d063c1f4 Mon Sep 17 00:00:00 2001 From: Guilherme Sehn Date: Sat, 24 Aug 2024 01:42:27 -0300 Subject: [PATCH 1/3] add test --- packages/jest-environment/test/index.test.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/jest-environment/test/index.test.ts b/packages/jest-environment/test/index.test.ts index 91fd9ee1..ae27a132 100644 --- a/packages/jest-environment/test/index.test.ts +++ b/packages/jest-environment/test/index.test.ts @@ -19,3 +19,7 @@ test('allows to run crypto', async () => { test('has EdgeRuntime global', () => { expect(EdgeRuntime).toEqual('edge-runtime') }) + +test('does not have access to node global variables', () => { + expect(typeof Buffer).toEqual('undefined') +}) From 5c23385c00d2d5af3f19290ff8a493c9dd431c9d Mon Sep 17 00:00:00 2001 From: Guilherme Sehn Date: Sat, 24 Aug 2024 01:42:34 -0300 Subject: [PATCH 2/3] remove Buffer --- packages/jest-environment/src/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/jest-environment/src/index.ts b/packages/jest-environment/src/index.ts index 937e2a77..ad72b217 100644 --- a/packages/jest-environment/src/index.ts +++ b/packages/jest-environment/src/index.ts @@ -19,7 +19,6 @@ class EdgeEnvironment implements JestEnvironment { const vm = new EdgeVM({ extend: (context) => { context.global = context - context.Buffer = Buffer return context }, ...((config as any).projectConfig ?? config)?.testEnvironmentOptions, From ea9a5a442b29ffe749c74f416f06a7a2d50555fe Mon Sep 17 00:00:00 2001 From: Guilherme Sehn Date: Sat, 24 Aug 2024 01:59:03 -0300 Subject: [PATCH 3/3] add changeset --- .changeset/beige-tomatoes-lay.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/beige-tomatoes-lay.md diff --git a/.changeset/beige-tomatoes-lay.md b/.changeset/beige-tomatoes-lay.md new file mode 100644 index 00000000..a8f9ed5c --- /dev/null +++ b/.changeset/beige-tomatoes-lay.md @@ -0,0 +1,5 @@ +--- +'@edge-runtime/jest-environment': major +--- + +Disallow access to `Buffer`