Skip to content

Commit 1dfd258

Browse files
eps1loneps1lon
committed
[dev-overlay] Remove unused onError in /pages
Every implementation is a no-op and we don't have any plans. Can use the same pattern as App Router when we need it.
1 parent 8727abe commit 1dfd258

File tree

4 files changed

+15
-30
lines changed

4 files changed

+15
-30
lines changed

‎packages/next/src/client/components/react-dev-overlay/pages/hooks.ts‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,8 @@ export const usePagesDevOverlay = () => {
2727
}
2828
}, [dispatch])
2929

30-
const onComponentError = React.useCallback(
31-
(_error: Error, _componentStack: string | null) => {
32-
// TODO: special handling
33-
},
34-
[]
35-
)
36-
3730
return {
3831
state,
39-
onComponentError,
4032
dispatch,
4133
}
4234
}

‎packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import React from 'react'
22

33
type PagesDevOverlayErrorBoundaryProps = {
44
children?: React.ReactNode
5-
onError: (error: Error, componentStack: string | null) => void
65
}
76
type PagesDevOverlayErrorBoundaryState = { error: Error | null }
87

@@ -16,13 +15,7 @@ export class PagesDevOverlayErrorBoundary extends React.PureComponent<
1615
return { error }
1716
}
1817

19-
componentDidCatch(
20-
error: Error,
21-
// Loosely typed because it depends on the React version and was
22-
// accidentally excluded in some versions.
23-
errorInfo?: { componentStack?: string | null }
24-
) {
25-
this.props.onError(error, errorInfo?.componentStack || null)
18+
componentDidCatch(error: Error) {
2619
this.setState({ error })
2720
}
2821

‎packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ interface PagesDevOverlayProps {
1313
}
1414

1515
export function PagesDevOverlay({ children }: PagesDevOverlayProps) {
16-
const { state, dispatch, onComponentError } = usePagesDevOverlay()
16+
const { state, dispatch } = usePagesDevOverlay()
1717

1818
return (
1919
<>
20-
<PagesDevOverlayErrorBoundary onError={onComponentError}>
20+
<PagesDevOverlayErrorBoundary>
2121
{children ?? null}
2222
</PagesDevOverlayErrorBoundary>
2323

‎test/development/acceptance/hydration-error.test.ts‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
105105
<AppContainer>
106106
<Container fn={function fn}>
107107
<PagesDevOverlay>
108-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
108+
<PagesDevOverlayErrorBoundary>
109109
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
110110
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
111111
<Mismatch>
@@ -211,7 +211,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
211211
<AppContainer>
212212
<Container fn={function fn}>
213213
<PagesDevOverlay>
214-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
214+
<PagesDevOverlayErrorBoundary>
215215
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
216216
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
217217
<Mismatch>
@@ -302,7 +302,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
302302
<AppContainer>
303303
<Container fn={function fn}>
304304
<PagesDevOverlay>
305-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
305+
<PagesDevOverlayErrorBoundary>
306306
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
307307
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
308308
<Mismatch>
@@ -378,7 +378,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
378378
<AppContainer>
379379
<Container fn={function fn}>
380380
<PagesDevOverlay>
381-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
381+
<PagesDevOverlayErrorBoundary>
382382
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
383383
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
384384
<Mismatch>
@@ -449,7 +449,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
449449
<AppContainer>
450450
<Container fn={function fn}>
451451
<PagesDevOverlay>
452-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
452+
<PagesDevOverlayErrorBoundary>
453453
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
454454
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
455455
<Mismatch>
@@ -539,7 +539,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
539539
"componentStack": "...
540540
<Container fn={function fn}>
541541
<PagesDevOverlay>
542-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
542+
<PagesDevOverlayErrorBoundary>
543543
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
544544
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
545545
<Page>
@@ -628,7 +628,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
628628
<AppContainer>
629629
<Container fn={function fn}>
630630
<PagesDevOverlay>
631-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
631+
<PagesDevOverlayErrorBoundary>
632632
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
633633
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
634634
<Page>
@@ -722,7 +722,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
722722
{
723723
"componentStack": "...
724724
<PagesDevOverlay>
725-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
725+
<PagesDevOverlayErrorBoundary>
726726
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
727727
<App pageProps={{}} Component={function Mismatch} err={undefined} router={{sdc:{},sbc:{}, ...}}>
728728
<Mismatch>
@@ -846,7 +846,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
846846
<AppContainer>
847847
<Container fn={function fn}>
848848
<PagesDevOverlay>
849-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
849+
<PagesDevOverlayErrorBoundary>
850850
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
851851
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
852852
<Page>
@@ -940,7 +940,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
940940
"componentStack": "...
941941
<Container fn={function fn}>
942942
<PagesDevOverlay>
943-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
943+
<PagesDevOverlayErrorBoundary>
944944
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
945945
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
946946
<Page>
@@ -1026,7 +1026,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
10261026
<AppContainer>
10271027
<Container fn={function fn}>
10281028
<PagesDevOverlay>
1029-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
1029+
<PagesDevOverlayErrorBoundary>
10301030
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
10311031
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
10321032
<Page>
@@ -1120,7 +1120,7 @@ describe('Error overlay for hydration errors in Pages router', () => {
11201120
<AppContainer>
11211121
<Container fn={function fn}>
11221122
<PagesDevOverlay>
1123-
<PagesDevOverlayErrorBoundary onError={function usePagesDevOverlay.useCallback[onComponentError]}>
1123+
<PagesDevOverlayErrorBoundary>
11241124
<PathnameContextProviderAdapter router={{sdc:{},sbc:{}, ...}} isAutoExport={true}>
11251125
<App pageProps={{}} Component={function Page} err={undefined} router={{sdc:{},sbc:{}, ...}}>
11261126
<Page>

0 commit comments

Comments
 (0)