Skip to content

Commit 24c480e

Browse files
[dev-overlay] Increase padding if no x button present (#76898)
Fixes lack of padding on the right if there is no `x` close button ![CleanShot 2025-03-07 at 14 11 57@2x](https://github.com/user-attachments/assets/2543855f-bb6b-4179-9e21-3808bc99e19b) After the changes: ![CleanShot 2025-03-07 at 14 12 33@2x](https://github.com/user-attachments/assets/c369963a-d621-4fc6-b6d6-fcf0888dca69) --- Closes DSN-756
1 parent 8ea354c commit 24c480e

File tree

3 files changed

+25
-6
lines changed

3 files changed

+25
-6
lines changed

packages/next/src/client/components/react-dev-overlay/ui/components/errors/dev-tools-indicator/next-logo.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,11 +190,12 @@ export const NextLogo = forwardRef(function NextLogo(
190190
}
191191
192192
[data-issues] {
193+
--padding-left: 8px;
193194
display: flex;
194195
gap: 2px;
195196
align-items: center;
196197
padding-left: 8px;
197-
padding-right: ${isBuildError ? '8px' : 'calc(2px * 2)'};
198+
padding-right: 8px;
198199
height: var(--size-32);
199200
margin: 0 2px;
200201
border-radius: var(--rounded-full);
@@ -204,6 +205,10 @@ export const NextLogo = forwardRef(function NextLogo(
204205
background: var(--color-hover-alpha-error);
205206
}
206207
208+
&:has([data-issues-collapse]) {
209+
padding-right: calc(var(--padding-left) / 2);
210+
}
211+
207212
[data-cross] {
208213
translate: 0px -1px;
209214
}

packages/next/src/client/components/react-dev-overlay/ui/dev-overlay.stories.tsx

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
import type { Meta, StoryObj } from '@storybook/react'
22
import type { OverlayState } from '../shared'
33

4+
// @ts-expect-error
5+
import imgApp from './app.png'
6+
47
import { useState } from 'react'
58
import { DevOverlay } from './dev-overlay'
69
import { ACTION_UNHANDLED_ERROR } from '../shared'
@@ -84,11 +87,22 @@ export const Default: Story = {
8487
render: function DevOverlayStory() {
8588
const [isErrorOverlayOpen, setIsErrorOverlayOpen] = useState(true)
8689
return (
87-
<DevOverlay
88-
state={state}
89-
isErrorOverlayOpen={isErrorOverlayOpen}
90-
setIsErrorOverlayOpen={setIsErrorOverlayOpen}
91-
/>
90+
<>
91+
<img
92+
src={imgApp}
93+
style={{
94+
width: '100%',
95+
height: '100%',
96+
objectFit: 'contain',
97+
filter: 'invert(1)',
98+
}}
99+
/>
100+
<DevOverlay
101+
state={state}
102+
isErrorOverlayOpen={isErrorOverlayOpen}
103+
setIsErrorOverlayOpen={setIsErrorOverlayOpen}
104+
/>
105+
</>
92106
)
93107
},
94108
}

0 commit comments

Comments
 (0)