Skip to content

Commit 68dade4

Browse files
authored
Turbopack: Remove old macos-compress script (#90967)
@wbinnssmith added these scripts a long time ago at my suggestion/urging, but I think they ended up bad for a couple reasons that were hard to foresee at the time: - afsctool operates in-place and doesn't atomically write the compressed file, so if the process gets interrupted, your `target` directory is corrupted. https://github.com/Dr-Emann/applesauce is better for this reason. - This doesn't acquire the cargo lock, and modifying files while cargo is running is a good way to get corruption of the `target` directory. https://github.com/bgw/cargo-apfs-compress is my latest attempt at solving this, though I don't have a `LaunchAgents` config for it. Regarding `node_modules`: pnpm creates reflinks from a shared global store on apfs. Trying to compress these reflinked files is just going to hurt you because it'll break the data deduplication that would've otherwise happened.
1 parent 2769b55 commit 68dade4

File tree

4 files changed

+0
-84
lines changed

4 files changed

+0
-84
lines changed

contributing/core/developing.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -180,17 +180,3 @@ pnpm sweep
180180
```
181181

182182
It will also clean up other caches (pnpm store, cargo, etc.) and run `git gc` for you.
183-
184-
### MacOS disk compression
185-
186-
If you want to automatically use APFS disk compression on macOS for `node_modules/` and `target/` you can install a launch agent with:
187-
188-
```bash
189-
./scripts/LaunchAgents/install-macos-agents.sh
190-
```
191-
192-
Or run it manually with:
193-
194-
```bash
195-
./scripts/macos-compress.sh
196-
```

scripts/LaunchAgents/build.turbo.compress.plist

Lines changed: 0 additions & 30 deletions
This file was deleted.

scripts/LaunchAgents/install-macos-agents.sh

Lines changed: 0 additions & 18 deletions
This file was deleted.

scripts/macos-compress.sh

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)