Skip to content

Commit 7bc8217

Browse files
committed
improve error messages
1 parent 738f42d commit 7bc8217

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

turbopack/crates/turbopack-nodejs/src/chunking_context.rs

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ use turbopack_core::{
2525
};
2626
use turbopack_ecmascript::{
2727
async_chunk::module::AsyncLoaderModule,
28-
chunk::EcmascriptChunk,
28+
chunk::{EcmascriptChunk, EcmascriptChunkPlaceable},
2929
manifest::{chunk_asset::ManifestAsyncModule, loader_module::ManifestLoaderModule},
3030
};
3131
use turbopack_ecmascript_runtime::RuntimeType;
@@ -578,16 +578,24 @@ impl ChunkingContext for NodeJsChunkingContext {
578578

579579
referenced_output_assets.extend(extra_referenced_assets.await?.iter().copied());
580580

581-
let Some(module) = ResolvedVc::try_sidecast(chunk_group.entries().last().unwrap())
581+
let module = chunk_group.entries().last().unwrap();
582+
let Some(module) =
583+
ResolvedVc::try_sidecast::<Box<dyn EcmascriptChunkPlaceable>>(module)
582584
else {
583-
bail!("module must be placeable in an ecmascript chunk");
585+
bail!("last entry must be EcmascriptChunkPlaceable {:?}", module);
584586
};
585587

586588
let evaluatable_assets = chunk_group
587589
.entries()
588590
.map(|entry| {
589-
ResolvedVc::try_sidecast::<Box<dyn EvaluatableAsset>>(entry)
590-
.context("entry_chunk_group entries must be evaluatable")
591+
ResolvedVc::try_sidecast::<Box<dyn EvaluatableAsset>>(entry).with_context(
592+
|| {
593+
format!(
594+
"entry_chunk_group entries must be EvaluatableAssets {:?}",
595+
entry
596+
)
597+
},
598+
)
591599
})
592600
.collect::<Result<Vec<_>>>()?;
593601

0 commit comments

Comments
 (0)