Skip to content

Commit be61804

Browse files
authored
chore(test): run unit tests on node 18 and 20 (#57199)
Since we separated unit tests into its own job in PR #55621, we can now run unit tests against Node.js 18 and Node.js 20 (maintenance and lts) using a matrix.
1 parent 1c5d778 commit be61804

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/build_and_test.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ on:
99
env:
1010
NAPI_CLI_VERSION: 2.14.7
1111
TURBO_VERSION: 1.10.9
12+
NODE_MAINTENANCE_VERSION: 18
1213
NODE_LTS_VERSION: 20
1314
TEST_CONCURRENCY: 8
1415
# disable backtrace for test snapshots
@@ -164,9 +165,12 @@ jobs:
164165
name: test unit
165166
strategy:
166167
fail-fast: false
168+
matrix:
169+
node: [18, 20] # TODO: use env var like [env.NODE_MAINTENANCE_VERSION, env.NODE_LTS_VERSION]
167170

168171
uses: ./.github/workflows/build_reusable.yml
169172
with:
173+
nodeVersion: ${{ matrix.node }}
170174
skipForDocsOnly: 'yes'
171175
afterBuild: node run-tests.js -c ${TEST_CONCURRENCY} --type unit
172176

0 commit comments

Comments
 (0)