Remove disable directives for temporarily disabled rules

Author: eps1lon

packages/next/src/next-devtools/dev-overlay/components/code-frame/code-frame.tsx

@@ -16,7 +16,6 @@ type CodeFrameProps = {
 }
 
 export function CodeFrame({ stackFrame, codeFrame }: CodeFrameProps) {
-  // eslint-disable-next-line react-hooks/preserve-manual-memoization -- compiler bug
   const parsedLineStates = useMemo(() => {
     const decodedLines = groupCodeFrameLines(formatCodeFrame(codeFrame))
 

packages/next/src/next-devtools/dev-overlay/components/devtools-indicator/hooks/use-minimum-loading-time-multiple.ts

@@ -31,7 +31,6 @@ export function useMinimumLoadingTimeMultiple(
       if (loadStartTimeRef.current === null) {
         loadStartTimeRef.current = Date.now()
       }
-      // eslint-disable-next-line react-hooks/set-state-in-effect -- TODO
       setIsLoading(true)
     } else {
       // If we're exiting the "loading" state:

packages/next/src/next-devtools/dev-overlay/components/devtools-indicator/hooks/use-update-animation.ts

@@ -19,7 +19,6 @@ export function useUpdateAnimation(
         return
       }
 
-      // eslint-disable-next-line react-hooks/set-state-in-effect -- TODO
       setAnimate(true)
       // It is important to use a CSS transitioned state, not a CSS keyframed animation
       // because if the issue count increases faster than the animation duration, it

packages/next/src/next-devtools/dev-overlay/components/devtools-panel/resize/resize-handle.tsx

@@ -76,7 +76,6 @@ export const ResizeHandle = ({
     const borderBottom = parseFloat(computedStyle.borderBottomWidth) || 0
     const borderLeft = parseFloat(computedStyle.borderLeftWidth) || 0
 
-    // eslint-disable-next-line react-hooks/set-state-in-effect -- TODO
     setBorderWidths({
       top: borderTop,
       right: borderRight,

packages/next/src/next-devtools/dev-overlay/components/errors/dev-tools-indicator/drag-context.tsx

@@ -40,7 +40,6 @@ export function DragProvider({
       register,
       unregister,
       handles:
-        // eslint-disable-next-line react-hooks/refs -- TODO
         handlesRef.current,
       disabled,
     }),

packages/next/src/next-devtools/dev-overlay/components/errors/error-message/error-message.tsx

@@ -13,7 +13,6 @@ export function ErrorMessage({ errorMessage }: ErrorMessageProps) {
 
   useLayoutEffect(() => {
     if (messageRef.current) {
-      // eslint-disable-next-line react-hooks/set-state-in-effect -- TODO
       setShouldTruncate(messageRef.current.scrollHeight > 200)
     }
   }, [errorMessage])

packages/next/src/next-devtools/dev-overlay/components/errors/error-overlay-call-stack/error-overlay-call-stack.tsx

@@ -37,7 +37,6 @@ export function ErrorOverlayCallStack({
         dialog!.removeEventListener('transitionend', onTransitionEnd)
         setIsIgnoreListOpen(false)
       }
-      // eslint-disable-next-line react-hooks/immutability -- Bug in react-hooks/react-compiler
       dialog.style.height = `${initialDialogHeight.current}px`
       dialog.addEventListener('transitionend', onTransitionEnd)
     } else {

packages/next/src/next-devtools/dev-overlay/components/overview/segment-boundary-trigger.tsx

@@ -44,7 +44,6 @@ export function SegmentBoundaryTrigger({
     () => {
       setIsOpen(false)
     },
-    // eslint-disable-next-line react-hooks/refs -- TODO
     triggerRef.current?.ownerDocument
   )
 

packages/next/src/next-devtools/dev-overlay/components/overview/segment-explorer.tsx

@@ -182,7 +182,6 @@ function PageSegmentTreeLayerPresentation({
   node: SegmentTrieNode
   level: number
 }) {
-  // eslint-disable-next-line react-hooks/preserve-manual-memoization
   const childrenKeys = useMemo(
     () => Object.keys(node.children),
     [node.children]
@@ -210,12 +209,7 @@ function PageSegmentTreeLayerPresentation({
     return (
       level === 0 && !existingBoundaries.includes(GLOBAL_ERROR_BOUNDARY_TYPE)
     )
-  }, [
-    node.children,
-    // eslint-disable-next-line react-hooks/preserve-manual-memoization -- it's not modified but dangerous to rely on disable directives. Talk to Compiler team once the other manual memo issues are fixed.
-    childrenKeys,
-    level,
-  ])
+  }, [node.children, childrenKeys, level])
 
   const sortedChildrenKeys = childrenKeys.sort((a, b) => {
     // Prioritize files with extensions over directories

packages/next/src/next-devtools/dev-overlay/components/terminal/terminal.tsx

@@ -61,23 +61,18 @@ function getEditorLinks(content: string) {
 export const Terminal: React.FC<TerminalProps> = function Terminal({
   content,
 }) {
-  // eslint-disable-next-line react-hooks/preserve-manual-memoization -- compiler bug
   const { file, source, importTraceFiles } = React.useMemo(
     () => getEditorLinks(content),
     [content]
   )
 
-  // eslint-disable-next-line react-hooks/preserve-manual-memoization -- compiler bug
   const decoded = React.useMemo(() => {
     return Anser.ansiToJson(source, {
       json: true,
       use_classes: true,
       remove_empty: true,
     })
-  }, [
-    // eslint-disable-next-line react-hooks/preserve-manual-memoization -- it's not modified but dangerous to rely on disable directives. Talk to Compiler team once the other manual memo issues are fixed.
-    source,
-  ])
+  }, [source])
 
   const open = useOpenInEditor({
     file: file?.fileName,