Skip to content

Commit e1b8c00

Browse files
authored
[eslint-plugin] Remove eslint-v8 testing (#84721)
ESLint plugin defaults to flat config, and we also dropped the built-in lint check at #83136, so we can sunset the deprecated ESLint v8 testing.
1 parent 4614b00 commit e1b8c00

23 files changed

+310
-695
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,6 @@
200200
"eslint-plugin-mdx": "3.1.5",
201201
"eslint-plugin-react": "7.35.0",
202202
"eslint-plugin-react-hooks": "0.0.0-experimental-3025aa39-20251007",
203-
"eslint-v8": "npm:eslint@^8.57.0",
204203
"event-stream": "4.0.1",
205204
"execa": "2.0.3",
206205
"expect": "29.7.0",

pnpm-lock.yaml

Lines changed: 0 additions & 104 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/unit/eslint-plugin-next/google-font-display.test.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { RuleTester as ESLintTesterV8 } from 'eslint-v8'
2-
import { RuleTester as ESLintTesterV9 } from 'eslint'
1+
import { RuleTester } from 'eslint'
32
import { rules } from '@next/eslint-plugin-next'
43

54
const NextESLintRule = rules['google-font-display']
@@ -164,18 +163,7 @@ const tests = {
164163
}
165164

166165
describe('google-font-display', () => {
167-
new ESLintTesterV8({
168-
parserOptions: {
169-
ecmaVersion: 2020,
170-
sourceType: 'module',
171-
ecmaFeatures: {
172-
modules: true,
173-
jsx: true,
174-
},
175-
},
176-
}).run('eslint-v8', NextESLintRule, tests)
177-
178-
new ESLintTesterV9({
166+
new RuleTester({
179167
languageOptions: {
180168
ecmaVersion: 2020,
181169
sourceType: 'module',
@@ -186,5 +174,5 @@ describe('google-font-display', () => {
186174
},
187175
},
188176
},
189-
}).run('eslint-v9', NextESLintRule, tests)
177+
}).run('eslint', NextESLintRule, tests)
190178
})

test/unit/eslint-plugin-next/google-font-preconnect.test.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { RuleTester as ESLintTesterV8 } from 'eslint-v8'
2-
import { RuleTester as ESLintTesterV9 } from 'eslint'
1+
import { RuleTester } from 'eslint'
32
import { rules } from '@next/eslint-plugin-next'
43

54
const NextESLintRule = rules['google-font-preconnect']
@@ -59,18 +58,7 @@ const tests = {
5958
}
6059

6160
describe('google-font-preconnect', () => {
62-
new ESLintTesterV8({
63-
parserOptions: {
64-
ecmaVersion: 2020,
65-
sourceType: 'module',
66-
ecmaFeatures: {
67-
modules: true,
68-
jsx: true,
69-
},
70-
},
71-
}).run('eslint-v8', NextESLintRule, tests)
72-
73-
new ESLintTesterV9({
61+
new RuleTester({
7462
languageOptions: {
7563
ecmaVersion: 2020,
7664
sourceType: 'module',
@@ -81,5 +69,5 @@ describe('google-font-preconnect', () => {
8169
},
8270
},
8371
},
84-
}).run('eslint-v9', NextESLintRule, tests)
72+
}).run('eslint', NextESLintRule, tests)
8573
})

test/unit/eslint-plugin-next/inline-script-id.test.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { RuleTester as ESLintTesterV8 } from 'eslint-v8'
2-
import { RuleTester as ESLintTesterV9 } from 'eslint'
1+
import { RuleTester } from 'eslint'
32
import { rules } from '@next/eslint-plugin-next'
43

54
const NextESLintRule = rules['inline-script-id']
@@ -179,18 +178,7 @@ const tests = {
179178
}
180179

181180
describe('inline-script-id', () => {
182-
new ESLintTesterV8({
183-
parserOptions: {
184-
ecmaVersion: 2018,
185-
sourceType: 'module',
186-
ecmaFeatures: {
187-
modules: true,
188-
jsx: true,
189-
},
190-
},
191-
}).run('eslint-v8', NextESLintRule, tests)
192-
193-
new ESLintTesterV9({
181+
new RuleTester({
194182
languageOptions: {
195183
ecmaVersion: 2018,
196184
sourceType: 'module',
@@ -201,5 +189,5 @@ describe('inline-script-id', () => {
201189
},
202190
},
203191
},
204-
}).run('eslint-v9', NextESLintRule, tests)
192+
}).run('eslint', NextESLintRule, tests)
205193
})

test/unit/eslint-plugin-next/next-script-for-ga.test.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { RuleTester as ESLintTesterV8 } from 'eslint-v8'
2-
import { RuleTester as ESLintTesterV9 } from 'eslint'
1+
import { RuleTester } from 'eslint'
32
import { rules } from '@next/eslint-plugin-next'
43

54
const NextESLintRule = rules['next-script-for-ga']
@@ -232,18 +231,7 @@ const tests = {
232231
}
233232

234233
describe('next-script-for-ga', () => {
235-
new ESLintTesterV8({
236-
parserOptions: {
237-
ecmaVersion: 2018,
238-
sourceType: 'module',
239-
ecmaFeatures: {
240-
modules: true,
241-
jsx: true,
242-
},
243-
},
244-
}).run('eslint-v8', NextESLintRule, tests)
245-
246-
new ESLintTesterV9({
234+
new RuleTester({
247235
languageOptions: {
248236
ecmaVersion: 2018,
249237
sourceType: 'module',
@@ -254,5 +242,5 @@ describe('next-script-for-ga', () => {
254242
},
255243
},
256244
},
257-
}).run('eslint-v9', NextESLintRule, tests)
245+
}).run('eslint', NextESLintRule, tests)
258246
})

test/unit/eslint-plugin-next/no-assign-module-variable.test.ts

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
import { RuleTester as ESLintTesterV8 } from 'eslint-v8'
2-
import { RuleTester as ESLintTesterV9 } from 'eslint'
1+
import { RuleTester } from 'eslint'
32
import { rules } from '@next/eslint-plugin-next'
43

54
const NextESLintRule = rules['no-assign-module-variable']
@@ -34,18 +33,7 @@ const tests = {
3433
}
3534

3635
describe('no-assign-module-variable', () => {
37-
new ESLintTesterV8({
38-
parserOptions: {
39-
ecmaVersion: 2018,
40-
sourceType: 'module',
41-
ecmaFeatures: {
42-
modules: true,
43-
jsx: true,
44-
},
45-
},
46-
}).run('eslint-v8', NextESLintRule, tests)
47-
48-
new ESLintTesterV9({
36+
new RuleTester({
4937
languageOptions: {
5038
ecmaVersion: 2018,
5139
sourceType: 'module',
@@ -56,5 +44,5 @@ describe('no-assign-module-variable', () => {
5644
},
5745
},
5846
},
59-
}).run('eslint-v9', NextESLintRule, tests)
47+
}).run('eslint', NextESLintRule, tests)
6048
})

0 commit comments

Comments
 (0)