You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During next build, the "Checking validity of types" phase should respect the typescript.tsconfigPath in next.config.js
Non-Goals
No response
Background
I maintain several tsconfig files. One of them is tsconfig.json which includes all the source code (production code, tests, development scripts, etc). Another one is tsconfig.build.json, which only excludes files that aren't relevant for the build phase. tsconfig.json has to include everything so that vscode properly handles the tests and tools. I was happy to learn about typescript.tsconfigPath, but then surprised to find that CI failed in the "Checking validity of types" phase of next build because our CI pipeline doesn't install the optionalDependencies.
Proposal
Pass the typescript.tsconfigPath to the type checking phase too.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Goals
During
next build
, the "Checking validity of types" phase should respect thetypescript.tsconfigPath
innext.config.js
Non-Goals
No response
Background
I maintain several tsconfig files. One of them is
tsconfig.json
which includes all the source code (production code, tests, development scripts, etc). Another one istsconfig.build.json
, which only excludes files that aren't relevant for the build phase.tsconfig.json
has to include everything so that vscode properly handles the tests and tools. I was happy to learn abouttypescript.tsconfigPath
, but then surprised to find that CI failed in the "Checking validity of types" phase ofnext build
because our CI pipeline doesn't install theoptionalDependencies
.Proposal
Pass the
typescript.tsconfigPath
to the type checking phase too.Beta Was this translation helpful? Give feedback.
All reactions