Apply server actions transform to node_modules in route handlers#89316
Merged
unstubbable merged 1 commit intocanaryfrom Jan 30, 2026
Merged
Conversation
The server actions transform, which handles the `'use cache'` directive, was not being applied to `node_modules` when imported from route handlers. This caused `'use cache'` functions from dependencies to fail with errors like `"cacheLife() can only be called inside a 'use cache' function"``. The issue was that the `AppRoute` context used `internal_custom_rules` for its foreign code module options, which did not include the server actions transform. This is inconsistent with `AppRSC` (App Router pages), which correctly uses `foreign_next_server_rules` that includes the transform. The fix extends `foreign_next_server_rules` with `internal_custom_rules` and uses it for the foreign code context in `AppRoute`, matching the pattern used by `AppRSC`.
nextjs-bot
added
created-by: Next.js team
Collaborator
Tests Passed |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **435 kB** → **435 kB** ✓81 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
mischnic
reviewed
Jan 30, 2026
| internal_custom_rules.extend(common_next_server_rules); | ||
|
|
||
| next_server_rules.extend(source_transform_rules); | ||
| foreign_next_server_rules.extend(internal_custom_rules.clone()); |
Member
There was a problem hiding this comment.
Is that actually necessary? sounds odd to run the internal rules on all of node_modules?
Contributor
Author
There was a problem hiding this comment.
It's not necessary for this fix, but it matches what we're doing for the other types: Pages, PagesApi, AppSSR, and AppRSC.
Contributor
Author
There was a problem hiding this comment.
It's identical to foreign_next_server_rules.extend(common_next_server_rules) in this case, because internal_custom_rules is empty for AppRoute.
mischnic
approved these changes
Jan 30, 2026
unstubbable
deleted the
hl/route-handler-generate-static-params-use-cache
branch
unstubbable
added a commit
that referenced
this pull request
Feb 2, 2026
…89316) The server actions transform, which handles the `'use cache'` directive, was not being applied to `node_modules` when imported from route handlers. This caused `'use cache'` functions from dependencies to fail with errors like `"cacheLife() can only be called inside a 'use cache' function"``. The issue was that the `AppRoute` context used `internal_custom_rules` for its foreign code module options, which did not include the server actions transform. This is inconsistent with `AppRSC` (App Router pages), which correctly uses `foreign_next_server_rules` that includes the transform. The fix extends `foreign_next_server_rules` with `internal_custom_rules` and uses it for the foreign code context in `AppRoute`, matching the pattern used by `AppRSC`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server actions transform, which handles the
'use cache'directive, was not being applied tonode_moduleswhen imported from route handlers. This caused'use cache'functions from dependencies to fail with errors like `"cacheLife() can only be called inside a 'use cache' function"``.The issue was that the
AppRoutecontext usedinternal_custom_rulesfor its foreign code module options, which did not include the server actions transform. This is inconsistent withAppRSC(App Router pages), which correctly usesforeign_next_server_rulesthat includes the transform.The fix extends
foreign_next_server_ruleswithinternal_custom_rulesand uses it for the foreign code context inAppRoute, matching the pattern used byAppRSC.