perf: optimize splitCookiesString with charCode checks#91564
Open
benfavre wants to merge 2 commits intovercel:canaryfrom
Open
perf: optimize splitCookiesString with charCode checks#91564benfavre wants to merge 2 commits intovercel:canaryfrom
benfavre wants to merge 2 commits intovercel:canaryfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Adds charCode 11 (vertical tab) that the original /\s/ regex matched, fixing a behavioral regression.
Contributor
Author
Test Verification
All tests run on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize
splitCookiesStringinpackages/next/src/server/web/utils.tsby replacing per-character regex matching with integer charCode comparisons.Problem
The
skipWhitespace()helper creates a/\s/regex on every call and usescharAt()which allocates a single-character string. This function is called in a tight character-scanning loop for every cookie header on every request.Changes
/\s/.test(cookiesString.charAt(pos))withisWhitespace(cookiesString.charCodeAt(pos))using a simple integer comparison helpercharAt()comparisons innotSpecialChar()and the main loop withcharCodeAt()integer comparisonsWhy this matters
Inspired by TanStack Start's 5.5x SSR throughput: hot-path micro-optimizations compound. Regex creation and string allocation in tight loops are exactly the kind of overhead that adds up across thousands of requests.
Test plan
🤖 Generated with Claude Code