fix: place image preload links in <head> instead of <body>#91878
Open
tmoh-figs wants to merge 1 commit intovercel:canaryfrom
Open
fix: place image preload links in <head> instead of <body>#91878tmoh-figs wants to merge 1 commit intovercel:canaryfrom
<head> instead of <body>#91878tmoh-figs wants to merge 1 commit intovercel:canaryfrom
Conversation
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
tmoh-figs
force-pushed
the
tmoh/fix-image-preload-srcset
branch
from
5a3d045 to
2c7b88a
Compare
Author
|
@naaa760 @ijjk @nehaaprasad This is an updated version of #82263 which was never merged. |
tmoh-figs
changed the title
<head> instead of <body>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82254.
React 19 + Next.js 15 incorrectly place image preload links in the
<body>rather than the<head>while using the Pages router.Changes
ImagePreloadcomponent to useReactDOM.preloadfor both App Router and Pages router when available, instead of relying on<Head>component which had placement issues.Reproducing
The old issue was reproduced in this StackBlitz instance: https://stackblitz.com/edit/stackblitz-starters-evf7wdnm?file=pages/pages-router.tsx
If someone can approve the CI, we can point the stackblitz instance at the preview instance.