diff --git a/packages/next/src/client/components/react-dev-overlay/pages/hooks.ts b/packages/next/src/client/components/react-dev-overlay/pages/hooks.ts index d222fea6b60939..38d6fdcc03d35c 100644 --- a/packages/next/src/client/components/react-dev-overlay/pages/hooks.ts +++ b/packages/next/src/client/components/react-dev-overlay/pages/hooks.ts @@ -27,16 +27,8 @@ export const usePagesDevOverlay = () => { } }, [dispatch]) - const onComponentError = React.useCallback( - (_error: Error, _componentStack: string | null) => { - // TODO: special handling - }, - [] - ) - return { state, - onComponentError, dispatch, } } diff --git a/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx b/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx index a7b11474b5b4dc..7117d00d47b85a 100644 --- a/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx +++ b/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx @@ -2,7 +2,6 @@ import React from 'react' type PagesDevOverlayErrorBoundaryProps = { children?: React.ReactNode - onError: (error: Error, componentStack: string | null) => void } type PagesDevOverlayErrorBoundaryState = { error: Error | null } @@ -16,13 +15,7 @@ export class PagesDevOverlayErrorBoundary extends React.PureComponent< return { error } } - componentDidCatch( - error: Error, - // Loosely typed because it depends on the React version and was - // accidentally excluded in some versions. - errorInfo?: { componentStack?: string | null } - ) { - this.props.onError(error, errorInfo?.componentStack || null) + componentDidCatch(error: Error) { this.setState({ error }) } diff --git a/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx b/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx index 5709bd316ad593..935f3cbf174d9e 100644 --- a/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx +++ b/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx @@ -13,11 +13,11 @@ interface PagesDevOverlayProps { } export function PagesDevOverlay({ children }: PagesDevOverlayProps) { - const { state, dispatch, onComponentError } = usePagesDevOverlay() + const { state, dispatch } = usePagesDevOverlay() return ( <> - + {children ?? null} diff --git a/test/development/acceptance/hydration-error.test.ts b/test/development/acceptance/hydration-error.test.ts index f09034ad8a8e3d..ba8014be16240f 100644 --- a/test/development/acceptance/hydration-error.test.ts +++ b/test/development/acceptance/hydration-error.test.ts @@ -105,7 +105,7 @@ describe('Error overlay for hydration errors in Pages router', () => { - + @@ -211,7 +211,7 @@ describe('Error overlay for hydration errors in Pages router', () => { - + @@ -302,7 +302,7 @@ describe('Error overlay for hydration errors in Pages router', () => { - + @@ -378,7 +378,7 @@ describe('Error overlay for hydration errors in Pages router', () => { - + @@ -449,7 +449,7 @@ describe('Error overlay for hydration errors in Pages router', () => { - + @@ -539,7 +539,7 @@ describe('Error overlay for hydration errors in Pages router', () => { "componentStack": "... - + @@ -628,7 +628,7 @@ describe('Error overlay for hydration errors in Pages router', () => { - + @@ -722,7 +722,7 @@ describe('Error overlay for hydration errors in Pages router', () => { { "componentStack": "... - + @@ -846,7 +846,7 @@ describe('Error overlay for hydration errors in Pages router', () => { - + @@ -940,7 +940,7 @@ describe('Error overlay for hydration errors in Pages router', () => { "componentStack": "... - + @@ -1026,7 +1026,7 @@ describe('Error overlay for hydration errors in Pages router', () => { - + @@ -1120,7 +1120,7 @@ describe('Error overlay for hydration errors in Pages router', () => { - +