-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Closed
Labels
kind: bugSomething isn't workingSomething isn't working
Description
Verify canary release
- I verified that the issue exists in the latest Turborepo canary release.
Link to code that reproduces this issue
https://github.com/olsonpm/repro/tree/turborepo-update-notifier
Which canary version will you have in your reproduction?
canary is not applicable here
Environment information
• turbo 2.7.4
CLI:
Version: 2.7.4
Path to executable: /home/phil/garbage/delme/repro/node_modules/.pnpm/turbo-linux-64@2.7.4/node_modules/turbo-linux-64/bin/turbo
Daemon status: Running
Package manager: pnpm9
Platform:
Architecture: x86_64
Operating system: linux
WSL: false
Available memory (MB): 22614
Available CPU cores: 8
Environment:
CI: None
Terminal (TERM): xterm-kitty
Terminal program (TERM_PROGRAM): unknown
Terminal program version (TERM_PROGRAM_VERSION): unknown
Shell (SHELL): /bin/zsh
stdin: false
Expected behavior
the update notifier shouldn't show
Actual behavior
the update notifier shows
To Reproduce
> git clone -b turborepo-update-notifier git@github.com:olsonpm/repro.git
> cd repro
> pnpm install --frozen-lockfile
> pnpm turbo build
# confirm update notifier still shows even though turbo.json has
# `"noUpdateNotifier": true`Additional context
- the template used is from
pnpx create-turbo@canary -e with-shell-commands, selecting pnpm - I tested against each 2.7.x patch version prior to 2.7.5, they all exhibit the issue
- the cli flag
--no-update-notifierand env varTURBO_NO_UPDATE_NOTIFIER=truestill work - this recent PR apparently fixed a similar issue and its commit is present in the 2.7.4 tag, so the bug I'm seeing must be something else.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind: bugSomething isn't workingSomething isn't working