Skip to content

Commit 69042df

Browse files
pranaygpclaude
pranaygp
and
claude
committed
refactor: extract queue trigger configuration constants
Consolidates duplicated queue trigger configurations into shared constants in @workflow/builders package, eliminating repetition across multiple builders. Changes: - Created STEP_QUEUE_TRIGGER and WORKFLOW_QUEUE_TRIGGER constants - Updated VercelBuildOutputAPIBuilder to use shared constants - Updated NextBuilder (both in @workflow/next and @workflow/cli) to use constants - Exported constants from @workflow/builders index This ensures consistent queue configuration across all builders and makes future updates to these settings easier to manage from a single location. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent dae68ac commit 69042df

File tree

5 files changed

+49
-83
lines changed

5 files changed

+49
-83
lines changed

‎packages/builders/src/constants.ts‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
/**
2+
* Queue trigger configuration for workflow step execution.
3+
* Steps are queued to the __wkf_step_* topic.
4+
*/
5+
export const STEP_QUEUE_TRIGGER = {
6+
type: 'queue/v1beta' as const,
7+
topic: '__wkf_step_*',
8+
consumer: 'default',
9+
maxDeliveries: 64, // Maximum number of delivery attempts (default: 3)
10+
retryAfterSeconds: 5, // Delay between retries (default: 60)
11+
initialDelaySeconds: 0, // Initial delay before first delivery (default: 0)
12+
};
13+
14+
/**
15+
* Queue trigger configuration for workflow orchestration.
16+
* Workflows are queued to the __wkf_workflow_* topic.
17+
*/
18+
export const WORKFLOW_QUEUE_TRIGGER = {
19+
type: 'queue/v1beta' as const,
20+
topic: '__wkf_workflow_*',
21+
consumer: 'default',
22+
maxDeliveries: 64, // Maximum number of delivery attempts (default: 3)
23+
retryAfterSeconds: 5, // Delay between retries (default: 60)
24+
initialDelaySeconds: 0, // Initial delay before first delivery (default: 0)
25+
};

‎packages/builders/src/vercel-build-output-api.ts‎

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import { mkdir, writeFile } from 'node:fs/promises';
22
import { join, resolve } from 'node:path';
33
import { BaseBuilder } from './base-builder.js';
4+
import { STEP_QUEUE_TRIGGER, WORKFLOW_QUEUE_TRIGGER } from './constants.js';
45

56
export class VercelBuildOutputAPIBuilder extends BaseBuilder {
67
async build(): Promise<void> {
@@ -67,16 +68,7 @@ export class VercelBuildOutputAPIBuilder extends BaseBuilder {
6768
architecture: 'arm64',
6869
shouldAddHelpers: true,
6970
shouldAddSourcemapSupport: true,
70-
experimentalTriggers: [
71-
{
72-
type: 'queue/v1beta',
73-
topic: '__wkf_step_*',
74-
consumer: 'default',
75-
maxDeliveries: 64, // Optional: Maximum number of delivery attempts (default: 3)
76-
retryAfterSeconds: 5, // Optional: Delay between retries (default: 60)
77-
initialDelaySeconds: 0, // Optional: Initial delay before first delivery (default: 0)
78-
},
79-
],
71+
experimentalTriggers: [STEP_QUEUE_TRIGGER],
8072
};
8173

8274
await writeFile(
@@ -123,16 +115,7 @@ export class VercelBuildOutputAPIBuilder extends BaseBuilder {
123115
launcherType: 'Nodejs',
124116
architecture: 'arm64',
125117
shouldAddHelpers: true,
126-
experimentalTriggers: [
127-
{
128-
type: 'queue/v1beta',
129-
topic: '__wkf_workflow_*',
130-
consumer: 'default',
131-
maxDeliveries: 64, // Optional: Maximum number of delivery attempts (default: 3)
132-
retryAfterSeconds: 5, // Optional: Delay between retries (default: 60)
133-
initialDelaySeconds: 0, // Optional: Initial delay before first delivery (default: 0)
134-
},
135-
],
118+
experimentalTriggers: [WORKFLOW_QUEUE_TRIGGER],
136119
};
137120

138121
await writeFile(

‎packages/cli/src/lib/builders/next-build.ts‎

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@ import { constants } from 'node:fs';
22
import { access, mkdir, stat, writeFile } from 'node:fs/promises';
33
import { extname, join, resolve } from 'node:path';
44
import Watchpack from 'watchpack';
5-
import { BaseBuilder } from '@workflow/builders';
5+
import {
6+
BaseBuilder,
7+
STEP_QUEUE_TRIGGER,
8+
WORKFLOW_QUEUE_TRIGGER,
9+
} from '@workflow/builders';
610

711
export class NextBuilder extends BaseBuilder {
812
async build() {
@@ -333,28 +337,10 @@ export class NextBuilder extends BaseBuilder {
333337
const generatedConfig = {
334338
version: '0',
335339
steps: {
336-
experimentalTriggers: [
337-
{
338-
type: 'queue/v1beta',
339-
topic: '__wkf_step_*',
340-
consumer: 'default',
341-
maxDeliveries: 64,
342-
retryAfterSeconds: 5,
343-
initialDelaySeconds: 0,
344-
},
345-
],
340+
experimentalTriggers: [STEP_QUEUE_TRIGGER],
346341
},
347342
workflows: {
348-
experimentalTriggers: [
349-
{
350-
type: 'queue/v1beta',
351-
topic: '__wkf_workflow_*',
352-
consumer: 'default',
353-
maxDeliveries: 64,
354-
retryAfterSeconds: 5,
355-
initialDelaySeconds: 0,
356-
},
357-
],
343+
experimentalTriggers: [WORKFLOW_QUEUE_TRIGGER],
358344
},
359345
};
360346

‎packages/cli/src/lib/builders/vercel-build-output-api.ts‎

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import { mkdir, writeFile } from 'node:fs/promises';
22
import { join, resolve } from 'node:path';
3-
import { BaseBuilder } from '@workflow/builders';
3+
import {
4+
BaseBuilder,
5+
STEP_QUEUE_TRIGGER,
6+
WORKFLOW_QUEUE_TRIGGER,
7+
} from '@workflow/builders';
48

59
export class VercelBuildOutputAPIBuilder extends BaseBuilder {
610
async build(): Promise<void> {
@@ -67,16 +71,7 @@ export class VercelBuildOutputAPIBuilder extends BaseBuilder {
6771
architecture: 'arm64',
6872
shouldAddHelpers: true,
6973
shouldAddSourcemapSupport: true,
70-
experimentalTriggers: [
71-
{
72-
type: 'queue/v1beta',
73-
topic: '__wkf_step_*',
74-
consumer: 'default',
75-
maxDeliveries: 64, // Optional: Maximum number of delivery attempts (default: 3)
76-
retryAfterSeconds: 5, // Optional: Delay between retries (default: 60)
77-
initialDelaySeconds: 0, // Optional: Initial delay before first delivery (default: 0)
78-
},
79-
],
74+
experimentalTriggers: [STEP_QUEUE_TRIGGER],
8075
};
8176

8277
await writeFile(
@@ -123,16 +118,7 @@ export class VercelBuildOutputAPIBuilder extends BaseBuilder {
123118
launcherType: 'Nodejs',
124119
architecture: 'arm64',
125120
shouldAddHelpers: true,
126-
experimentalTriggers: [
127-
{
128-
type: 'queue/v1beta',
129-
topic: '__wkf_workflow_*',
130-
consumer: 'default',
131-
maxDeliveries: 64, // Optional: Maximum number of delivery attempts (default: 3)
132-
retryAfterSeconds: 5, // Optional: Delay between retries (default: 60)
133-
initialDelaySeconds: 0, // Optional: Initial delay before first delivery (default: 0)
134-
},
135-
],
121+
experimentalTriggers: [WORKFLOW_QUEUE_TRIGGER],
136122
};
137123

138124
await writeFile(

‎packages/next/src/next-builder.ts‎

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,11 @@ import { constants } from 'node:fs';
22
import { access, mkdir, stat, writeFile } from 'node:fs/promises';
33
import { extname, join, resolve } from 'node:path';
44
import Watchpack from 'watchpack';
5-
import { BaseBuilder } from '@workflow/builders';
5+
import {
6+
BaseBuilder,
7+
STEP_QUEUE_TRIGGER,
8+
WORKFLOW_QUEUE_TRIGGER,
9+
} from '@workflow/builders';
610

711
export class NextBuilder extends BaseBuilder {
812
async build() {
@@ -333,28 +337,10 @@ export class NextBuilder extends BaseBuilder {
333337
const generatedConfig = {
334338
version: '0',
335339
steps: {
336-
experimentalTriggers: [
337-
{
338-
type: 'queue/v1beta',
339-
topic: '__wkf_step_*',
340-
consumer: 'default',
341-
maxDeliveries: 64,
342-
retryAfterSeconds: 5,
343-
initialDelaySeconds: 0,
344-
},
345-
],
340+
experimentalTriggers: [STEP_QUEUE_TRIGGER],
346341
},
347342
workflows: {
348-
experimentalTriggers: [
349-
{
350-
type: 'queue/v1beta',
351-
topic: '__wkf_workflow_*',
352-
consumer: 'default',
353-
maxDeliveries: 64,
354-
retryAfterSeconds: 5,
355-
initialDelaySeconds: 0,
356-
},
357-
],
343+
experimentalTriggers: [WORKFLOW_QUEUE_TRIGGER],
358344
},
359345
};
360346

0 commit comments

Comments
 (0)