more

Author: ibc

worker/include/RTC/SCTP/Chunk.hpp

@@ -65,7 +65,7 @@ namespace RTC
 			};
 
 		public:
-			static const size_t HeaderSize{ 4 };
+			static const size_t HeaderLength{ 4 };
 
 			/**
 			 * Parses given `data` with length `len` and returns an allocated instance
@@ -131,7 +131,7 @@ namespace RTC
 			 */
 			uint16_t GetValueLength() const
 			{
-				return uint16_t{ ntohs(this->header->length) } - HeaderSize;
+				return uint16_t{ ntohs(this->header->length) } - Chunk::HeaderLength;
 			}
 
 		private:

worker/include/RTC/SCTP/Packet.hpp

@@ -137,6 +137,8 @@ namespace RTC
 
 			// void AddChunk(Chunk* chunk)
 			// {
+			// AssertNotFrozen();
+			//
 			// 	this->chunks.push_back(chunk);
 			// }
 
@@ -155,6 +157,11 @@ namespace RTC
 				return GetBuffer() + Packet::CommonHeaderLength;
 			}
 
+			virtual const uint8_t* GetEndPointer() const final
+			{
+				return GetBuffer() + GetBufferLength();
+			}
+
 			/**
 			 * Must be used within Parse() static method (instead than AddChunk()).
 			 * This method doesn't serializa the given Chunk into Packet's buffer

worker/src/RTC/SCTP/Chunk.cpp

@@ -40,7 +40,7 @@ namespace RTC
 			MS_TRACE();
 
 			// Ensure there are at least 4 bytes (chunk value is zero-length).
-			if (len < HeaderSize)
+			if (len < Chunk::HeaderLength)
 			{
 				MS_WARN_TAG(sctp, "not an SCTP chunk");
 
@@ -53,8 +53,8 @@ namespace RTC
 			// incremented to point to other parts of the chunk.
 			auto* ptr = const_cast<uint8_t*>(data);
 
-			// Inspect data after the header size, so move to the chunk value.
-			ptr += HeaderSize;
+			// Inspect data after the header length, so move to the chunk value.
+			ptr += Chunk::HeaderLength;
 
 			auto valueLengthWithPadding = Utils::Byte::PadTo4Bytes(chunk->GetValueLength());