more

Author: ibc

worker/include/RTC/SCTP/Packet.hpp

@@ -187,7 +187,7 @@ namespace RTC
 			void AddChunk(const Chunk* chunk);
 
 		private:
-			virtual void InitializeHeader() final;
+			void InitializeHeader();
 
 			/**
 			 * NOTE: Return CommonHeader* instead of const CommonHeader* since we may
@@ -198,14 +198,9 @@ namespace RTC
 				return reinterpret_cast<CommonHeader*>(const_cast<uint8_t*>(GetBuffer()));
 			}
 
-			const uint8_t* GetChunksPointer() const
+			uint8_t* GetChunksPointer() const
 			{
-				return GetBuffer() + Packet::CommonHeaderLength;
-			}
-
-			virtual uint8_t* GetEndPointer() const final
-			{
-				return const_cast<uint8_t*>(GetBuffer()) + GetLength();
+				return const_cast<uint8_t*>(GetBuffer()) + Packet::CommonHeaderLength;
 			}
 
 			/**

worker/src/RTC/SCTP/Packet.cpp

@@ -292,7 +292,8 @@ namespace RTC
 			size_t length = GetLength() + chunk->GetLength();
 
 			// Let's append the chunk at the end of existing chunks.
-			auto* clonedChunk = chunk->Clone(GetEndPointer(), chunk->GetLength());
+			auto* clonedChunk =
+			  chunk->Clone(const_cast<uint8_t*>(GetBuffer()) + GetLength(), chunk->GetLength());
 
 			// Freeze the cloned chunk.
 			clonedChunk->Freeze();

worker/test/include/RTC/TestSerializable/FooItem.hpp

@@ -166,19 +166,10 @@ class FooItem : public Serializable
 		GetHeaderPointer()->valueLength = valueLength;
 	}
 
-	/**
-	 * NOTE: Return uint8_t* instead of const uint8_t* since we may want to
-	 * modify its value.
-	 */
 	virtual uint8_t* GetValuePointer() const final
 	{
 		return const_cast<uint8_t*>(GetBuffer()) + FooItem::ItemHeaderLength;
 	}
-
-	virtual uint8_t* GetEndPointer() const final
-	{
-		return const_cast<uint8_t*>(GetBuffer()) + FooItem::ItemHeaderLength + GetValueLength();
-	}
 };
 
 #endif

worker/test/include/RTC/TestSerializable/FooPacket.hpp

@@ -187,12 +187,8 @@ class FooPacket : public Serializable
 	void AddTextItem(uint8_t flags, const std::string& text);
 
 private:
-	virtual void InitializeHeader(uint8_t type, uint16_t length) final;
+	void InitializeHeader(uint8_t type, uint16_t length);
 
-	/**
-	 * NOTE: Return Header* instead of const Header* since we may want to
-	 * modify its fields.
-	 */
 	Header* GetHeaderPointer() const
 	{
 		return reinterpret_cast<Header*>(const_cast<uint8_t*>(GetBuffer()));