improve C++ namespacs in tests

Author: ibc

worker/src/RTC/Serializable.cpp

@@ -8,6 +8,12 @@
 
 namespace RTC
 {
+	Serializable::Serializable(const uint8_t* buffer, size_t bufferLength)
+	  : buffer(const_cast<uint8_t*>(buffer)), bufferLength(bufferLength)
+	{
+		MS_TRACE();
+	}
+
 	void Serializable::Serialize(uint8_t* buffer, size_t bufferLength)
 	{
 		MS_TRACE();

worker/test/include/RTC/SCTP/common.hpp

@@ -15,15 +15,21 @@
 
 using namespace RTC::SCTP;
 
-// NOTE: We need to declare them here with `extern` and then define them in
-// helpers.cpp.
-extern thread_local uint8_t FactoryBuffer[66661];
-extern thread_local uint8_t SerializeBuffer[66662];
-extern thread_local uint8_t CloneBuffer[66663];
-extern thread_local uint8_t DataBuffer[66664];
-extern thread_local uint8_t ThrowBuffer[66665];
+namespace RTC
+{
+	namespace SCTP
+	{
+		// NOTE: We need to declare them here with `extern` and then define them in
+		// common.cpp.
+		extern thread_local uint8_t FactoryBuffer[66661];
+		extern thread_local uint8_t SerializeBuffer[66662];
+		extern thread_local uint8_t CloneBuffer[66663];
+		extern thread_local uint8_t DataBuffer[66664];
+		extern thread_local uint8_t ThrowBuffer[66665];
 
-void ResetBuffers();
+		void ResetBuffers();
+	} // namespace SCTP
+} // namespace RTC
 
 // clang-format off
 // NOLINTNEXTLINE (cppcoreguidelines-macro-usage)
@@ -37,7 +43,7 @@ void ResetBuffers();
   /*uint16_t*/ destinationPort,                                                                    \
   /*uint32_t*/ verificationTag,                                                                    \
   /*uint32_t*/ checksum,                                                                           \
-  /*hasValidCrc32cChecksum*/ hasValidCrc32cChecksum,                                               \
+  /*bool*/ hasValidCrc32cChecksum,                                               \
   /*size_t*/ chunksCount)                                                                          \
 	do                                                                                               \
 	{                                                                                                \

worker/test/include/helpers.hpp

@@ -26,6 +26,7 @@ namespace helpers
 	  size_t* len);
 
 	bool AreBuffersEqual(const uint8_t* data1, size_t size1, const uint8_t* data2, size_t size2);
+
 	std::unique_ptr<RTC::RtpPacket> CreateRtpPacket(uint8_t* payload, size_t len);
 } // namespace helpers
 

worker/test/src/RTC/SCTP/common.cpp

@@ -1,36 +1,40 @@
 #include "RTC/SCTP/common.hpp" // in worker/test/include/
 #include <cstring>             // std::memset
 
-using namespace RTC::SCTP;
-
-thread_local uint8_t FactoryBuffer[];
-thread_local uint8_t SerializeBuffer[];
-thread_local uint8_t CloneBuffer[];
-thread_local uint8_t DataBuffer[];
-thread_local uint8_t ThrowBuffer[];
-
-void ResetBuffers()
+namespace RTC
 {
-	std::memset(FactoryBuffer, 0xAA, sizeof(FactoryBuffer));
-	std::memset(SerializeBuffer, 0xBB, sizeof(SerializeBuffer));
-	std::memset(CloneBuffer, 0xCC, sizeof(CloneBuffer));
-	std::memset(DataBuffer, 0xDD, sizeof(DataBuffer));
-	std::memset(ThrowBuffer, 0xEE, sizeof(ThrowBuffer));
+	namespace SCTP
+	{
+		thread_local uint8_t FactoryBuffer[];
+		thread_local uint8_t SerializeBuffer[];
+		thread_local uint8_t CloneBuffer[];
+		thread_local uint8_t DataBuffer[];
+		thread_local uint8_t ThrowBuffer[];
+
+		void ResetBuffers()
+		{
+			std::memset(FactoryBuffer, 0xAA, sizeof(FactoryBuffer));
+			std::memset(SerializeBuffer, 0xBB, sizeof(SerializeBuffer));
+			std::memset(CloneBuffer, 0xCC, sizeof(CloneBuffer));
+			std::memset(DataBuffer, 0xDD, sizeof(DataBuffer));
+			std::memset(ThrowBuffer, 0xEE, sizeof(ThrowBuffer));
 
-	DataBuffer[0]  = 0x00;
-	DataBuffer[1]  = 0x01;
-	DataBuffer[2]  = 0x02;
-	DataBuffer[3]  = 0x03;
-	DataBuffer[4]  = 0x04;
-	DataBuffer[5]  = 0x05;
-	DataBuffer[6]  = 0x06;
-	DataBuffer[7]  = 0x07;
-	DataBuffer[8]  = 0x08;
-	DataBuffer[9]  = 0x09;
-	DataBuffer[10] = 0x0A;
-	DataBuffer[11] = 0x0B;
-	DataBuffer[12] = 0x0C;
-	DataBuffer[13] = 0x0D;
-	DataBuffer[14] = 0x0E;
-	DataBuffer[15] = 0x0F;
-}
+			DataBuffer[0]  = 0x00;
+			DataBuffer[1]  = 0x01;
+			DataBuffer[2]  = 0x02;
+			DataBuffer[3]  = 0x03;
+			DataBuffer[4]  = 0x04;
+			DataBuffer[5]  = 0x05;
+			DataBuffer[6]  = 0x06;
+			DataBuffer[7]  = 0x07;
+			DataBuffer[8]  = 0x08;
+			DataBuffer[9]  = 0x09;
+			DataBuffer[10] = 0x0A;
+			DataBuffer[11] = 0x0B;
+			DataBuffer[12] = 0x0C;
+			DataBuffer[13] = 0x0D;
+			DataBuffer[14] = 0x0E;
+			DataBuffer[15] = 0x0F;
+		}
+	} // namespace SCTP
+} // namespace RTC