Skip to content

Commit c2d7b63

Browse files
authored
Update NPM deps (#1737)
- Update NPM deps. - Run `npm audit` in CI (but only for Prod deps). - Changes required by new ESLint version.
1 parent 5d834d9 commit c2d7b63

File tree

8 files changed

+469
-482
lines changed

8 files changed

+469
-482
lines changed

.github/workflows/mediasoup-node.yaml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ jobs:
117117
# to build.
118118
ASAN_OPTIONS: 'detect_leaks=0 symbolize=1 detect_stack_use_after_return=1 strict_init_order=1 check_initialization_order=1 detect_container_overflow=1'
119119

120-
- name: npm run worker:prebuild-name
121-
run: npm run worker:prebuild-name
120+
- name: npm audit --omit dev
121+
run: npm audit --omit dev
122122

123123
- if: ${{ matrix.build-type == 'Release' }}
124124
name: npm run worker:prebuild
@@ -130,3 +130,6 @@ jobs:
130130
- if: ${{ !matrix.build.skip-test-in-debug-build-type || matrix.build-type != 'Debug' }}
131131
name: npm run test:node
132132
run: npm run test:node
133+
134+
- name: npm run worker:prebuild-name
135+
run: npm run worker:prebuild-name

knip.config.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ const config = {
77
'node/src/rtpParametersFbsUtils.ts',
88
'node/src/rtpStreamStatsFbsUtils.ts',
99
'node/src/srtpParametersFbsUtils.ts',
10-
'node/src/utils.ts',
1110
],
1211
ignoreDependencies: ['open-cli', 'supports-color'],
1312
typescript: {

node/src/DataConsumer.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -355,13 +355,14 @@ export class DataConsumerImpl<DataConsumerAppData extends AppData = AppData>
355355

356356
const builder = this.#channel.bufferBuilder;
357357

358-
let dataOffset = 0;
359-
360358
if (typeof message === 'string') {
361359
message = Buffer.from(message);
362360
}
363361

364-
dataOffset = FbsDataConsumer.SendRequest.createDataVector(builder, message);
362+
const dataOffset = FbsDataConsumer.SendRequest.createDataVector(
363+
builder,
364+
message
365+
);
365366

366367
const requestOffset = FbsDataConsumer.SendRequest.createSendRequest(
367368
builder,

node/src/DataProducer.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,8 +297,6 @@ export class DataProducerImpl<DataProducerAppData extends AppData = AppData>
297297

298298
const builder = this.#channel.bufferBuilder;
299299

300-
let dataOffset = 0;
301-
302300
const subchannelsOffset =
303301
FbsDataProducer.SendNotification.createSubchannelsVector(
304302
builder,
@@ -309,7 +307,7 @@ export class DataProducerImpl<DataProducerAppData extends AppData = AppData>
309307
message = Buffer.from(message);
310308
}
311309

312-
dataOffset = FbsDataProducer.SendNotification.createDataVector(
310+
const dataOffset = FbsDataProducer.SendNotification.createDataVector(
313311
builder,
314312
message
315313
);

npm-scripts.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,7 @@ function installNodeDeps() {
507507
executeCmd('npm install --package-lock-only --ignore-scripts');
508508

509509
// Check vulnerabilities in deps.
510-
executeCmd('npm audit');
510+
executeCmd('npm audit --omit dev');
511511
executeCmd('npm audit --prefix worker/scripts');
512512
}
513513

0 commit comments

Comments
 (0)