cosmetic and fix in Channel.ts notify()

Author: ibc

node/src/Channel.ts

@@ -173,21 +173,21 @@ export class Channel extends EnhancedEventEmitter {
 			}
 		});
 
-		this.#consumerSocket.on('end', () =>
-			logger.debug('Consumer Channel ended by the worker process')
-		);
+		this.#consumerSocket.on('end', () => {
+			logger.debug('Consumer Channel ended by the worker process');
+		});
 
-		this.#consumerSocket.on('error', error =>
-			logger.error(`Consumer Channel error: ${error}`)
-		);
+		this.#consumerSocket.on('error', error => {
+			logger.error(`Consumer Channel error: ${error}`);
+		});
 
-		this.#producerSocket.on('end', () =>
-			logger.debug('Producer Channel ended by the worker process')
-		);
+		this.#producerSocket.on('end', () => {
+			logger.debug('Producer Channel ended by the worker process');
+		});
 
-		this.#producerSocket.on('error', error =>
-			logger.error(`Producer Channel error: ${error}`)
-		);
+		this.#producerSocket.on('error', error => {
+			logger.error(`Producer Channel error: ${error}`);
+		});
 	}
 
 	/**
@@ -244,7 +244,7 @@ export class Channel extends EnhancedEventEmitter {
 			);
 		}
 
-		const handlerIdOffset = this.#bufferBuilder.createString(handlerId);
+		const handlerIdOffset = this.#bufferBuilder.createString(handlerId ?? '');
 
 		let notificationOffset: number;
 
@@ -283,14 +283,16 @@ export class Channel extends EnhancedEventEmitter {
 		this.#bufferBuilder.clear();
 
 		if (buffer.byteLength > MESSAGE_MAX_LEN) {
-			throw new Error(`notification too big [event:${Event[event]}]`);
+			logger.error(`notify() | notification too big [event:${Event[event]}]`);
+
+			return;
 		}
 
 		try {
 			// This may throw if closed or remote side ended.
 			this.#producerSocket.write(buffer, 'binary');
 		} catch (error) {
-			logger.warn(`notify() | sending notification failed: ${error}`);
+			logger.error(`notify() | sending notification failed: ${error}`);
 
 			return;
 		}
@@ -317,7 +319,6 @@ export class Channel extends EnhancedEventEmitter {
 		}
 
 		const id = this.#nextId;
-
 		const handlerIdOffset = this.#bufferBuilder.createString(handlerId ?? '');
 
 		let requestOffset: number;

rust/src/worker/utils.rs

@@ -78,8 +78,8 @@ where
                     argc,
                     argv.as_ptr(),
                     version.as_ptr(),
-                    0,
-                    0,
+                    /*consumerChannelFd*/ 0,
+                    /*producerChannelFd*/ 0,
                     channel_read_fn,
                     channel_read_ctx,
                     channel_write_fn,

worker/fbs/activeSpeakerObserver.fbs

@@ -9,4 +9,3 @@ table ActiveSpeakerObserverOptions {
 table DominantSpeakerNotification {
     producer_id: string (required);
 }
-

worker/fbs/audioLevelObserver.fbs

@@ -16,4 +16,3 @@ table Volume {
 table VolumesNotification {
     volumes: [Volume] (required);
 }
-

worker/fbs/common.fbs

@@ -30,4 +30,3 @@ enum TraceDirection: uint8 {
     DIRECTION_IN = 0,
     DIRECTION_OUT
 }
-

worker/fbs/consumer.fbs

@@ -122,4 +122,3 @@ table TraceNotification {
     direction: FBS.Common.TraceDirection;
     info: TraceInfo;
 }
-

worker/fbs/dataConsumer.fbs

@@ -73,4 +73,3 @@ table MessageNotification {
     ppid: uint32;
     data: [uint8] (required);
 }
-

worker/fbs/dataProducer.fbs

@@ -31,4 +31,3 @@ table SendNotification {
     subchannels: [uint16];
     required_subchannel: uint16 = null;
 }
-

worker/fbs/directTransport.fbs

@@ -19,4 +19,3 @@ table GetStatsResponse {
 table RtcpNotification {
     data: [uint8] (required);
 }
-

worker/fbs/liburing.fbs

@@ -5,4 +5,3 @@ table Dump {
     sqe_miss_count: uint64;
     user_data_miss_count: uint64;
 }
-