min_pending_time should not be negative

[HustCoderHu]

mediasoup/worker/deps/libwebrtc/libwebrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc

Line 434 in f23ecea

TimeDelta min_pending_time = feedback.receive_time - max_recv_time;

Should it be like following?

TimeDelta min_pending_time = max_recv_time - feedback.receive_time;

[ibc]

This is code from libwebrtc. Can you verify it in latest libwebrtc source code?

[HustCoderHu]

https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/congestion_controller/goog_cc/goog_cc_network_control.cc;l=1?q=goog_cc_network_control.cc&sq=&ss=chromium%2Fchromium%2Fsrc
same in chromium, but it is obviously wrong.

[ibc]

Why is it obviously wrong?

[HustCoderHu]

  Timestamp max_recv_time = Timestamp::MinusInfinity();

  std::vector<PacketResult> feedbacks = report.ReceivedWithSendInfo();
  for (const auto& feedback : feedbacks)
    max_recv_time = std::max(max_recv_time, feedback.receive_time);

  for (const auto& feedback : feedbacks) {
    TimeDelta feedback_rtt =
        report.feedback_time - feedback.sent_packet.send_time;
    TimeDelta min_pending_time = feedback.receive_time - max_recv_time;
    TimeDelta propagation_rtt = feedback_rtt - min_pending_time;
    // propagation_rtt ought to be smaller than feedback_rtt, coz feedback_rtt includes packet pending time at remote, 
    // thus pending_time is a positive value
    max_feedback_rtt = std::max(max_feedback_rtt, feedback_rtt);
    min_propagation_rtt = std::min(min_propagation_rtt, propagation_rtt);
  }

[ibc]

Here you are asking for a change in libwebrtc. I'm not saying that your proposed change is bad but we need much more info and rationale about it.

[fippo]

libwebrtc issue here: https://bugs.chromium.org/p/webrtc/issues/detail?id=13106, no movement for a while

[ibc]

Changes are applied into current v3 in this PR: #944