Skip to content

Commit 0d29f16

Browse files
committed
stricter tsconfig settings
1 parent dc5831f commit 0d29f16

35 files changed

+84
-61
lines changed

src/packets/Packet.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ export abstract class Packet extends Serializable {
3535
* @remarks
3636
* - Read the info dump type of each RTCP packet instead.
3737
*/
38-
dump(): PacketDump {
38+
override dump(): PacketDump {
3939
return {
4040
...super.dump(),
4141
padding: this.getPadding(),

src/packets/RTCP/ByePacket.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export class ByePacket extends RtcpPacket {
115115
/**
116116
* Dump RTCP BYE packet info.
117117
*/
118-
dump(): ByePacketDump {
118+
override dump(): ByePacketDump {
119119
return {
120120
...super.dump(),
121121
ssrcs: this.getSsrcs(),

src/packets/RTCP/CompoundPacket.mts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ export class CompoundPacket extends Packet {
203203
/**
204204
* Dump RTCP Compound packet info.
205205
*/
206-
dump(): CompoundPacketDump {
206+
override dump(): CompoundPacketDump {
207207
return {
208208
...super.dump(),
209209
packets: this.#packets.map(packet => packet.dump()),
@@ -231,7 +231,7 @@ export class CompoundPacket extends Packet {
231231
*
232232
* @hidden
233233
*/
234-
getPadding(): number {
234+
override getPadding(): number {
235235
return 0;
236236
}
237237

@@ -240,14 +240,14 @@ export class CompoundPacket extends Packet {
240240
*
241241
* @hidden
242242
*/
243-
padTo4Bytes(): void {
243+
override padTo4Bytes(): void {
244244
throw new Error('method not implemented in RTCP CompoundPacket');
245245
}
246246

247247
/**
248248
* @inheritDoc
249249
*/
250-
needsSerialization(): boolean {
250+
override needsSerialization(): boolean {
251251
return (
252252
super.needsSerialization() ||
253253
this.#packets.some(packet => packet.needsSerialization())

src/packets/RTCP/EcnPacket.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ export class EcnPacket extends FeedbackPacket {
9292
/**
9393
* Dump RTCP ECN packet info.
9494
*/
95-
dump(): EcnPacketDump {
95+
override dump(): EcnPacketDump {
9696
return {
9797
...super.dump(),
9898
extendedHighestSequenceNumber: this.getExtendedHighestSequenceNumber(),

src/packets/RTCP/ExtendedJitterReportsPacket.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export class ExtendedJitterReportsPacket extends RtcpPacket {
8787
/**
8888
* Dump RTCP Extended Jitter Reports packet info.
8989
*/
90-
dump(): ExtendedJitterReportsPacketDump {
90+
override dump(): ExtendedJitterReportsPacketDump {
9191
return {
9292
...super.dump(),
9393
jitters: this.getJitters(),

src/packets/RTCP/FeedbackPacket.mts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@ function messageTypeToString(
107107
}
108108
}
109109

110+
// @ts-expect-error --- Ignore "error TS7027: Unreachable code detected"
111+
// to not conflict with ESLint rules.
110112
break;
111113
}
112114

@@ -135,6 +137,8 @@ function messageTypeToString(
135137
}
136138
}
137139

140+
// @ts-expect-error --- Ignore "error TS7027: Unreachable code detected"
141+
// to not conflict with ESLint rules.
138142
break;
139143
}
140144

@@ -196,7 +200,7 @@ export abstract class FeedbackPacket extends RtcpPacket {
196200
* @remarks
197201
* - Read the info dump type of each RTCP Feedback packet instead.
198202
*/
199-
dump(): FeedbackPacketDump {
203+
override dump(): FeedbackPacketDump {
200204
return {
201205
...super.dump(),
202206
messageType: this.getMessageType(),
@@ -249,7 +253,7 @@ export abstract class FeedbackPacket extends RtcpPacket {
249253
/**
250254
* Serialize base RTCP Feedback packet into a new buffer.
251255
*/
252-
protected serializeBase(
256+
protected override serializeBase(
253257
buffer?: ArrayBufferLike,
254258
byteOffset?: number
255259
): DataView {

src/packets/RTCP/GenericFeedbackPacket.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ export class GenericFeedbackPacket extends FeedbackPacket {
113113
/**
114114
* Dump RTCP generic Feedback packet info.
115115
*/
116-
dump(): GenericFeedbackPacketDump {
116+
override dump(): GenericFeedbackPacketDump {
117117
return {
118118
...super.dump(),
119119
bodyLength: this.getBody().byteLength,

src/packets/RTCP/GenericPacket.mts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class GenericPacket extends RtcpPacket {
9898
/**
9999
* Dump RTCP generic packet info.
100100
*/
101-
dump(): GenericPacketDump {
101+
override dump(): GenericPacketDump {
102102
return {
103103
...super.dump(),
104104
bodyLength: this.getBody().byteLength,
@@ -205,7 +205,7 @@ export class GenericPacket extends RtcpPacket {
205205
* whatever body to this packet, and hence the user may want to also
206206
* manipulate this field.
207207
*/
208-
setCount(count: number): void {
208+
override setCount(count: number): void {
209209
super.setCount(count);
210210
}
211211

src/packets/RTCP/NackPacket.mts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ export class NackPacket extends FeedbackPacket {
9393
/**
9494
* Dump RTCP NACK packet info.
9595
*/
96-
dump(): NackPacketDump {
96+
override dump(): NackPacketDump {
9797
return {
9898
...super.dump(),
9999
items: this.getItems(),
@@ -240,11 +240,11 @@ export function createNackItem(seqs: number[]): {
240240
bitmask: number;
241241
} {
242242
const orderedSeqs = [...seqs].sort();
243-
const pid = orderedSeqs[0];
243+
const pid = orderedSeqs[0]!;
244244
let bitmask: number = 0;
245245

246246
for (let i = 1; i < orderedSeqs.length; ++i) {
247-
const seq = orderedSeqs[i];
247+
const seq = orderedSeqs[i]!;
248248
const diff = (seq + 65536 - pid) % 65536;
249249

250250
if (diff > 16) {

src/packets/RTCP/PliPacket.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export class PliPacket extends FeedbackPacket {
7272
/**
7373
* Dump RTCP PLI packet info.
7474
*/
75-
dump(): PliPacketDump {
75+
override dump(): PliPacketDump {
7676
return super.dump();
7777
}
7878

0 commit comments

Comments
 (0)