eslint improvements

Author: ibc

eslint.config.mjs

@@ -145,23 +145,12 @@ const config = tsEslint.config(
 			],
 			// We want to use `type` instead of `interface`.
 			'@typescript-eslint/consistent-type-definitions': 0,
-			// Sorry, we need many `any` usage.
-			'@typescript-eslint/no-explicit-any': 0,
-			'@typescript-eslint/no-inferrable-types': 0,
-			'@typescript-eslint/no-unsafe-member-access': 0,
-			'@typescript-eslint/no-unsafe-assignment': 0,
-			'@typescript-eslint/no-unsafe-call': 0,
-			'@typescript-eslint/no-unsafe-return': 0,
-			'@typescript-eslint/no-unsafe-argument': 0,
-			'@typescript-eslint/consistent-indexed-object-style': 0,
-			'@typescript-eslint/no-empty-function': 0,
-			'@typescript-eslint/require-await': 0,
-			'@typescript-eslint/restrict-template-expressions': 0,
-			'@typescript-eslint/no-duplicate-type-constituents': [
+			'@typescript-eslint/explicit-function-return-type': [
 				2,
-				{ ignoreUnions: true },
+				{ allowExpressions: true },
 			],
-			'@typescript-eslint/unbound-method': 0,
+			'@typescript-eslint/no-inferrable-types': 0,
+			'@typescript-eslint/restrict-template-expressions': 0,
 		},
 	},
 	{

npm-scripts.mjs

@@ -53,13 +53,13 @@ async function run() {
 		//
 		// So here we compile TypeScript to JavaScript.
 		case 'prepare': {
-			buildTypescript();
+			buildTypescript({ force: false });
 
 			break;
 		}
 
 		case 'typescript:build': {
-			buildTypescript();
+			buildTypescript({ force: true });
 
 			break;
 		}
@@ -150,17 +150,17 @@ function deleteLib() {
 	fs.rmSync('lib', { recursive: true, force: true });
 }
 
-function buildTypescript() {
+function buildTypescript({ force }) {
+	if (!force && fs.existsSync('node/lib')) {
+		return;
+	}
+
 	logInfo('buildTypescript()');
 
 	deleteLib();
 
 	// Generate .js CommonJS code and .d.ts TypeScript declaration files in lib/.
 	executeCmd('tsc');
-
-	// Delete generated lib/test because we don't to expose them in the published
-	// library.
-	fs.rmSync('lib/test', { recursive: true, force: true });
 }
 
 function watchTypescript() {
@@ -210,7 +210,7 @@ function checkRelease() {
 	logInfo('checkRelease()');
 
 	installDeps();
-	buildTypescript();
+	buildTypescript({ force: true });
 	lint();
 	test();
 	checkDocs();

package-lock.json

@@ -61,17 +61,17 @@
 		"docs:check": "node npm-scripts.mjs docs:check"
 	},
 	"dependencies": {
-		"@types/node": "^22.13.10",
+		"@types/node": "^22.13.11",
 		"debug": "^4.4.0",
 		"supports-color": "^10.0.0"
 	},
 	"devDependencies": {
-		"@eslint/js": "^9.22.0",
+		"@eslint/js": "^9.23.0",
 		"@types/debug": "^4.1.12",
 		"@types/jest": "^29.5.14",
 		"@typescript-eslint/eslint-plugin": "^8.27.0",
 		"@typescript-eslint/parser": "^8.27.0",
-		"eslint": "^9.22.0",
+		"eslint": "^9.23.0",
 		"eslint-config-prettier": "^10.1.1",
 		"eslint-plugin-jest": "^28.11.0",
 		"eslint-plugin-prettier": "^5.2.3",

package.json

@@ -223,7 +223,7 @@ export abstract class FeedbackPacket extends RtcpPacket {
 	/**
 	 * Set sender SSRC.
 	 */
-	setSenderSsrc(ssrc: number) {
+	setSenderSsrc(ssrc: number): void {
 		this.view.setUint32(4, ssrc);
 	}
 
@@ -237,7 +237,7 @@ export abstract class FeedbackPacket extends RtcpPacket {
 	/**
 	 * Set media SSRC.
 	 */
-	setMediaSsrc(ssrc: number) {
+	setMediaSsrc(ssrc: number): void {
 		this.view.setUint32(8, ssrc);
 	}
 

src/packets/RTCP/FeedbackPacket.ts

@@ -247,7 +247,7 @@ export class ReceiverReportPacket extends RtcpPacket {
 	/**
 	 * Set sender SSRC.
 	 */
-	setSsrc(ssrc: number) {
+	setSsrc(ssrc: number): void {
 		this.view.setUint32(4, ssrc);
 	}
 
@@ -486,7 +486,7 @@ export class ReceptionReport extends Serializable {
 	/**
 	 * Set interarrival jitter.
 	 */
-	setJitter(jitter: number) {
+	setJitter(jitter: number): void {
 		this.view.setUint32(12, jitter);
 
 		this.setSerializationNeeded(true);

src/packets/RTCP/ReceiverReportPacket.ts

@@ -254,7 +254,7 @@ export class SenderReportPacket extends RtcpPacket {
 	/**
 	 * Set sender SSRC.
 	 */
-	setSsrc(ssrc: number) {
+	setSsrc(ssrc: number): void {
 		this.view.setUint32(4, ssrc);
 	}
 

src/packets/RTCP/SenderReportPacket.ts

@@ -289,7 +289,7 @@ export class XrPacket extends RtcpPacket {
 	/**
 	 * Set sender SSRC.
 	 */
-	setSsrc(ssrc: number) {
+	setSsrc(ssrc: number): void {
 		this.view.setUint32(4, ssrc);
 	}
 

src/packets/RTCP/XrPacket.ts

@@ -578,7 +578,7 @@ export class SsExtendedReport extends ExtendedReport {
 		this.setSerializationNeeded(true);
 	}
 
-	private hasLostPacketsBit() {
+	private hasLostPacketsBit(): boolean {
 		return readBitInDataView({ view: this.view, pos: 1, bit: 7 });
 	}
 
@@ -590,7 +590,7 @@ export class SsExtendedReport extends ExtendedReport {
 		}
 	}
 
-	private hasDuplicatePacketsBit() {
+	private hasDuplicatePacketsBit(): boolean {
 		return readBitInDataView({ view: this.view, pos: 1, bit: 6 });
 	}
 
@@ -602,7 +602,7 @@ export class SsExtendedReport extends ExtendedReport {
 		}
 	}
 
-	private hasJitterBit() {
+	private hasJitterBit(): boolean {
 		return readBitInDataView({ view: this.view, pos: 1, bit: 5 });
 	}
 

src/packets/RTCP/extendedReports/SsExtendedReport.ts

@@ -1262,7 +1262,7 @@ export class RtpPacket extends Packet {
 	 * @remarks
 	 * - Serialization is needed after calling this method.
 	 */
-	rtxEncode(payloadType: number, ssrc: number, sequenceNumber: number) {
+	rtxEncode(payloadType: number, ssrc: number, sequenceNumber: number): void {
 		// Rewrite the payload type.
 		this.setPayloadType(payloadType);
 
@@ -1314,7 +1314,7 @@ export class RtpPacket extends Packet {
 	 * @throws
 	 * - If payload length is less than 2 bytes, so RTX decode is not possible.
 	 */
-	rtxDecode(payloadType: number, ssrc: number) {
+	rtxDecode(payloadType: number, ssrc: number): void {
 		if (this.#payloadView.byteLength < 2) {
 			throw new RangeError(
 				'payload length must be greater or equal than 2 bytes'