refactor(terminal): replace IsInteractiveTerminal with IsNonInteractiveTerminal (#555)

Author: bytemain

cmd/commands/install.go

@@ -97,7 +97,7 @@ func installCmd(ctx context.Context, cmd *cli.Command) error {
 			var resolvedVersion = manager.ResolveVersion(sdk.Name, version)
 			logger.Debugf("resolved version: %s\n", resolvedVersion)
 			if resolvedVersion == "" {
-				if !internal.IsInteractiveTerminal() {
+				if util.IsNonInteractiveTerminal() {
 					return cli.Exit(fmt.Sprintf("install requires specifying a version for %s", name), 1)
 				}
 				showAvailable, _ := pterm.DefaultInteractiveConfirm.Show(fmt.Sprintf("No %s version provided, do you want to select a version to install?", pterm.Red(name)))
@@ -146,7 +146,7 @@ func installAll(autoConfirm bool) error {
 	printSdk(sdks, nil)
 
 	if !autoConfirm {
-		if !internal.IsInteractiveTerminal() {
+		if util.IsNonInteractiveTerminal() {
 			return cli.Exit("Use the -y flag to automatically confirm installation in non-interactive environments", 1)
 		}
 		result, _ := pterm.DefaultInteractiveConfirm.

cmd/commands/remove.go

@@ -18,9 +18,11 @@ package commands
 
 import (
 	"context"
+
 	"github.com/pterm/pterm"
 	"github.com/urfave/cli/v3"
 	"github.com/version-fox/vfox/internal"
+	"github.com/version-fox/vfox/internal/util"
 )
 
 var Remove = &cli.Command{
@@ -50,7 +52,7 @@ func removeCmd(ctx context.Context, cmd *cli.Command) error {
 	pterm.Println("Removing this plugin will remove the installed sdk along with the plugin.")
 
 	if !yes {
-		if !internal.IsInteractiveTerminal() {
+		if util.IsNonInteractiveTerminal() {
 			return cli.Exit("Use the -y flag to skip confirmation in non-interactive environments", 1)
 		}
 		result, _ := pterm.DefaultInteractiveConfirm.

cmd/commands/search.go

@@ -79,7 +79,7 @@ func RunSearch(sdkName string, availableArgs []string) error {
 		installedVersions.Add(string(version))
 	}
 
-	if !internal.IsInteractiveTerminal() {
+	if util.IsNonInteractiveTerminal() {
 		fmt.Println("Available versions:")
 		for _, option := range options {
 			label := option.Value

cmd/commands/use.go

@@ -22,6 +22,8 @@ import (
 	"os"
 	"strings"
 
+	"github.com/version-fox/vfox/internal/util"
+
 	"github.com/pterm/pterm"
 	"github.com/version-fox/vfox/internal"
 	"github.com/version-fox/vfox/internal/base"
@@ -98,7 +100,7 @@ func useCmd(ctx context.Context, cmd *cli.Command) error {
 		if len(arr) == 0 {
 			return fmt.Errorf("no versions available for %s", name)
 		}
-		if !internal.IsInteractiveTerminal() {
+		if util.IsNonInteractiveTerminal() {
 			return cli.Exit("Please specify a version to use in non-interactive environments", 1)
 		}
 		selectPrinter := pterm.InteractiveSelectPrinter{

go.mod

@@ -16,6 +16,7 @@ require (
 	github.com/yuin/gopher-lua v1.1.1
 	golang.org/x/crypto v0.35.0
 	golang.org/x/sys v0.30.0
+	golang.org/x/term v0.29.0
 	gopkg.in/yaml.v3 v3.0.1
 )
 
@@ -45,6 +46,5 @@ require (
 	github.com/yusufpapurcu/wmi v1.2.4 // indirect
 	go4.org v0.0.0-20200411211856-f5505b9728dd // indirect
 	golang.org/x/net v0.29.0 // indirect
-	golang.org/x/term v0.29.0 // indirect
 	golang.org/x/text v0.22.0 // indirect
 )

internal/manager.go

@@ -271,7 +271,7 @@ func (m *Manager) LookupSdkWithInstall(name string, autoConfirm bool) (*Sdk, err
 		if errors.As(err, &NotFoundError{}) {
 			if autoConfirm {
 				fmt.Printf("[%s] not added yet, automatically proceeding with installation.\n", pterm.LightBlue(name))
-			} else if !IsInteractiveTerminal() {
+			} else if util.IsNonInteractiveTerminal() {
 				return nil, cli.Exit(fmt.Sprintf("Plugin %s is not installed. Use the -y flag to automatically install plugins in non-interactive environments", name), 1)
 			} else {
 				fmt.Printf("[%s] not added yet, confirm that you want to use [%s]? \n", pterm.LightBlue(name), pterm.LightRed(name))

internal/ci.go renamed to internal/util/ci.go

@@ -1,4 +1,4 @@
-package internal
+package util
 
 import (
 	"os"
@@ -48,13 +48,13 @@ func isCI() bool {
 	return false
 }
 
-// IsInteractiveTerminal checks if the current environment supports interactive terminal operations.
-// Returns false if running in CI or if stdout is not a terminal (e.g., piped output).
-func IsInteractiveTerminal() bool {
+// IsNonInteractiveTerminal checks if the current environment is non-interactive.
+// Returns true if running in CI or if stdout is not a terminal (e.g., piped output).
+func IsNonInteractiveTerminal() bool {
 	if isCI() {
-		return false
+		return true
 	}
-	return true
+	return !IsTTY()
 }
 
 func isTruthyEnv(value string) bool {

internal/ci_test.go renamed to internal/util/ci_test.go

@@ -1,4 +1,4 @@
-package internal
+package util
 
 import "testing"