Major regressions between 3.5 and 3.6 #82
Description
While upgrading code from 3.5.x to 3.6 (the guide for Java developers), I encountered 2 regressions.
Need for @VertxGen
We now need to also add @VertxGen.
Before:
@ProxyGen
public interface WikiDatabaseService { ... }After:
@ProxyGen
@VertxGen
public interface WikiDatabaseService { ... }Otherwise, compilation fails.
Static methods aren't being ignored anymore
Code generation used to ignore static methods, such as the idiomatic create methods we have in services:
static WikiDatabaseService create(JDBCClient dbClient, HashMap<SqlQuery, String> sqlQueries, Handler<AsyncResult<WikiDatabaseService>> readyHandler) {
return new WikiDatabaseServiceImpl(dbClient, sqlQueries, readyHandler);
}
static WikiDatabaseService createProxy(Vertx vertx, String address) {
return new WikiDatabaseServiceVertxEBProxy(vertx, address);
}We now need to explicitly ignore them otherwise compilation fails:
@GenIgnore
static WikiDatabaseService create(JDBCClient dbClient, HashMap<SqlQuery, String> sqlQueries, Handler<AsyncResult<WikiDatabaseService>> readyHandler) {
return new WikiDatabaseServiceImpl(dbClient, sqlQueries, readyHandler);
}
@GenIgnore
static WikiDatabaseService createProxy(Vertx vertx, String address) {
return new WikiDatabaseServiceVertxEBProxy(vertx, address);
}