Some dialer fixes (#64)

Author: manas-vessel

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vesselapi/integrations",
-  "version": "0.0.49",
+  "version": "0.0.50",
   "description": "Vessel integrations",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

src/platforms/dialpad/client.ts

@@ -18,7 +18,7 @@ const BASE_URL = `${API_DOMAIN}/${API_VERSION}` as HttpsUrl;
 
 const request = makeRequestFactory(async (auth, options) => ({
   ...options,
-  url: `${BASE_URL}/${options.url}`,
+  url: `${BASE_URL}${options.url}`,
   headers: {
     ...options.headers,
     Accept: 'application/json',
@@ -74,11 +74,15 @@ const makeClient = (): DialpadClient => {
       list: listObject('contacts', listResponseSchema(dialpadContactSchema)),
       create: createObject<DialpadContactCreate>(
         'contacts',
-        dialpadContactSchema,
+        dialpadContactSchema.partial().required({
+          id: true,
+        }),
       ),
       update: updateObject<DialpadContactUpdate>(
         'contacts',
-        dialpadContactSchema,
+        dialpadContactSchema.partial().required({
+          id: true,
+        }),
       ),
     },
     calls: {

src/platforms/dialpad/schemas.ts

@@ -33,7 +33,7 @@ export const dialpadUserSchema = z
     license: z.string(),
     muted: z.boolean(),
     office_id: z.string(),
-    phone_numbers: z.array(z.string()),
+    phone_numbers: z.array(custom.formattedPhoneNumber()),
     state: z.string(),
     timezone: z.string(),
   })
@@ -49,9 +49,9 @@ export const dialpadContactSchema = z.object({
   extension: z.string(),
   job_title: z.string(),
   owner_id: z.string(),
-  phones: z.array(z.string()),
+  phones: z.array(custom.formattedPhoneNumber()),
   primary_email: z.string(),
-  primary_phone: z.string(),
+  primary_phone: custom.formattedPhoneNumber(),
   type: z.enum(['shared', 'local']),
   urls: z.array(z.string()),
 });
@@ -119,7 +119,7 @@ const targetSchema = z
     email: z.string(),
     id: z.string(),
     name: z.string(),
-    phone: z.string(),
+    phone: custom.formattedPhoneNumber(),
     type: z.string(),
   })
   .passthrough();

src/platforms/ringcentral/client.ts

@@ -19,7 +19,7 @@ const BASE_URL = `${API_DOMAIN}/${API_VERSION}` as HttpsUrl;
 
 const request = makeRequestFactory(async (auth, options) => ({
   ...options,
-  url: `${BASE_URL}/${options.url}`,
+  url: `${BASE_URL}${options.url}`,
   headers: {
     ...options.headers,
     Authorization: `Bearer ${await auth.getToken()}`,

src/platforms/ringcentral/schemas.ts

@@ -87,7 +87,7 @@ export const ringcentralContactSchema = z
     lastName: z.string(),
     company: z.string().optional(),
     email: z.string().optional(),
-    businessPhone: z.string(),
+    businessPhone: custom.formattedPhoneNumber(),
   })
   .passthrough();
 

src/sdk/validators.ts

@@ -15,7 +15,8 @@ export const json = () => z.object({}).catchall(z.any()).optional();
 export const formattedPhoneNumber = (format?: NumberFormat) =>
   z
     .string()
-    .refine((value) => {
+    .refine((value?) => {
+      if (!value) return false;
       return parsePhoneNumber(value)?.isValid();
     })
     .transform((value) => {