ci: switch to yamllint

mnaser · mnaser · commit 7b66f2c2c1bf · 2025-09-02T01:01:43.000Z
Signed-off-by: Mohammed Naser &lt;mnaser@vexxhost.com&gt;
diff --git a/.ansible-lint b/.ansible-lint
@@ -3,8 +3,7 @@ exclude_paths:
   - .ansible
   - .github
   - molecule
-  - roles/cluster_api/files/providers
-  - roles/cert_manager/files/chart
-  - roles/cilium/files/chart
+
 skip_list:
   - role-name
+  - yaml
diff --git a/.yamllint.yaml b/.yamllint.yaml
@@ -0,0 +1,15 @@
+extends: default
+
+rules:
+  comments:
+    min-spaces-from-content: 1
+  comments-indentation: false
+  document-start: disable
+  line-length:
+    max: 160
+  braces:
+    min-spaces-inside: 0
+    max-spaces-inside: 1
+  octal-values:
+    forbid-implicit-octal: true
+    forbid-explicit-octal: true
diff --git a/extensions/molecule/cluster-api/verify.yml b/extensions/molecule/cluster-api/verify.yml
@@ -41,7 +41,7 @@
         name: "{{ item.name }}"
         namespace: "{{ item.namespace }}"
       register: _resource_info
-      until: _resource_info.resources | json_query('[*].status.conditions[?reason==`NewReplicaSetAvailable`][].status') | select ('match','True') | list | length == 1
+      until: _resource_info.resources | json_query('[*].status.conditions[?reason==`NewReplicaSetAvailable`][].status') | select ('match','True') | list | length == 1 # yamllint disable-line rule:line-length
       delay: 2
       retries: 5
       loop:
@@ -77,10 +77,10 @@
     - name: Parse provider resources into version mapping
       run_once: true
       ansible.builtin.set_fact:
-        _cluster_api_core_version: "{{ _cluster_api_providers.resources | selectattr('type', 'equalto', 'CoreProvider') | map(attribute='version') | first | regex_replace('^v', '') }}"
-        _cluster_api_bootstrap_version: "{{ _cluster_api_providers.resources | selectattr('type', 'equalto', 'BootstrapProvider') | map(attribute='version') | first | regex_replace('^v', '') }}"
-        _cluster_api_control_plane_version: "{{ _cluster_api_providers.resources | selectattr('type', 'equalto', 'ControlPlaneProvider') | map(attribute='version') | first | regex_replace('^v', '') }}"
-        _cluster_api_infrastructure_version: "{{ _cluster_api_providers.resources | selectattr('type', 'equalto', 'InfrastructureProvider') | map(attribute='version') | first | regex_replace('^v', '') }}"
+        _cluster_api_core_version: "{{ _cluster_api_providers.resources | selectattr('type', 'equalto', 'CoreProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # yamllint disable-line rule:line-length
+        _cluster_api_bootstrap_version: "{{ _cluster_api_providers.resources | selectattr('type', 'equalto', 'BootstrapProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # yamllint disable-line rule:line-length
+        _cluster_api_control_plane_version: "{{ _cluster_api_providers.resources | selectattr('type', 'equalto', 'ControlPlaneProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # yamllint disable-line rule:line-length
+        _cluster_api_infrastructure_version: "{{ _cluster_api_providers.resources | selectattr('type', 'equalto', 'InfrastructureProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # yamllint disable-line rule:line-length
 
     - name: Assert that the versions are the correct ones
       ansible.builtin.assert:
diff --git a/extensions/molecule/upload-helm-chart/converge.yml b/extensions/molecule/upload-helm-chart/converge.yml
@@ -19,4 +19,4 @@
   roles:
     - role: test-role
       vars:
-        test_relative_path : "chart-v1/"
+        test_relative_path: "chart-v1/"
diff --git a/roles/cluster_api/meta/main.yml b/roles/cluster_api/meta/main.yml
@@ -30,7 +30,7 @@ dependencies:
           url: "{{ cluster_api_provider_path }}/bootstrap-{{ cluster_api_bootstrap_provider }}/v{{ cluster_api_bootstrap_version }}/bootstrap-components.yaml"
         - name: kubeadm
           type: ControlPlaneProvider
-          url: "{{ cluster_api_provider_path }}/control-plane-{{ cluster_api_control_plane_provider }}/v{{ cluster_api_control_plane_version }}/control-plane-components.yaml" # noqa: yaml[line-length]
+          url: "{{ cluster_api_provider_path }}/control-plane-{{ cluster_api_control_plane_provider }}/v{{ cluster_api_control_plane_version }}/control-plane-components.yaml" # yamllint disable-line rule:line-length
         - name: openstack
           type: InfrastructureProvider
-          url: "{{ cluster_api_provider_path }}/infrastructure-{{ cluster_api_infrastructure_provider }}/v{{ cluster_api_infrastructure_version }}/infrastructure-components.yaml" # noqa: yaml[line-length]
+          url: "{{ cluster_api_provider_path }}/infrastructure-{{ cluster_api_infrastructure_provider }}/v{{ cluster_api_infrastructure_version }}/infrastructure-components.yaml" # yamllint disable-line rule:line-length
diff --git a/roles/cluster_api/tasks/upgrade.yml b/roles/cluster_api/tasks/upgrade.yml
@@ -5,10 +5,10 @@
 - name: Parse provider resources into version mapping
   run_once: true
   ansible.builtin.set_fact:
-    cluster_api_installed_core_version: "{{ cluster_api_providers.resources | selectattr('type', 'equalto', 'CoreProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # noqa: yaml[line-length]
-    cluster_api_installed_bootstrap_version: "{{ cluster_api_providers.resources | selectattr('type', 'equalto', 'BootstrapProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # noqa: yaml[line-length]
-    cluster_api_installed_control_plane_version: "{{ cluster_api_providers.resources | selectattr('type', 'equalto', 'ControlPlaneProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # noqa: yaml[line-length]
-    cluster_api_installed_infrastructure_version: "{{ cluster_api_providers.resources | selectattr('type', 'equalto', 'InfrastructureProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # noqa: yaml[line-length]
+    cluster_api_installed_core_version: "{{ cluster_api_providers.resources | selectattr('type', 'equalto', 'CoreProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # yamllint disable-line rule:line-length
+    cluster_api_installed_bootstrap_version: "{{ cluster_api_providers.resources | selectattr('type', 'equalto', 'BootstrapProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # yamllint disable-line rule:line-length
+    cluster_api_installed_control_plane_version: "{{ cluster_api_providers.resources | selectattr('type', 'equalto', 'ControlPlaneProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # yamllint disable-line rule:line-length
+    cluster_api_installed_infrastructure_version: "{{ cluster_api_providers.resources | selectattr('type', 'equalto', 'InfrastructureProvider') | map(attribute='version') | first | regex_replace('^v', '') }}" # yamllint disable-line rule:line-length
 
 - name: Run upgrade if required
   run_once: true
diff --git a/roles/clusterctl/defaults/main.yml b/roles/clusterctl/defaults/main.yml
@@ -33,7 +33,7 @@ clusterctl_checksums:
     1.8.4: 8fbaa26320fcdd11aa40e1e2ae4889f9743c33744e1d191eec2afca54d34bdbc
     1.10.5: 8831f604a2571947ef19bfa9fd9dcc50b67e42deb6651bb09382e4bca212d795
 
-clusterctl_download_url: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v{{ clusterctl_version }}/clusterctl-linux-{{ download_artifact_goarch }}" # noqa: yaml[line-length]
+clusterctl_download_url: "https://github.com/kubernetes-sigs/cluster-api/releases/download/v{{ clusterctl_version }}/clusterctl-linux-{{ download_artifact_goarch }}" # yamllint disable-line rule:line-length
 clusterctl_download_dest: /usr/local/bin/clusterctl
 clusterctl_binary_checksum: "{{ clusterctl_checksums[download_artifact_goarch][clusterctl_version] }}"
 
diff --git a/roles/flux/defaults/main.yml b/roles/flux/defaults/main.yml
@@ -20,7 +20,7 @@ flux_checksums:
   arm64:
     0.32.0: 6834c6fde64df9883b76c6b3a3111a6d00f88553373b892f363491b0896c0654
 
-flux_download_url: "https://github.com/fluxcd/flux2/releases/download/v{{ flux_version }}/flux_{{ flux_version }}_linux_{{ download_artifact_goarch }}.tar.gz" # noqa: yaml[line-length]
+flux_download_url: "https://github.com/fluxcd/flux2/releases/download/v{{ flux_version }}/flux_{{ flux_version }}_linux_{{ download_artifact_goarch }}.tar.gz" # yamllint disable-line rule:line-length
 flux_download_dest: "{{ download_artifact_work_directory }}/flux-{{ flux_version }}-linux-{{ download_artifact_goarch }}.tar.gz"
 flux_download_unarchive_dest: /usr/bin
 flux_binary_checksum: "{{ flux_checksums[download_artifact_goarch][flux_version] }}"
diff --git a/roles/helm/defaults/main.yml b/roles/helm/defaults/main.yml
@@ -38,6 +38,6 @@ helm_diff_checksums:
   arm64:
     v3.8.1: d451e4772a3987710f485de4caed760583c88f8f15864a623b3fbd73be7077ec
 
-helm_diff_download_url: "https://github.com/databus23/helm-diff/releases/download/{{ helm_diff_version }}/helm-diff-{{ ansible_facts['system'] | lower }}-{{ download_artifact_goarch }}.tgz" # noqa: yaml[line-length]
-helm_diff_download_dest: "{{ download_artifact_work_directory }}/helm-diff-{{ helm_diff_version }}-{{ ansible_facts['system'] | lower }}-{{ download_artifact_goarch }}.tgz" # noqa: yaml[line-length]
+helm_diff_download_url: "https://github.com/databus23/helm-diff/releases/download/{{ helm_diff_version }}/helm-diff-{{ ansible_facts['system'] | lower }}-{{ download_artifact_goarch }}.tgz" # yamllint disable-line rule:line-length
+helm_diff_download_dest: "{{ download_artifact_work_directory }}/helm-diff-{{ helm_diff_version }}-{{ ansible_facts['system'] | lower }}-{{ download_artifact_goarch }}.tgz" # yamllint disable-line rule:line-length
 helm_diff_checksum: "{{ helm_diff_checksums[download_artifact_goarch][helm_diff_version] }}"
diff --git a/roles/kubeadm/defaults/main.yml b/roles/kubeadm/defaults/main.yml
@@ -57,7 +57,7 @@ kubeadm_checksums:
     1.32.8: 8dbd3fa2d94335d763b983caaf2798caae2d4183f6a95ebff28289f2e86edf68
     1.33.4: ef471b454d68ee211e279ddeaebde6ee7a8e14b66ae58e0d0184e967c3595892
 
-kubeadm_download_url: "https://cdn.dl.k8s.io/release/v{{ kubeadm_version }}/bin/{{ ansible_facts['system'] | lower }}/{{ download_artifact_goarch }}/kubeadm" # noqa: yaml[line-length]
+kubeadm_download_url: "https://cdn.dl.k8s.io/release/v{{ kubeadm_version }}/bin/{{ ansible_facts['system'] | lower }}/{{ download_artifact_goarch }}/kubeadm" # yamllint disable-line rule:line-length
 kubeadm_download_dest: /usr/bin/kubeadm
 kubeadm_binary_checksum: "{{ kubeadm_checksums[download_artifact_goarch][kubeadm_version] }}"
 
diff --git a/roles/kubectl/defaults/main.yml b/roles/kubectl/defaults/main.yml
@@ -57,7 +57,7 @@ kubectl_checksums:
     1.32.8: 8a7371e54187249389a9aa222b150d61a4a745c121ab24dbcbb56d1ac2d0b912
     1.33.4: 76cd7a2aa59571519b68c3943521404cbce55dafb7d8866f8d0ea2995b396eef
 
-kubectl_download_url: "https://cdn.dl.k8s.io/release/v{{ kubectl_version }}/bin/{{ ansible_facts['system'] | lower }}/{{ download_artifact_goarch }}/kubectl" # noqa: yaml[line-length]
+kubectl_download_url: "https://cdn.dl.k8s.io/release/v{{ kubectl_version }}/bin/{{ ansible_facts['system'] | lower }}/{{ download_artifact_goarch }}/kubectl" # yamllint disable-line rule:line-length
 kubectl_download_dest: /usr/bin/kubectl
 kubectl_binary_checksum: "{{ kubectl_checksums[download_artifact_goarch][kubectl_version] }}"
 
diff --git a/roles/kubelet/defaults/main.yml b/roles/kubelet/defaults/main.yml
@@ -57,7 +57,7 @@ kubelet_checksums:
     1.32.8: d5527714fac08eac4c1ddcbd8a3c6db35f3acd335d43360219d733273b672cce
     1.33.4: 623329b1a5f4858e3a5406d3947807b75144f4e71dde11ef1a71362c3a8619cc
 
-kubelet_download_url: "https://cdn.dl.k8s.io/release/v{{ kubelet_version }}/bin/{{ ansible_facts['system'] | lower }}/{{ download_artifact_goarch }}/kubelet" # noqa: yaml[line-length]
+kubelet_download_url: "https://cdn.dl.k8s.io/release/v{{ kubelet_version }}/bin/{{ ansible_facts['system'] | lower }}/{{ download_artifact_goarch }}/kubelet" # yamllint disable-line rule:line-length
 kubelet_download_dest: /usr/bin/kubelet
 kubelet_binary_checksum: "{{ kubelet_checksums[download_artifact_goarch][kubelet_version] }}"
 
diff --git a/roles/kubernetes_upgrade_check/tasks/main.yml b/roles/kubernetes_upgrade_check/tasks/main.yml
@@ -31,12 +31,12 @@
     - name: Parse the ClusterConfiguration
       run_once: true
       ansible.builtin.set_fact:
-        kubernetes_upgrade_check_cluster_configuration: "{{ kubernetes_upgrade_check_kubeadm_config.resources[0].data.ClusterConfiguration | from_yaml }}" # noqa: yaml[line-length]
+        kubernetes_upgrade_check_cluster_configuration: "{{ kubernetes_upgrade_check_kubeadm_config.resources[0].data.ClusterConfiguration | from_yaml }}" # yamllint disable-line rule:line-length
 
     - name: Retrieve the current Kubernetes version
       run_once: true
       ansible.builtin.set_fact:
-        kubernetes_upgrade_check_cluster_version: "{{ kubernetes_upgrade_check_cluster_configuration.kubernetesVersion | regex_replace('^v', '') }}" # noqa: yaml[line-length]
+        kubernetes_upgrade_check_cluster_version: "{{ kubernetes_upgrade_check_cluster_configuration.kubernetesVersion | regex_replace('^v', '') }}" # yamllint disable-line rule:line-length
 
     - name: Extract major, minor, and patch versions
       run_once: true
@@ -55,7 +55,7 @@
           version. Please upgrade to the next minor version first.
       when:
         - kubernetes_upgrade_check_desired_major == kubernetes_upgrade_check_current_major
-        - ((kubernetes_upgrade_check_desired_minor | int) > (kubernetes_upgrade_check_current_minor | int + 1)) or (kubernetes_upgrade_check_desired_minor < kubernetes_upgrade_check_current_minor)  # noqa: yaml[line-length]
+        - ((kubernetes_upgrade_check_desired_minor | int) > (kubernetes_upgrade_check_current_minor | int + 1)) or (kubernetes_upgrade_check_desired_minor < kubernetes_upgrade_check_current_minor) # yamllint disable-line rule:line-length
 
     - name: Set fact if we need to upgrade
       ansible.builtin.set_fact:
