Skip to content

Commit 03ff326

Browse files
authored
Merge pull request #517 from vexxhost/switch-to-jsonpatch
fix: Cluster upgrade uses the right calls
2 parents f92bf5d + 6ffe62f commit 03ff326

File tree

8 files changed

+1166
-77
lines changed

8 files changed

+1166
-77
lines changed

Cargo.lock

Lines changed: 44 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,17 @@ edition = "2021"
55

66
[dependencies]
77
kube = { version = "0.98.0", features = ["runtime", "derive"] }
8-
k8s-openapi = { version = "0.24.0", features = ["latest"] }
9-
tokio = { version = "1.43.0", features = ["rt-multi-thread"] }
8+
k8s-openapi = { version = "0.24.0", features = ["schemars", "latest"] }
9+
tokio = { version = "1.43.0", features = ["macros", "rt-multi-thread"] }
1010
once_cell = "1.20.3"
1111
serde_json = "1.0.138"
1212
pythonize = "0.23.0"
1313
thiserror = "2.0.11"
14-
kube-core = "0.98.0"
1514
backoff = { version = "0.4.0", features = ["tokio"] }
15+
schemars = "0.8.21"
16+
serde = "1.0.218"
17+
pyo3-log = "0.12.1"
18+
log = "0.4.26"
1619

1720
[dependencies.pyo3]
1821
version = "0.23.1"

magnum_cluster_api/driver.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ def _create_cluster(self, context, cluster: magnum_objects.Cluster):
109109
cluster,
110110
skip_auto_scaling_release=True,
111111
)
112+
resources.Cluster(context, self.kube_client, self.k8s_api, cluster).apply(),
112113

113114
def _get_cluster_status_reason(self, capi_cluster):
114115
capi_cluster_status_reason = ""
@@ -385,6 +386,13 @@ def upgrade_cluster(
385386
resources.apply_cluster_from_magnum_cluster(
386387
context, self.kube_client, self.k8s_api, cluster
387388
)
389+
self.kube_client.update_cluster(
390+
"magnum-system",
391+
cluster.stack_id,
392+
resources.Cluster(
393+
context, self.kube_client, self.k8s_api, cluster
394+
).get_object(),
395+
)
388396

389397
# NOTE(mnaser): We do not save the cluster object here because the Magnum driver
390398
# will save the object that it passed to us here.

magnum_cluster_api/resources.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3043,7 +3043,6 @@ def apply_cluster_from_magnum_cluster(
30433043
ClusterServerGroups(context, cluster).apply()
30443044
ClusterResourcesConfigMap(context, api, pykube_api, cluster).apply()
30453045
ClusterResourceSet(api, cluster).apply()
3046-
Cluster(context, api, pykube_api, cluster).apply()
30473046

30483047
if not skip_auto_scaling_release and utils.get_auto_scaling_enabled(cluster):
30493048
ClusterAutoscalerHelmRelease(api, cluster).apply()

0 commit comments

Comments
 (0)