Skip to content
This repository was archived by the owner on Mar 21, 2025. It is now read-only.

Commit 29063c1

Browse files
committed
Add a couple of TODOs.
1 parent 95df8b5 commit 29063c1

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/language/tooling/Projects/ProjectConfiguration.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ static void Error(string message)
9494

9595
if (Path.IsPathFullyQualified(path))
9696
Error("'path' property, if present, must be relative.");
97+
98+
// TODO: It would be good to verify that the path does not contain any . or .. segments.
9799
}
98100

99101
var paths = ImmutableDictionary<ModulePath, string>.Empty;
@@ -121,6 +123,8 @@ static void Error(string message)
121123
if (Path.IsPathFullyQualified(dir))
122124
Error($"Directory path for module path '{prop.Name}' must be relative.");
123125

126+
// TODO: It would be good to verify that the path does not contain any . or .. segments.
127+
124128
paths = paths.SetItem(modPath, dir);
125129
}
126130
}

0 commit comments

Comments
 (0)