avoid using -z defs/undefs

alexrp · alexrp · commit 445adc22cdaa · 2025-10-14T12:22:01.000+02:00
I'm not sure why I originally thought this was a good idea, but it's problematic
on FreeBSD where an undefined reference to environ is expected.
diff --git a/src/sdk/ZigCompile.cs b/src/sdk/ZigCompile.cs
@@ -252,10 +252,9 @@ protected override string GenerateCommandLineCommands()
                 builder.AppendSwitchIfNotNull("-Wl,-soname,", TargetFileName);
             }
 
-            var (un, no) = AllowUndefinedSymbols ? ("un", string.Empty) : (string.Empty, "no-");
+            var no = AllowUndefinedSymbols ? string.Empty : "no-";
 
             // These flags are needed to cover Linux and Windows/macOS, respectively.
-            builder.AppendSwitch(isZig ? $"-z {un}defs" : $"-Wl,-z,{un}defs");
             builder.AppendSwitch(isZig ? $"-f{no}allow-shlib-undefined" : $"-Wl,--{no}allow-shlib-undefined");
         }
         else

Original file line number	Diff line number	Diff line change
`@@ -252,10 +252,9 @@ protected override string GenerateCommandLineCommands()`
`252`	`252`	`builder.AppendSwitchIfNotNull("-Wl,-soname,", TargetFileName);`
`253`	`253`	`}`
`254`	`254`
`255`		`- var (un, no) = AllowUndefinedSymbols ? ("un", string.Empty) : (string.Empty, "no-");`
	`255`	`+ var no = AllowUndefinedSymbols ? string.Empty : "no-";`
`256`	`256`
`257`	`257`	`// These flags are needed to cover Linux and Windows/macOS, respectively.`
`258`		`- builder.AppendSwitch(isZig ? $"-z {un}defs" : $"-Wl,-z,{un}defs");`
`259`	`258`	`builder.AppendSwitch(isZig ? $"-f{no}allow-shlib-undefined" : $"-Wl,--{no}allow-shlib-undefined");`
`260`	`259`	`}`
`261`	`260`	`else`