Use desktop-file-install To Install Launcher

[JavaScriptDude]

The method of deploying desktop files did not work on my Ubuntu 20.04 system.

I updated the install script to use desktop-file-install to deploy the my desktop files as documented in ArchWiki. The advantage of using desktop-file-install is that Gnome and possibly other XDG based systems will detect the file without the need for logout or reboot.

FYI, here is my updated installer:

#!/bin/bash

# install dependencies

if ! [ -z `which apt-get 2> /dev/null` ] && [ `nmcli networking` = "enabled" ] ; # Debian
then sudo apt-get install network-manager-openvpn network-manager-openvpn-gnome
fi

if ! [ -z `which dnf 2> /dev/null` ] && [ `nmcli networking` = "enabled" ]; # Fedora
then sudo dnf install NetworkManager-openvpn NetworkManager-openvpn-gnome
fi

if ! [ -z `which pacman 2> /dev/null` ] && [ `nmcli networking` = "enabled" ]; # Arch Linux
then sudo pacman -Sy networkmanager-openvpn
fi

current_dir=`pwd`

echo "[Desktop Entry]
Type=Application
Name=Nord VPN
Comment=NordVPN client
Path="$current_dir"/NordVPN
Exec="$current_dir"/NordVPN/launch_nord
Icon=nordvpnicon
Terminal=false
Categories=System" | sudo tee ./nordvpn.desktop > /dev/null

sudo chmod +x ./nordvpn.desktop

cp ./NordVPN/nordvpnicon.png $HOME/.local/share/icons/

desktop-file-install --dir=$HOME/.local/share/applications ./nordvpn.desktop

echo NordVPN-NetworkManager-Gui launcher installed in '~'/.local/share/applications

Notes:

• Version is the XDG version not the software version and was causing error
• Updated Categories to only include System as others were flagged as invalid