fix: explcit columns list in the select statement

Author: vgarvardt

.github/workflows/testing.yml

@@ -28,10 +28,14 @@ jobs:
           --health-retries 5
 
     steps:
-      - name: Set up Go
-        uses: actions/setup-go@v2
       - name: Check out code
         uses: actions/checkout@v3
+
+      - name: Set up Go
+        uses: actions/setup-go@v3
+        with:
+          go-version-file: ./go.mod
+
       - name: Run tests
         if: success()
         run: go test -timeout 60s -cover ./... -coverprofile=coverage.txt -covermode=atomic

Makefile

@@ -1,10 +1,9 @@
 lint:
 	@echo "$(OK_COLOR)==> Linting with golangci-lint$(NO_COLOR)"
-	@docker run --rm -v `pwd`:/app -w /app golangci/golangci-lint:v1.27.0 golangci-lint run -v
+	@docker run --rm -v `pwd`:/app -w /app golangci/golangci-lint:v1.54.2 golangci-lint run -v
 
 test:
 	@echo "$(OK_COLOR)==> Running tests using docker-compose deps$(NO_COLOR)"
-	@docker-compose up -d
-	@sleep 3 && \
-		PG_URI="postgres://test:test@`docker-compose port postgres 5432`/test?sslmode=disable" \
+	@docker compose up -d --wait
+	@PG_URI="postgres://test:test@`docker-compose port postgres 5432`/test?sslmode=disable" \
 		go test -timeout 60s -cover -coverprofile=coverage.txt -covermode=atomic ./...

client_store.go

@@ -57,10 +57,10 @@ func NewClientStore(adapter pgAdapter.Adapter, options ...ClientStoreOption) (*C
 func (s *ClientStore) initTable() error {
 	return s.adapter.Exec(context.Background(), fmt.Sprintf(`
 CREATE TABLE IF NOT EXISTS %[1]s (
-	id     TEXT  NOT NULL,
-	secret TEXT  NOT NULL,
-	domain TEXT  NOT NULL,
-	data   JSONB NOT NULL,
+	"id"     TEXT  NOT NULL,
+	"secret" TEXT  NOT NULL,
+	"domain" TEXT  NOT NULL,
+	"data"   JSONB NOT NULL,
 	CONSTRAINT %[1]s_pkey PRIMARY KEY (id)
 );
 `, s.tableName))
@@ -79,7 +79,7 @@ func (s *ClientStore) GetByID(ctx context.Context, id string) (oauth2.ClientInfo
 	}
 
 	var item ClientStoreItem
-	if err := s.adapter.SelectOne(ctx, &item, fmt.Sprintf("SELECT * FROM %s WHERE id = $1", s.tableName), id); err != nil {
+	if err := s.adapter.SelectOne(ctx, &item, fmt.Sprintf(`SELECT "id", "secret", "domain", "data" FROM "%s" WHERE "id" = $1`, s.tableName), id); err != nil {
 		return nil, err
 	}
 
@@ -95,7 +95,7 @@ func (s *ClientStore) Create(info oauth2.ClientInfo) error {
 
 	return s.adapter.Exec(
 		context.Background(),
-		fmt.Sprintf("INSERT INTO %s (id, secret, domain, data) VALUES ($1, $2, $3, $4)", s.tableName),
+		fmt.Sprintf(`INSERT INTO %s ("id", "secret", "domain", "data") VALUES ($1, $2, $3, $4)`, s.tableName),
 		info.GetID(),
 		info.GetSecret(),
 		info.GetDomain(),

docker-compose.yml

@@ -3,7 +3,7 @@ version: "3"
 
 services:
   postgres:
-    image: postgres:9.6-alpine
+    image: postgres:11-alpine
     ports:
       - '5432'
     environment:
@@ -14,7 +14,7 @@ services:
     tmpfs:
       - /var/lib/postgresql/data
     healthcheck:
-      test: ["CMD", "pg_isready"]
+      test: [ "CMD", "pg_isready" ]
       interval: 10s
       timeout: 5s
       retries: 5