Skip to content

Commit 1c349c5

Browse files
alakeshplamenmpetrov
authored andcommitted
Fix for integ-test failure in docker based example.
TEST_POOL is used to pass a pool name for the example we use for testing firecracker-containerd inside the docker container. However in the Makefile TEST_POOL is passed empty to the thinpool.sh thich causes the script to return without creating any pool. Similarly in the entrypoint.sh which is run by the docker container we end up using an empty string for pool_name to be added in the generated devmapper.toml file. This leads to an issue where firecracker-containerd starts without devmapper configiured and hence the taskworkflow program fails as it passed devicemapper as the snapshotter to use for this example. The fix is to have a default value for TEST_POOL in Makefile. Buildkite is not impacted because there we explicitly pass the build number as the test pool name. Signed-off-by: Alakesh Haloi <[email protected]>
1 parent 7ba0c4e commit 1c349c5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

examples/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ TEST_GATEWAY?=172.16.0.1
5252
TEST_IP?=172.16.0.2
5353
TEST_SUBNET?=/24
5454
FICD_DM_VOLUME_GROUP?=
55-
TEST_POOL?=
55+
TEST_POOL?=testpool
5656
testtap:
5757
ip link add br0 type bridge
5858
ip tuntap add tap0 mode tap

0 commit comments

Comments
 (0)