Merge pull request firecracker-microvm#486 from kzys/fast-test

Run some subtests in parallel to make integ-test faster

Author: kzys

runtime/jailer_integ_test.go

@@ -40,15 +40,18 @@ import (
 func TestJailer_Isolated(t *testing.T) {
 	prepareIntegTest(t)
 	t.Run("Without Jailer", func(t *testing.T) {
+		t.Parallel()
 		testJailer(t, nil)
 	})
 	t.Run("With Jailer", func(t *testing.T) {
+		t.Parallel()
 		testJailer(t, &proto.JailerConfig{
 			UID: 300001,
 			GID: 300001,
 		})
 	})
 	t.Run("With Jailer and bind-mount", func(t *testing.T) {
+		t.Parallel()
 		testJailer(t, &proto.JailerConfig{
 			UID:               300001,
 			GID:               300001,
@@ -118,9 +121,9 @@ func testJailer(t *testing.T, jailerConfig *proto.JailerConfig) {
 	require.NoError(err)
 
 	c, err := client.NewContainer(ctx,
-		"container",
+		vmID+"-container",
 		containerd.WithSnapshotter(defaultSnapshotterName),
-		containerd.WithNewSnapshot("snapshot", image),
+		containerd.WithNewSnapshot(vmID+"-snapshot", image),
 		containerd.WithNewSpec(
 			oci.WithProcessArgs(
 				"/bin/sh", "-c", "echo hello && cat /mnt/in-container/dir/hello",

runtime/service_integ_test.go

@@ -1921,10 +1921,11 @@ func TestCreateVM_Isolated(t *testing.T) {
 	fcClient := fccontrol.NewFirecrackerClient(pluginClient.Client())
 
 	type subtest struct {
-		name     string
-		request  proto.CreateVMRequest
-		validate func(*testing.T, error)
-		stopVM   bool
+		name                    string
+		request                 proto.CreateVMRequest
+		validate                func(*testing.T, error)
+		validateUsesFindProcess bool
+		stopVM                  bool
 	}
 
 	subtests := []subtest{
@@ -1951,7 +1952,8 @@ func TestCreateVM_Isolated(t *testing.T) {
 				require.NoError(t, err, "failed waiting for expected firecracker process %q to come up", firecrackerProcessName)
 				require.Len(t, firecrackerProcesses, 0, "expected only no firecracker processes to exist")
 			},
-			stopVM: false,
+			validateUsesFindProcess: true,
+			stopVM:                  false,
 		},
 		{
 			name: "Slow Root FS",
@@ -1983,6 +1985,12 @@ func TestCreateVM_Isolated(t *testing.T) {
 	}
 
 	runTest := func(t *testing.T, request proto.CreateVMRequest, s subtest) {
+		// If this test checks the number of the processes on the host
+		// (e.g. the number of Firecracker processes), running the test with
+		// others in parallel messes up the result.
+		if !s.validateUsesFindProcess {
+			t.Parallel()
+		}
 		vmID := testNameToVMID(t.Name())
 
 		tempDir, err := ioutil.TempDir("", vmID)