Skip to content

Commit d6e4a75

Browse files
committed
resolve comments for pr
Signed-off-by: Amory Hoste <[email protected]>
1 parent 63f16b2 commit d6e4a75

File tree

2 files changed

+69
-68
lines changed

2 files changed

+69
-68
lines changed

proto/types.pb.go

Lines changed: 65 additions & 65 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

proto/types.proto

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,12 +98,13 @@ message IPConfiguration {
9898
message FirecrackerMachineConfiguration {
9999
string CPUTemplate = 1; // Specifies the cpu template. Example: "T2" or "C3"
100100
bool HtEnabled = 2; // Specifies if hyper-threading should be enabled
101-
bool TrackDirtyPages = 3; // Specified if dirty-page-tracking should be enabled.
102101
// Specifies the memory size of VM
103102
// This lets us create a Firecracker VM of up to 4096 TiB, which
104103
// for a microVM should be large enough
105-
uint32 MemSizeMib = 4;
106-
uint32 VcpuCount = 5; // Specifies the number of vCPUs for the VM
104+
uint32 MemSizeMib = 3;
105+
uint32 VcpuCount = 4; // Specifies the number of vCPUs for the VM
106+
bool TrackDirtyPages = 5; // Specified if dirty-page-tracking should be enabled.
107+
107108
}
108109

109110
// Message to specify the block device config for a Firecracker VM

0 commit comments

Comments
 (0)