Skip to content

Commit 46b208f

Browse files
committed
YAMLSelector bugfix for Knative RPS
Signed-off-by: Lazar Cvetković <l.cvetkovic.997@gmail.com>
1 parent a35efe9 commit 46b208f

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

cmd/loader.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,6 @@ func runTraceMode(cfg *config.LoaderConfiguration, readIATFromFile bool, writeIA
207207
TraceGranularity: parseTraceGranularity(cfg),
208208
TraceDuration: durationToParse,
209209

210-
YAMLPath: yamlPath,
211210
TestMode: false,
212211

213212
Functions: functions,
@@ -218,7 +217,7 @@ func runTraceMode(cfg *config.LoaderConfiguration, readIATFromFile bool, writeIA
218217
return
219218
}
220219

221-
log.Infof("Using %s as a service YAML specification file.\n", experimentDriver.Configuration.YAMLPath)
220+
log.Infof("Using %s as a service YAML specification file.\n", yamlPath)
222221

223222
experimentDriver.GenerateSpecification()
224223
experimentDriver.ReadOrWriteFileSpecification(writeIATsToFile, readIATFromFile)
@@ -227,6 +226,7 @@ func runTraceMode(cfg *config.LoaderConfiguration, readIATFromFile bool, writeIA
227226

228227
func runRPSMode(cfg *config.LoaderConfiguration, readIATFromFile bool, writeIATsToFile bool) {
229228
experimentDuration := determineDurationToParse(cfg.ExperimentDuration, cfg.WarmupDuration)
229+
yamlPath := parseYAMLSpecification(cfg)
230230

231231
rpsTarget := cfg.RpsTarget
232232
coldStartPercentage := cfg.RpsColdStartRatioPercentage
@@ -246,9 +246,7 @@ func runRPSMode(cfg *config.LoaderConfiguration, readIATFromFile bool, writeIATs
246246

247247
DirigentConfiguration: dirigentConfig,
248248

249-
YAMLPath: parseYAMLSpecification(cfg),
250-
251-
Functions: generator.CreateRPSFunctions(cfg, dirigentConfig, warmFunction, warmStartCount, coldFunctions, coldStartCount),
249+
Functions: generator.CreateRPSFunctions(cfg, dirigentConfig, warmFunction, warmStartCount, coldFunctions, coldStartCount, yamlPath),
252250
})
253251

254252
// Skip experiments execution during dry run mode

pkg/config/configuration.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ type Configuration struct {
1515
// TraceDuration In minutes.
1616
TraceDuration int
1717

18-
YAMLPath string
1918
TestMode bool
2019

2120
Functions []*common.Function

pkg/generator/rps.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ func GenerateColdStartFunctions(experimentDuration int, rpsTarget float64, coold
106106
}
107107

108108
func CreateRPSFunctions(cfg *config.LoaderConfiguration, dcfg *config.DirigentConfig, warmFunction common.IATArray, warmFunctionCount []int,
109-
coldFunctions []common.IATArray, coldFunctionCount [][]int) []*common.Function {
109+
coldFunctions []common.IATArray, coldFunctionCount [][]int, yamlPath string) []*common.Function {
110110
var result []*common.Function
111111

112112
busyLoopFor := ComputeBusyLoopPeriod(cfg.RpsMemoryMB)
@@ -139,6 +139,7 @@ func CreateRPSFunctions(cfg *config.LoaderConfiguration, dcfg *config.DirigentCo
139139
RuntimeSpecification: createRuntimeSpecification(len(warmFunction), cfg.RpsRuntimeMs, cfg.RpsMemoryMB),
140140
},
141141

142+
YAMLPath: yamlPath,
142143
ColdStartBusyLoopMs: busyLoopFor,
143144
})
144145
}
@@ -170,6 +171,7 @@ func CreateRPSFunctions(cfg *config.LoaderConfiguration, dcfg *config.DirigentCo
170171
RuntimeSpecification: createRuntimeSpecification(len(coldFunctions[i]), cfg.RpsRuntimeMs, cfg.RpsMemoryMB),
171172
},
172173

174+
YAMLPath: yamlPath,
173175
ColdStartBusyLoopMs: busyLoopFor,
174176
})
175177
}

0 commit comments

Comments
 (0)