Migrates remaining tests to github runners

Signed-off-by: Mohamed L. Karaoui <[email protected]>

Author: moharaka

.github/workflows/cri_tests.yml

@@ -16,7 +16,7 @@ jobs:
     env:
       GITHUB_RUN_ID: ${{ github.run_id }}
       GITHUB_VHIVE_ARGS: "-dbg"
-    runs-on: ${{ fromJSON(format('["self-hosted", "{0}-cri"]', inputs.sandbox)) }}
+    runs-on: ubuntu-24.04
 
     steps:
       - name: Host Info

.github/workflows/unit_tests.yml

@@ -69,7 +69,7 @@ jobs:
   
   profile-unit-test:
     name: "Unit test: profile unit test"
-    runs-on: [self-hosted, profile]
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       matrix:

scripts/github_runner/setup_cri_test_env.sh

@@ -35,6 +35,9 @@ fi
 SANDBOX=$1
 VHIVE_ROOT="$(git rev-parse --show-toplevel)"
 
+# Set up the node with proper firecracker-containerd installation
+$VHIVE_ROOT/scripts/setup_tool -vhive-repo-dir $VHIVE_ROOT setup_node $SANDBOX
+
 $VHIVE_ROOT/scripts/setup_tool -vhive-repo-dir $VHIVE_ROOT start_onenode_vhive_cluster $SANDBOX
 # $VHIVE_ROOT/scripts/cloudlab/start_onenode_vhive_cluster.sh "$SANDBOX"
 sleep 30s

scripts/setup_firecracker_containerd.sh

@@ -60,3 +60,7 @@ if [ 64 -eq ${#CONTAINERID} ]; then
 fi
 
 sudo cp $CONFIGS/firecracker-runtime.json /etc/containerd/
+
+# Create directory and symlink for CRI socket
+sudo mkdir -p /etc/vhive-cri
+sudo ln -sf /run/firecracker-containerd/containerd.sock /etc/vhive-cri/vhive-cri.sock

snapshotting/manager.go

@@ -41,15 +41,19 @@ type SnapshotManager struct {
 }
 
 // Snapshot identified by VM id
-
 func NewSnapshotManager(baseFolder string) *SnapshotManager {
 	manager := new(SnapshotManager)
 	manager.snapshots = make(map[string]*Snapshot)
 	manager.baseFolder = baseFolder
 
-	// Clean & init basefolder
-	_ = os.RemoveAll(manager.baseFolder)
-	_ = os.MkdirAll(manager.baseFolder, os.ModePerm)
+	if err := os.RemoveAll(manager.baseFolder); err != nil {
+		log.Printf("Failed to clean base folder: %v", err)
+		return nil
+	}
+	if err := os.MkdirAll(manager.baseFolder, 0755); err != nil {
+		log.Printf("Failed to create base folder: %v", err)
+		return nil
+	}
 
 	return manager
 }