Buttons text scaling but not the button layout in Project Property page

[ShahzaibIbrahim]

Moving from Secondary (200) to Primary (150) Project -> Properties -> Save actions. Only with Auto Scale = Int200

[ShahzaibIbrahim]

Related to: #99

[ShahzaibIbrahim]

package org.eclipse.swt.examples.controlexample;

import org.eclipse.jface.dialogs.Dialog;
import org.eclipse.swt.SWT;
import org.eclipse.swt.graphics.FontMetrics;
import org.eclipse.swt.graphics.GC;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.graphics.Point;
import org.eclipse.swt.layout.GridData;
import org.eclipse.swt.layout.GridLayout;
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Control;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Shell;

public class ButtonWidthHintExample extends Dialog {

    protected ButtonWidthHintExample(Shell parentShell) {
        super(parentShell);
    }

    @Override
    protected void configureShell(Shell shell) {
        super.configureShell(shell);
        shell.setText("JFace Dialog Example");
    }

    @Override
    protected Composite createDialogArea(Composite parent) {
        Composite composite = (Composite) super.createDialogArea(parent);
        composite.setLayout(new GridLayout(1, false));

        // Load Image
        Display display = parent.getDisplay();
        Image image = new Image(display, ButtonWidthHintExample.class.getResourceAsStream("openfolder.gif"));

        // Create Button with Image
        Button button = new Button(composite, SWT.PUSH);
        button.setImage(image);

        // Set LayoutData for the Button
        GridData gd = new GridData();
        gd.widthHint = image.getBounds().width * 3; // Set widthHint to 3 times the image width
        button.setLayoutData(gd);

        // Create another Button
        Button button2 = new Button(composite, SWT.PUSH);
        button2.setText("Reset && Apply");
        setButtonLayoutData(button2);

        // Dispose image when dialog is disposed
        composite.addDisposeListener(e -> image.dispose());

        return composite;
    }

    public static void main(String[] args) {
        // Create the Display and Main Shell
        Display display = new Display();
        Shell shell = new Shell(display);
        shell.setLayout(new GridLayout(1, false));
        shell.setText("Main Shell");

        // Create a Button in the main shell to open the dialog
        Button openDialogButton = new Button(shell, SWT.PUSH);
        openDialogButton.setText("Open Dialog");
        openDialogButton.setLayoutData(new GridData(SWT.CENTER, SWT.CENTER, true, true));

        // Add Listener to open the dialog
        openDialogButton.addListener(SWT.Selection, e -> {
            ButtonWidthHintExample dialog = new ButtonWidthHintExample(shell);
            dialog.open();
        });

        // Open Main Shell
        shell.setSize(400, 300);
        shell.open();

        // Event loop
        while (!shell.isDisposed()) {
            if (!display.readAndDispatch()) {
                display.sleep();
            }
        }

        display.dispose();
    }

    @Override
    protected void setButtonLayoutData(Button button) {
        GridData data = new GridData(GridData.HORIZONTAL_ALIGN_FILL);
        int widthHint = convertHorizontalDLUsToPixels(61, button);
        Point minSize = button.computeSize(SWT.DEFAULT, SWT.DEFAULT, true);
        data.widthHint = Math.max(widthHint, minSize.x);
        button.setLayoutData(data);
    }

    protected int convertHorizontalDLUsToPixels(int dlus, Control control) {
        GC gc = new GC(control);
        gc.setFont(control.getFont());
        FontMetrics fontMetrics = gc.getFontMetrics();
        gc.dispose();

        // Test for failure to initialize for backward compatibility
        if (fontMetrics == null) {
            return 0;
        }
        return convertHorizontalDLUsToPixels(fontMetrics, dlus);
    }

    public static int convertHorizontalDLUsToPixels(FontMetrics fontMetrics, int dlus) {
        // Round to the nearest pixel
        return (int) ((fontMetrics.getAverageCharacterWidth() * dlus + 4 / 2) / 4);
    }
}

[ShahzaibIbrahim]

There could be 2 solutions as discussed. But there is a dilemma in both of them. I will try to add my findings here so that we can discuss them later.

1. Use NativeZoom instead of CorrectedZoom for wHint and hHint to match the zoom for the font. But that can bring inconsistencies with our other implementation.
2. Implement a dpi change listener in all implementation of dialog but that will mean that we are handling the fix on the client side. Also we have a lot of implementation of Dialog in the Platform.