Shell icon is blurry

[fedejeanne]

When activating the Monitor-specific UI scaling too.

This is how it looks like:

You can see that, for example, the font looks better. I tried starting the IDE in monitors with different zoom levels and it always looks blurry.

Eclipse-Version: I20250219-1800

[fedejeanne]

As I mentioned in today's call: here is the branch that changes the algorithm to avoid sorting.

eclipse-platform/eclipse.platform.swt@master...vi-eclipse:eclipse.platform.swt:fix_blurry_shell_icon

It's not a fundamental change and it doesn't really spare us creating ImageDatas.
The part I don't quite get is the comparison using the pixel depth (taken directly from the old algorithm). I marked it with a TODO.

There is no PR yet, I can create one when the development for M1 is open.

[HeikoKlare]

We had agree to first clean up the code before applying the fix to make it comprehensible. This has not been done. Can we please still clean up the code to allow to understand what happens here and whether this ia proper fix?

[fedejeanne]

We had agree to first clean up the code before applying the fix to make it comprehensible. This has not been done. Can we please still clean up the code to allow to understand what happens here and whether this ia proper fix?

I said I was going to shift the conversation about rewriting the algorithm to after the fix. I didn't say I would postpone the fix. In any case, I created the (draft) PR for the rewrite --> eclipse-platform/eclipse.platform.swt#1879