Refactor Display::getSystemImage to return dynamically scalable images

[akoch-yatta]

Currently Display::getSystemImage returns an image, that is directly initialized with the image handle. If this images will be scaled later, it will be stretched or shrunken and either be blurry or have sharp edges. The method should be refactored to return an Image that is using an ImageDataProvider that is refetching the image handle from the OS in the correct zoom, if necessary.

[akoch-yatta]

	static int ICON_SIZE_AT_100;
	
	if (OS.WIN32_BUILD >= OS.WIN32_BUILD_WIN10_1607) {
		ICON_SIZE_AT_100 = OS.GetSystemMetricsForDpi(OS.SM_CXSMICON, 100);
	} else {
		ICON_SIZE_AT_100 = 16;
	}
	
	int scaledIconSize = DPIUtil.autoScaleUp(ICON_SIZE_AT_100, deviceZoom);
	OS.LoadImage (OS.GetLibraryHandle (), OS.OIC_QUES, OS.IMAGE_ICON, scaledIconSize, scaledIconSize, 0);

[ShahzaibIbrahim]

The Image object always returns the different handle then the one we get when we create an Icon. For this case whatever zoom level you pass for xDesired and yDesired, the image will scale it self not taking ImageDataProvider we use in account. I will push the changes that I have made for this thus far. We may come back to this ticket later.

The Branch name is preevision-evaluation-65

[akoch-yatta]

To reproduce this issue:

1. Have monitor specific scaling

2. make sure org.eclipse.ui.examples.readmetool is in your runtime

3. Create readme file and select it (1)

4. Press the bottom (2)
   

5. Move the dialog to a monitor with another zoom