lint + comment

Author: abe-winter

Makefile

@@ -102,6 +102,7 @@ upload-installer:
 .PHONY: lint-ps
 lint-ps:
 	# I installed from .deb in releases here https://github.com/PowerShell/PowerShell
+	# note: this linter is not incredibly useful; for example it won't catch some missing reference errors. Don't over-rely
 	pwsh -Command 'if (-not (Get-Module PSScriptAnalyzer -ListAvailable)) { Install-Module PSScriptAnalyzer -Scope CurrentUser -Force -ErrorAction Stop }; Invoke-ScriptAnalyzer -Path windows-installer-agent.ps1 -Settings PSScriptAnalyzerSettings.psd1 -Severity Warning,Error -EnableExit; Invoke-ScriptAnalyzer -Path windows-uninstall-agent.ps1 -Settings PSScriptAnalyzerSettings.psd1 -Severity Warning,Error -EnableExit'
 
 .PHONY: windows-installer

version_control.go

@@ -347,7 +347,6 @@ func (c *VersionCache) UpdateBinary(ctx context.Context, binary string) (bool, e
 				expectedMimes = []string{"application/vnd.microsoft.portable-executable"}
 			}
 
-			//nolint:goconst
 			if runtime.GOOS == "darwin" {
 				expectedMimes = []string{"application/x-mach-binary"}
 			}
@@ -409,7 +408,6 @@ func (c *VersionCache) getProtectedFilesAndCleanVersions(ctx context.Context, ma
 	// add protection for the current symlinked binaries
 	for _, path := range []string{"viam-agent", "viam-server"} {
 		if runtime.GOOS == "windows" {
-			//nolint:goconst
 			path += ".exe"
 		}