Skip to content

Commit 36babcc

Browse files
committed
Remove redundant comment
1 parent d16c6c7 commit 36babcc

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/viam/sdk/components/private/camera_client.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ Camera::image_collection from_proto(const viam::component::camera::v1::GetImages
5656
raw_image.bytes = bytes;
5757
// TODO(RSDK-11733): This is a temporary fix to support handling both the format and mime
5858
// type. We will remove this once we remove the format field from the proto.
59-
// We will remove this once we remove the format field from the proto.
6059
if (!img.mime_type().empty()) {
6160
raw_image.mime_type = img.mime_type();
6261
} else {
@@ -134,8 +133,10 @@ Camera::image_collection CameraClient::get_images(std::vector<std::string> filte
134133
return make_client_helper(this, *stub_, &StubType::GetImages)
135134
.with(extra,
136135
[&](auto& request) {
137-
for (const auto& source_name : filter_source_names) {
138-
*request.add_filter_source_names() = source_name;
136+
if (!filter_source_names.empty()) {
137+
request.mutable_filter_source_names()->Add(
138+
std::make_move_iterator(filter_source_names.begin()),
139+
std::make_move_iterator(filter_source_names.end()));
139140
}
140141
})
141142
.invoke([](auto& response) { return from_proto(response); });

0 commit comments

Comments
 (0)