use VIAM_SDK macro prefix

lia-viam · lia-viam · commit 40b540025479 · 2025-03-20T11:48:34.000-04:00
diff --git a/src/viam/examples/modules/complex/main.cpp b/src/viam/examples/modules/complex/main.cpp
@@ -48,8 +48,8 @@ int main(int argc, char** argv) {
         [](Dependencies deps, ResourceConfig cfg) { return std::make_unique<MyGizmo>(deps, cfg); },
         MyGizmo::validate);
 
-    // Write general log statements with the VIAM_LOG macro
-    VIAM_LOG(info) << "Registered mybase and mygizmo";
+    // Write general log statements with the VIAM_SDK_LOG macro
+    VIAM_SDK_LOG(info) << "Registered mybase and mygizmo";
 
     Model mysummation_model("viam", "summation", "mysummation");
 
diff --git a/src/viam/examples/modules/simple/main.cpp b/src/viam/examples/modules/simple/main.cpp
@@ -83,8 +83,8 @@ int main(int argc, char** argv) try {
     // any other C++ SDK objects and stays alive until all Viam C++ SDK objects are destroyed.
     Instance inst;
 
-    // Write general log statements with the VIAM_LOG macro
-    VIAM_LOG(info) << "Starting up simple sensor module";
+    // Write general log statements with the VIAM_SDK_LOG macro
+    VIAM_SDK_LOG(info) << "Starting up simple sensor module";
 
     Model mysensor_model("viam", "sensor", "mysensor");
 
diff --git a/src/viam/sdk/common/client_helper.cpp b/src/viam/sdk/common/client_helper.cpp
@@ -14,8 +14,8 @@ namespace sdk {
 namespace client_helper_details {
 
 [[noreturn]] void errorHandlerReturnedUnexpectedly(const ::grpc::Status* status) noexcept {
-    VIAM_LOG(fatal) << "ClientHelper error handler callback returned instead of throwing: "
-                    << status->error_message() << '(' << status->error_details() << ')';
+    VIAM_SDK_LOG(fatal) << "ClientHelper error handler callback returned instead of throwing: "
+                        << status->error_message() << '(' << status->error_details() << ')';
     std::abort();
 }
 
diff --git a/src/viam/sdk/log/logging.cpp b/src/viam/sdk/log/logging.cpp
@@ -55,7 +55,7 @@ log_level level_from_string(std::string level) {
         return ll::fatal;
     }
 
-    VIAM_LOG(warn) << "Returning unknown log level `" << level << "` as info";
+    VIAM_SDK_LOG(warn) << "Returning unknown log level `" << level << "` as info";
     return ll::info;
 }
 
@@ -132,11 +132,11 @@ void LogManager::init_logging() {
     console_sink_->set_formatter(fmt);
 
     boost::log::core::get()->add_sink(console_sink_);
-    VIAM_LOG(debug) << "Initialized console logging";
+    VIAM_SDK_LOG(debug) << "Initialized console logging";
 }
 
 void LogManager::disable_console_logging() {
-    VIAM_LOG(debug) << "Disabling console logging";
+    VIAM_SDK_LOG(debug) << "Disabling console logging";
 
     // Set a filter which ignores all console logs unless they contain a console force flag which is
     // set to true.
diff --git a/src/viam/sdk/log/logging.hpp b/src/viam/sdk/log/logging.hpp
@@ -134,7 +134,7 @@ BOOST_LOG_ATTRIBUTE_KEYWORD_TYPE(attr_time,
                                  "TimeStamp",
                                  boost::log::attributes::local_clock::value_type);
 
-#define VIAM_LOG_IMPL(lg, level)                                                     \
+#define VIAM_SDK_LOG_IMPL(lg, level)                                                 \
     BOOST_LOG_SEV((lg), ::viam::sdk::log_level::level)                               \
         << ::boost::log::add_value(::viam::sdk::attr_file_type{},                    \
                                    ::viam::sdk::log_detail::trim_filename(__FILE__)) \
@@ -144,15 +144,15 @@ BOOST_LOG_ATTRIBUTE_KEYWORD_TYPE(attr_time,
 /// @ingroup Log
 ///
 /// Use this macro to generate log messages pertaining to the SDK at large.
-#define VIAM_LOG(level) VIAM_LOG_IMPL(::viam::sdk::LogManager::get().global_logger(), level)
+#define VIAM_SDK_LOG(level) VIAM_SDK_LOG_IMPL(::viam::sdk::LogManager::get().global_logger(), level)
 
 /// @brief Log macro for resource-level logs.
 /// @ingroup Log
 ///
 /// This macro can only be called from the definition of a member function of a class inheriting
 /// @ref Resource. It will log messages to the log source of that specific resource, allowing
 /// resource-level log filtering.
-#define VIAM_RESOURCE_LOG(level) VIAM_LOG_IMPL(this->logger_, level)
+#define VIAM_RESOURCE_LOG(level) VIAM_SDK_LOG_IMPL(this->logger_, level)
 
 }  // namespace sdk
 }  // namespace viam
diff --git a/src/viam/sdk/module/handler_map.cpp b/src/viam/sdk/module/handler_map.cpp
@@ -64,7 +64,7 @@ HandlerMap_ from_proto_impl<module::v1::HandlerMap>::operator()(
             try {
                 hm.add_model(Model::from_str(mod), handle);
             } catch (const std::exception& ex) {
-                VIAM_LOG(error) << "Error " << ex.what() << " processing model " + mod;
+                VIAM_SDK_LOG(error) << "Error " << ex.what() << " processing model " + mod;
             }
         }
     }
diff --git a/src/viam/sdk/module/service.cpp b/src/viam/sdk/module/service.cpp
@@ -109,7 +109,7 @@ struct ModuleService::ServiceImpl : viam::module::v1::ModuleService::Service {
         try {
             Stoppable::stop_if_stoppable(res);
         } catch (const std::exception& err) {
-            VIAM_LOG(error) << "unable to stop resource: " << err.what();
+            VIAM_SDK_LOG(error) << "unable to stop resource: " << err.what();
         }
 
         const std::shared_ptr<const ModelRegistration> reg =
@@ -170,7 +170,7 @@ struct ModuleService::ServiceImpl : viam::module::v1::ModuleService::Service {
         try {
             Stoppable::stop_if_stoppable(res);
         } catch (const std::exception& err) {
-            VIAM_LOG(error) << "unable to stop resource: " << err.what();
+            VIAM_SDK_LOG(error) << "unable to stop resource: " << err.what();
         }
 
         manager->remove(name);
@@ -247,14 +247,14 @@ ModuleService::ModuleService(int argc,
 
 ModuleService::~ModuleService() {
     // TODO(RSDK-5509): Run registered cleanup functions here.
-    VIAM_LOG(info) << "Shutting down gracefully.";
+    VIAM_SDK_LOG(info) << "Shutting down gracefully.";
     server_->shutdown();
 
     if (parent_) {
         try {
             parent_->close();
         } catch (const std::exception& exc) {
-            VIAM_LOG(error) << exc.what();
+            VIAM_SDK_LOG(error) << exc.what();
         }
     }
 }
@@ -272,8 +272,8 @@ void ModuleService::serve() {
     module_->set_ready();
     server_->start();
 
-    VIAM_LOG(info) << "Module listening on " << module_->addr();
-    VIAM_LOG(info) << "Module handles the following API/model pairs:\n" << module_->handles();
+    VIAM_SDK_LOG(info) << "Module listening on " << module_->addr();
+    VIAM_SDK_LOG(info) << "Module handles the following API/model pairs:\n" << module_->handles();
 
     signal_manager_.wait();
 }
diff --git a/src/viam/sdk/resource/resource_manager.cpp b/src/viam/sdk/resource/resource_manager.cpp
@@ -50,7 +50,7 @@ void ResourceManager::replace_all(
         try {
             do_add(resource.first, resource.second);
         } catch (std::exception& exc) {
-            VIAM_LOG(error) << "Error replacing all resources" << exc.what();
+            VIAM_SDK_LOG(error) << "Error replacing all resources" << exc.what();
             return;
         }
     }
@@ -95,7 +95,7 @@ void ResourceManager::add(const Name& name, std::shared_ptr<Resource> resource)
     try {
         do_add(name, std::move(resource));
     } catch (std::exception& exc) {
-        VIAM_LOG(error) << "Error adding resource to subtype service: " << exc.what();
+        VIAM_SDK_LOG(error) << "Error adding resource to subtype service: " << exc.what();
     }
 };
 
@@ -132,7 +132,7 @@ void ResourceManager::remove(const Name& name) {
     try {
         do_remove(name);
     } catch (std::exception& exc) {
-        VIAM_LOG(error) << "unable to remove resource: " << exc.what();
+        VIAM_SDK_LOG(error) << "unable to remove resource: " << exc.what();
     };
 };
 
@@ -142,7 +142,8 @@ void ResourceManager::replace_one(const Name& name, std::shared_ptr<Resource> re
         do_remove(name);
         do_add(name, std::move(resource));
     } catch (std::exception& exc) {
-        VIAM_LOG(error) << "failed to replace resource " << name.to_string() << ": " << exc.what();
+        VIAM_SDK_LOG(error) << "failed to replace resource " << name.to_string() << ": "
+                            << exc.what();
     }
 }
 
diff --git a/src/viam/sdk/robot/client.cpp b/src/viam/sdk/robot/client.cpp
@@ -121,9 +121,9 @@ RobotClient::~RobotClient() {
         try {
             this->close();
         } catch (const std::exception& e) {
-            VIAM_LOG(error) << "Received err while closing RobotClient: " << e.what();
+            VIAM_SDK_LOG(error) << "Received err while closing RobotClient: " << e.what();
         } catch (...) {
-            VIAM_LOG(error) << "Received unknown err while closing RobotClient";
+            VIAM_SDK_LOG(error) << "Received unknown err while closing RobotClient";
         }
     }
 }
@@ -150,7 +150,7 @@ std::vector<RobotClient::operation> RobotClient::get_operations() {
 
     grpc::Status const response = impl_->stub_->GetOperations(ctx, req, &resp);
     if (is_error_response(response)) {
-        VIAM_LOG(error) << "Error getting operations: " << response.error_message();
+        VIAM_SDK_LOG(error) << "Error getting operations: " << response.error_message();
     }
 
     for (int i = 0; i < resp.operations().size(); ++i) {
@@ -168,7 +168,7 @@ void RobotClient::cancel_operation(std::string id) {
     req.set_id(id);
     const grpc::Status response = impl_->stub_->CancelOperation(ctx, req, &resp);
     if (is_error_response(response)) {
-        VIAM_LOG(error) << "Error canceling operation with id " << id;
+        VIAM_SDK_LOG(error) << "Error canceling operation with id " << id;
     }
 }
 
@@ -181,7 +181,7 @@ void RobotClient::block_for_operation(std::string id) {
 
     const grpc::Status response = impl_->stub_->BlockForOperation(ctx, req, &resp);
     if (is_error_response(response)) {
-        VIAM_LOG(error) << "Error blocking for operation with id " << id;
+        VIAM_SDK_LOG(error) << "Error blocking for operation with id " << id;
     }
 }
 
@@ -192,7 +192,7 @@ void RobotClient::refresh() {
 
     const grpc::Status response = impl_->stub_->ResourceNames(ctx, req, &resp);
     if (is_error_response(response)) {
-        VIAM_LOG(error) << "Error getting resource names: " << response.error_message();
+        VIAM_SDK_LOG(error) << "Error getting resource names: " << response.error_message();
     }
 
     std::unordered_map<Name, std::shared_ptr<Resource>> new_resources;
@@ -216,8 +216,8 @@ void RobotClient::refresh() {
                 const Name name_({name.namespace_(), name.type(), name.subtype()}, "", name.name());
                 new_resources.emplace(name_, rpc_client);
             } catch (const std::exception& exc) {
-                VIAM_LOG(debug) << "Error registering component " << name.subtype() << ": "
-                                << exc.what();
+                VIAM_SDK_LOG(debug)
+                    << "Error registering component " << name.subtype() << ": " << exc.what();
             }
         }
     }
@@ -281,9 +281,9 @@ void RobotClient::log(const std::string& name,
     if (is_error_response(response)) {
         // Manually override to force this to get logged to console so we don't set off an infinite
         // loop
-        VIAM_LOG(error) << boost::log::add_value(sdk::impl::attr_console_force_type{}, true)
-                        << "Error sending log message over grpc: " << response.error_message()
-                        << response.error_details();
+        VIAM_SDK_LOG(error) << boost::log::add_value(sdk::impl::attr_console_force_type{}, true)
+                            << "Error sending log message over grpc: " << response.error_message()
+                            << response.error_details();
     }
 }
 
@@ -339,7 +339,7 @@ std::vector<RobotClient::frame_system_config> RobotClient::get_frame_system_conf
 
     const grpc::Status response = impl_->stub_->FrameSystemConfig(ctx, req, &resp);
     if (is_error_response(response)) {
-        VIAM_LOG(error) << "Error getting frame system config: " << response.error_message();
+        VIAM_SDK_LOG(error) << "Error getting frame system config: " << response.error_message();
     }
 
     const RepeatedPtrField<FrameSystemConfig> configs = resp.frame_system_configs();
@@ -367,7 +367,7 @@ pose_in_frame RobotClient::transform_pose(
 
     const grpc::Status response = impl_->stub_->TransformPose(ctx, req, &resp);
     if (is_error_response(response)) {
-        VIAM_LOG(error) << "Error getting PoseInFrame: " << response.error_message();
+        VIAM_SDK_LOG(error) << "Error getting PoseInFrame: " << response.error_message();
     }
 
     return from_proto(resp.pose());
@@ -402,8 +402,8 @@ void RobotClient::stop_all(const std::unordered_map<Name, ProtoStruct>& extra) {
     }
     const grpc::Status response = impl_->stub_->StopAll(ctx, req, &resp);
     if (is_error_response(response)) {
-        VIAM_LOG(error) << "Error stopping all: " << response.error_message()
-                        << response.error_details();
+        VIAM_SDK_LOG(error) << "Error stopping all: " << response.error_message()
+                            << response.error_details();
     }
 }
 
@@ -431,8 +431,8 @@ RobotClient::status RobotClient::get_machine_status() const {
 
     const grpc::Status response = impl_->stub_->GetMachineStatus(ctx, req, &resp);
     if (is_error_response(response)) {
-        VIAM_LOG(error) << "Error getting machine status: " << response.error_message()
-                        << response.error_details();
+        VIAM_SDK_LOG(error) << "Error getting machine status: " << response.error_message()
+                            << response.error_details();
     }
     switch (resp.state()) {
         case robot::v1::GetMachineStatusResponse_State_STATE_INITIALIZING:
diff --git a/src/viam/sdk/tests/test_log.cpp b/src/viam/sdk/tests/test_log.cpp
@@ -16,7 +16,7 @@ namespace sdktests {
 BOOST_AUTO_TEST_CASE(test_cout_logging) {
     cout_redirect redirect;
 
-    VIAM_LOG(info) << "log1";
+    VIAM_SDK_LOG(info) << "log1";
 
     using namespace std::string_literals;
 
@@ -32,28 +32,28 @@ BOOST_AUTO_TEST_CASE(test_cout_logging) {
 BOOST_AUTO_TEST_CASE(test_global_filter) {
     cout_redirect redirect;
 
-    VIAM_LOG(info) << "info1";
-    VIAM_LOG(error) << "error1";
-    VIAM_LOG(trace) << "trace1";  // not logged
+    VIAM_SDK_LOG(info) << "info1";
+    VIAM_SDK_LOG(error) << "error1";
+    VIAM_SDK_LOG(trace) << "trace1";  // not logged
 
     auto& logger = sdk::LogManager::get();
 
     using ll = sdk::log_level;
 
     logger.set_global_log_level(ll::trace);
 
-    VIAM_LOG(trace) << "trace2";
-    VIAM_LOG(info) << "info2";
+    VIAM_SDK_LOG(trace) << "trace2";
+    VIAM_SDK_LOG(info) << "info2";
 
     logger.set_global_log_level(ll::error);
 
-    VIAM_LOG(info) << "info3";  // not logged
-    VIAM_LOG(error) << "error2";
+    VIAM_SDK_LOG(info) << "info3";  // not logged
+    VIAM_SDK_LOG(error) << "error2";
 
     logger.set_global_log_level(ll::info);
 
-    VIAM_LOG(info) << "info4";
-    VIAM_LOG(trace) << "trace3";  // once again not logged
+    VIAM_SDK_LOG(info) << "info4";
+    VIAM_SDK_LOG(trace) << "trace3";  // once again not logged
 
     const std::string rec = redirect.os.str();
     redirect.release();

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,8 @@ namespace sdk {`
`14`	`14`	`namespace client_helper_details {`
`15`	`15`
`16`	`16`	`[[noreturn]] void errorHandlerReturnedUnexpectedly(const ::grpc::Status* status) noexcept {`
`17`		`- VIAM_LOG(fatal) << "ClientHelper error handler callback returned instead of throwing: "`
`18`		`- << status->error_message() << '(' << status->error_details() << ')';`
	`17`	`+ VIAM_SDK_LOG(fatal) << "ClientHelper error handler callback returned instead of throwing: "`
	`18`	`+ << status->error_message() << '(' << status->error_details() << ')';`
`19`	`19`	`std::abort();`
`20`	`20`	`}`
`21`	`21`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ log_level level_from_string(std::string level) {`
`55`	`55`	`return ll::fatal;`
`56`	`56`	`}`
`57`	`57`
`58`		- VIAM_LOG(warn) << "Returning unknown log level `" << level << "` as info";
	`58`	+ VIAM_SDK_LOG(warn) << "Returning unknown log level `" << level << "` as info";
`59`	`59`	`return ll::info;`
`60`	`60`	`}`
`61`	`61`
`@@ -132,11 +132,11 @@ void LogManager::init_logging() {`
`132`	`132`	`console_sink_->set_formatter(fmt);`
`133`	`133`
`134`	`134`	`boost::log::core::get()->add_sink(console_sink_);`
`135`		`- VIAM_LOG(debug) << "Initialized console logging";`
	`135`	`+ VIAM_SDK_LOG(debug) << "Initialized console logging";`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`void LogManager::disable_console_logging() {`
`139`		`- VIAM_LOG(debug) << "Disabling console logging";`
	`139`	`+ VIAM_SDK_LOG(debug) << "Disabling console logging";`
`140`	`140`
`141`	`141`	`// Set a filter which ignores all console logs unless they contain a console force flag which is`
`142`	`142`	`// set to true.`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ HandlerMap_ from_proto_impl<module::v1::HandlerMap>::operator()(`
`64`	`64`	`try {`
`65`	`65`	`hm.add_model(Model::from_str(mod), handle);`
`66`	`66`	`} catch (const std::exception& ex) {`
`67`		`- VIAM_LOG(error) << "Error " << ex.what() << " processing model " + mod;`
	`67`	`+ VIAM_SDK_LOG(error) << "Error " << ex.what() << " processing model " + mod;`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`	`}`
Original file line number	Diff line number	Diff line change
`@@ -121,9 +121,9 @@ RobotClient::~RobotClient() {`
`121`	`121`	`try {`
`122`	`122`	`this->close();`
`123`	`123`	`} catch (const std::exception& e) {`
`124`		`- VIAM_LOG(error) << "Received err while closing RobotClient: " << e.what();`
	`124`	`+ VIAM_SDK_LOG(error) << "Received err while closing RobotClient: " << e.what();`
`125`	`125`	`} catch (...) {`
`126`		`- VIAM_LOG(error) << "Received unknown err while closing RobotClient";`
	`126`	`+ VIAM_SDK_LOG(error) << "Received unknown err while closing RobotClient";`
`127`	`127`	`}`
`128`	`128`	`}`
`129`	`129`	`}`
`@@ -150,7 +150,7 @@ std::vector<RobotClient::operation> RobotClient::get_operations() {`
`150`	`150`
`151`	`151`	`grpc::Status const response = impl_->stub_->GetOperations(ctx, req, &resp);`
`152`	`152`	`if (is_error_response(response)) {`
`153`		`- VIAM_LOG(error) << "Error getting operations: " << response.error_message();`
	`153`	`+ VIAM_SDK_LOG(error) << "Error getting operations: " << response.error_message();`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`for (int i = 0; i < resp.operations().size(); ++i) {`
`@@ -168,7 +168,7 @@ void RobotClient::cancel_operation(std::string id) {`
`168`	`168`	`req.set_id(id);`
`169`	`169`	`const grpc::Status response = impl_->stub_->CancelOperation(ctx, req, &resp);`
`170`	`170`	`if (is_error_response(response)) {`
`171`		`- VIAM_LOG(error) << "Error canceling operation with id " << id;`
	`171`	`+ VIAM_SDK_LOG(error) << "Error canceling operation with id " << id;`
`172`	`172`	`}`
`173`	`173`	`}`
`174`	`174`
`@@ -181,7 +181,7 @@ void RobotClient::block_for_operation(std::string id) {`
`181`	`181`
`182`	`182`	`const grpc::Status response = impl_->stub_->BlockForOperation(ctx, req, &resp);`
`183`	`183`	`if (is_error_response(response)) {`
`184`		`- VIAM_LOG(error) << "Error blocking for operation with id " << id;`
	`184`	`+ VIAM_SDK_LOG(error) << "Error blocking for operation with id " << id;`
`185`	`185`	`}`
`186`	`186`	`}`
`187`	`187`
`@@ -192,7 +192,7 @@ void RobotClient::refresh() {`
`192`	`192`
`193`	`193`	`const grpc::Status response = impl_->stub_->ResourceNames(ctx, req, &resp);`
`194`	`194`	`if (is_error_response(response)) {`
`195`		`- VIAM_LOG(error) << "Error getting resource names: " << response.error_message();`
	`195`	`+ VIAM_SDK_LOG(error) << "Error getting resource names: " << response.error_message();`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`std::unordered_map<Name, std::shared_ptr<Resource>> new_resources;`
`@@ -216,8 +216,8 @@ void RobotClient::refresh() {`
`216`	`216`	`const Name name_({name.namespace_(), name.type(), name.subtype()}, "", name.name());`
`217`	`217`	`new_resources.emplace(name_, rpc_client);`
`218`	`218`	`} catch (const std::exception& exc) {`
`219`		`- VIAM_LOG(debug) << "Error registering component " << name.subtype() << ": "`
`220`		`- << exc.what();`
	`219`	`+ VIAM_SDK_LOG(debug)`
	`220`	`+ << "Error registering component " << name.subtype() << ": " << exc.what();`
`221`	`221`	`}`
`222`	`222`	`}`
`223`	`223`	`}`
`@@ -281,9 +281,9 @@ void RobotClient::log(const std::string& name,`
`281`	`281`	`if (is_error_response(response)) {`
`282`	`282`	`// Manually override to force this to get logged to console so we don't set off an infinite`
`283`	`283`	`// loop`
`284`		`- VIAM_LOG(error) << boost::log::add_value(sdk::impl::attr_console_force_type{}, true)`
`285`		`- << "Error sending log message over grpc: " << response.error_message()`
`286`		`- << response.error_details();`
	`284`	`+ VIAM_SDK_LOG(error) << boost::log::add_value(sdk::impl::attr_console_force_type{}, true)`
	`285`	`+ << "Error sending log message over grpc: " << response.error_message()`
	`286`	`+ << response.error_details();`
`287`	`287`	`}`
`288`	`288`	`}`
`289`	`289`
`@@ -339,7 +339,7 @@ std::vector<RobotClient::frame_system_config> RobotClient::get_frame_system_conf`
`339`	`339`
`340`	`340`	`const grpc::Status response = impl_->stub_->FrameSystemConfig(ctx, req, &resp);`
`341`	`341`	`if (is_error_response(response)) {`
`342`		`- VIAM_LOG(error) << "Error getting frame system config: " << response.error_message();`
	`342`	`+ VIAM_SDK_LOG(error) << "Error getting frame system config: " << response.error_message();`
`343`	`343`	`}`
`344`	`344`
`345`	`345`	`const RepeatedPtrField<FrameSystemConfig> configs = resp.frame_system_configs();`
`@@ -367,7 +367,7 @@ pose_in_frame RobotClient::transform_pose(`
`367`	`367`
`368`	`368`	`const grpc::Status response = impl_->stub_->TransformPose(ctx, req, &resp);`
`369`	`369`	`if (is_error_response(response)) {`
`370`		`- VIAM_LOG(error) << "Error getting PoseInFrame: " << response.error_message();`
	`370`	`+ VIAM_SDK_LOG(error) << "Error getting PoseInFrame: " << response.error_message();`
`371`	`371`	`}`
`372`	`372`
`373`	`373`	`return from_proto(resp.pose());`
`@@ -402,8 +402,8 @@ void RobotClient::stop_all(const std::unordered_map<Name, ProtoStruct>& extra) {`
`402`	`402`	`}`
`403`	`403`	`const grpc::Status response = impl_->stub_->StopAll(ctx, req, &resp);`
`404`	`404`	`if (is_error_response(response)) {`
`405`		`- VIAM_LOG(error) << "Error stopping all: " << response.error_message()`
`406`		`- << response.error_details();`
	`405`	`+ VIAM_SDK_LOG(error) << "Error stopping all: " << response.error_message()`
	`406`	`+ << response.error_details();`
`407`	`407`	`}`
`408`	`408`	`}`
`409`	`409`
`@@ -431,8 +431,8 @@ RobotClient::status RobotClient::get_machine_status() const {`
`431`	`431`
`432`	`432`	`const grpc::Status response = impl_->stub_->GetMachineStatus(ctx, req, &resp);`
`433`	`433`	`if (is_error_response(response)) {`
`434`		`- VIAM_LOG(error) << "Error getting machine status: " << response.error_message()`
`435`		`- << response.error_details();`
	`434`	`+ VIAM_SDK_LOG(error) << "Error getting machine status: " << response.error_message()`
	`435`	`+ << response.error_details();`
`436`	`436`	`}`
`437`	`437`	`switch (resp.state()) {`
`438`	`438`	`case robot::v1::GetMachineStatusResponse_State_STATE_INITIALIZING:`