dont use std::byte

Author: oliviamiller

src/viam/examples/modules/audioin/CMakeLists.txt

@@ -16,11 +16,6 @@ add_executable(audioin_module
   main.cpp
 )
 
-set_target_properties(audioin_module PROPERTIES
-  CXX_STANDARD 17
-  CXX_STANDARD_REQUIRED ON
-)
-
 target_link_libraries(audioin_module
   PRIVATE Threads::Threads
   viam-cpp-sdk::viamsdk
@@ -37,10 +32,6 @@ target_sources(audioin_client
     client.cpp
 )
 
-set_target_properties(audioin_client PROPERTIES
-  CXX_STANDARD 17
-  CXX_STANDARD_REQUIRED ON
-)
 
 target_link_libraries(audioin_client
   viam-cpp-sdk::viamsdk

src/viam/examples/modules/audioin/main.cpp

@@ -32,7 +32,7 @@ class SineWaveAudioIn : public AudioIn, public Reconfigurable {
 
     ProtoStruct do_command(const ProtoStruct&) override;
 
-    std::vector<GeometryConfig> get_geometries(const ProtoStruct&) {
+    std::vector<GeometryConfig> get_geometries(const ProtoStruct&) override {
         throw Exception("method not supported");
     }
 
@@ -120,7 +120,7 @@ void SineWaveAudioIn::get_audio(std::string const& codec,
 
         audio_chunk chunk;
 
-        // Convert int16_t samples to std::byte
+        // Convert int16_t samples to uint8_t bytes
         chunk.audio_data.resize(samples.size() * sizeof(int16_t));
         std::memcpy(chunk.audio_data.data(), samples.data(), chunk.audio_data.size());
 

src/viam/sdk/components/audio_in.hpp

@@ -42,7 +42,7 @@ class AudioIn : public Component {
     /// @brief A sequential chunk of audio data with timing information for continuous audio
     /// streams.
     struct audio_chunk {
-        std::vector<std::byte> audio_data;
+        std::vector<uint8_t> audio_data;
         audio_info audio_info;
         int64_t start_timestamp_ns;
         int64_t end_timestamp_ns;

src/viam/sdk/components/private/audio_in_client.cpp

@@ -42,11 +42,11 @@ void AudioInClient::get_audio(std::string const& codec,
             // Create audio_chunk struct from proto response
             audio_chunk chunk;
 
-            // Convert audio_data from string to std::vector<std::byte>
+            // Convert audio_data from string to std::vector<uint8_t>
             const std::string& audio_data_str = response.audio().audio_data();
             chunk.audio_data.reserve(audio_data_str.size());
             for (char c : audio_data_str) {
-                chunk.audio_data.push_back(static_cast<std::byte>(c));
+                chunk.audio_data.push_back(static_cast<uint8_t>(c));
             }
 
             chunk.sequence = response.audio().sequence();

src/viam/sdk/components/private/audio_in_server.cpp

@@ -27,7 +27,7 @@ ::grpc::Status AudioInServer::GetAudio(
             ::viam::component::audioin::v1::GetAudioResponse response;
             auto* audio_chunk = response.mutable_audio();
 
-            // Convert audio_data from std::vector<std::byte> to string
+            // Convert audio_data from std::vector<uint8_t> to string
             std::string audio_data_str;
             audio_data_str.reserve(chunk.audio_data.size());
             for (const auto& byte : chunk.audio_data) {

src/viam/sdk/tests/mocks/mock_audio_in.cpp

@@ -73,7 +73,7 @@ std::vector<AudioIn::audio_chunk> fake_audio_chunks() {
 
     for (int i = 0; i < 5; ++i) {
         AudioIn::audio_chunk chunk;
-        chunk.audio_data = std::vector<std::byte>(1024, static_cast<std::byte>(i + 1));
+        chunk.audio_data = std::vector<uint8_t>(1024, static_cast<uint8_t>(i + 1));
         chunk.audio_info.codec = "pcm16";
         chunk.audio_info.sample_rate_hz = 48000;
         chunk.audio_info.num_channels = 1;